LBRYCommunity/lbry-desktop
1
0
Fork 0
Code Issues 596 Pull requests 6 Projects Releases 238 Packages Wiki Activity

fetch ads provider for all homepage videos (but still only show ads for unauth users)

Browse source
This commit is contained in:
Sean Yesmunt 2021-04-26 16:28:25 -04:00
parent 807e520b0e
commit f2d83cbf9d
2 changed files with 7 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
ui/component/viewers/videoViewer/view.jsx
View file

@ -122,7 +122,7 @@ function VideoViewer(props: Props) {
const embedded = useContext(EmbedContext);
const approvedVideo = Boolean(channelClaimId) && adApprovedChannelIds.includes(channelClaimId);
const adsEnabled = ENABLE_PREROLL_ADS && !authenticated && !embedded && approvedVideo;
const [adUrl, setAdUrl, isFetchingAd] = useGetAds(adsEnabled);
const [adUrl, setAdUrl, isFetchingAd] = useGetAds(approvedVideo, adsEnabled);
/* isLoading was designed to show loading screen on first play press, rather than completely black screen, but
breaks because some browsers (e.g. Firefox) block autoplay but leave the player.play Promise pending */
const [isLoading, setIsLoading] = useState(false);

10
ui/effects/use-get-ads.js
View file

@ -9,12 +9,14 @@ const PRE_ROLL_ADS_PROVIDER = 'https://tag.targeting.unrulymedia.com/rmp/216276/
const ADS_CAP_LEVEL = 1 * 60 * 1000;
const vastClient = new VASTClient(0, ADS_CAP_LEVEL);
export function useGetAds(adsEnabled: boolean): [?string, (?string) => void, boolean] {
export function useGetAds(approvedVideo: boolean, adsEnabled: boolean): [?string, (?string) => void, boolean] {
const [isFetching, setIsFetching] = React.useState(true);
const [adUrl, setAdUrl] = React.useState();
// Fetch ads for all approved videos, even if we won't show ads to the user
// Unruly needs more fetches before they will start returning ads ¯\_(ツ)_/¯
React.useEffect(() => {
if (!adsEnabled) {
if (!approvedVideo) {
setIsFetching(false);
return;
}
@ -37,7 +39,7 @@ export function useGetAds(adsEnabled: boolean): [?string, (?string) => void, boo
// Dummy video file
// const adUrl = 'https://interactive-examples.mdn.mozilla.net/media/cc0-videos/flower.mp4';
if (adUrl) {
if (adsEnabled && adUrl) {
setAdUrl(adUrl);
}
}
@ -47,7 +49,7 @@ export function useGetAds(adsEnabled: boolean): [?string, (?string) => void, boo
.catch(() => {
setIsFetching(false);
});
}, [adsEnabled]);
}, [approvedVideo, adsEnabled]);
return [adUrl, setAdUrl, isFetching];
}