LBRYCommunity/lbry-desktop
1
0
Fork 0
Code Issues 596 Pull requests 6 Projects Releases 238 Packages Wiki Activity

Outbrain: remove visibility delay

Browse source 
They have removed the blocking transparent container when ads are not (or not yet) filled.
This commit is contained in:
infinite-persistence 2022-03-22 22:50:25 +08:00 committed by Thomas Zarebczan
parent 71e9837002
commit f57dd6af96
1 changed files with 0 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
ui/effects/use-ad-outbrain.js
View file

@ -20,32 +20,12 @@ export default function useAdOutbrain(hasPremiumPlus: boolean, isAuthenticated:
// when returned as false
const isNotAuthenticated = isAuthenticated === false;
function loadListener() {
const container = window[OUTBRAIN_CONTAINER_KEY];
if (container) {
// Hide it immediately while we wait for ads to be filled. This prevents
// the invisible container from blocking our content.
container.style.visibility = 'hidden';
container.style.zIndex = '800'; // any value below $nag-z-index
// Restore visibility after confirming the ad is filled. If it is filled
// after the stipulated time, well, no soup for you.
setTimeout(() => {
const filledAd = document.querySelector('.ob-widget-items-container');
if (filledAd && isNotAuthenticated) {
container.style.visibility = 'visible';
}
}, 5000); // 3s is sufficient for Chrome, but Firefox seems to take ~5s
}
}
React.useEffect(() => {
if (!inIFrame() && isNotAuthenticated && !script) {
const loadTimer = setTimeout(() => {
script = document.createElement('script');
script.src = 'https://adncdnend.azureedge.net/adtags/odysee.adn.js';
script.async = true;
script.addEventListener('load', loadListener); // not using 'script.onload'; seem unreliable with async.
// $FlowFixMe
document.body.appendChild(script);