LBRYCommunity/lbry-desktop
1
0
Fork 0
Code Issues 596 Pull requests 6 Projects Releases 238 Packages Wiki Activity

Merge pull request #114 from lbryio/version-info-logic-fix

Browse source 
Don't try to send version info to render process if window isn't open
This commit is contained in:
Jeremy Kauffman 2017-05-05 08:59:24 -04:00 • committed by GitHub
commit f5dec02fd9
1 changed files with 9 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
app/main.js
View file

@ -52,19 +52,25 @@ function checkForNewVersion(callback) {
const [_, remoteVersion] = tagName.match(/^v([\d.]+(?:-?rc\d+)?)$/); const [_, remoteVersion] = tagName.match(/^v([\d.]+(?:-?rc\d+)?)$/);
if (!remoteVersion) { if (!remoteVersion) {
console.log('Malformed remote version string:', tagName); console.log('Malformed remote version string:', tagName);
win.webContents.send('version-info-received', null); if (win) {
win.webContents.send('version-info-received', null);
}
} else { } else {
console.log('Remote version:', remoteVersion); console.log('Remote version:', remoteVersion);
const upgradeAvailable = semver.gt(formatRc(remoteVersion), formatRc(localVersion)); const upgradeAvailable = semver.gt(formatRc(remoteVersion), formatRc(localVersion));
console.log(upgradeAvailable ? 'Upgrade available' : 'No upgrade available'); console.log(upgradeAvailable ? 'Upgrade available' : 'No upgrade available');
win.webContents.send('version-info-received', {remoteVersion, localVersion, upgradeAvailable}); if (win) {
win.webContents.send('version-info-received', {remoteVersion, localVersion, upgradeAvailable});
}
} }
}) })
}); });
req.on('error', (err) => { req.on('error', (err) => {
console.log('Failed to get current version from GitHub. Error:', err); console.log('Failed to get current version from GitHub. Error:', err);
win.webContents.send('version-info-received', null); if (win) {
win.webContents.send('version-info-received', null);
}
}); });
} }