LBRYCommunity/lbry-desktop
1
0
Fork 0
Code Issues 596 Pull requests 6 Projects Releases 238 Packages Wiki Activity

Change constants to object for IDE auto complete

Browse source 
No functional change; just thought this is cleaner (group up the constants) and easier to type via IDE auto-complete, at the expense of creating an extra object.
This commit is contained in:
infinite-persistence 2021-07-23 14:36:39 +08:00
parent 8dc18e8fcd
commit f6e648222e
No known key found for this signature in database
GPG key ID: B9C3252EDC3D0AA0
1 changed files with 20 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

36
ui/page/channel/view.jsx
View file

@ -28,11 +28,15 @@ import I18nMessage from 'component/i18nMessage';
import PlaceholderTx from 'static/img/placeholderTx.gif'; import PlaceholderTx from 'static/img/placeholderTx.gif';
export const PAGE_VIEW_QUERY = `view`; export const PAGE_VIEW_QUERY = `view`;
const CONTENT_PAGE = 'content';
const LISTS_PAGE = 'lists';
const ABOUT_PAGE = `about`;
export const DISCUSSION_PAGE = `discussion`; export const DISCUSSION_PAGE = `discussion`;
const EDIT_PAGE = 'edit';
const PAGE = {
CONTENT: 'content',
LISTS: 'lists',
ABOUT: 'about',
DISCUSSION: DISCUSSION_PAGE,
EDIT: 'edit',
};
type Props = { type Props = {
uri: string, uri: string,
@ -85,7 +89,7 @@ function ChannelPage(props: Props) {
const urlParams = new URLSearchParams(search); const urlParams = new URLSearchParams(search);
const currentView = urlParams.get(PAGE_VIEW_QUERY) || undefined; const currentView = urlParams.get(PAGE_VIEW_QUERY) || undefined;
const [discussionWasMounted, setDiscussionWasMounted] = React.useState(false); const [discussionWasMounted, setDiscussionWasMounted] = React.useState(false);
const editing = urlParams.get(PAGE_VIEW_QUERY) === EDIT_PAGE; const editing = urlParams.get(PAGE_VIEW_QUERY) === PAGE.EDIT;
const { channelName } = parseURI(uri); const { channelName } = parseURI(uri);
const { permanent_url: permanentUrl } = claim; const { permanent_url: permanentUrl } = claim;
const claimId = claim.claim_id; const claimId = claim.claim_id;
@ -143,16 +147,16 @@ function ChannelPage(props: Props) {
// would alter the Tab label's role attribute, which should stay role="tab" to work with keyboards/screen readers. // would alter the Tab label's role attribute, which should stay role="tab" to work with keyboards/screen readers.
let tabIndex; let tabIndex;
switch (currentView) { switch (currentView) {
case CONTENT_PAGE: case PAGE.CONTENT:
tabIndex = 0; tabIndex = 0;
break; break;
case LISTS_PAGE: case PAGE.LISTS:
tabIndex = 1; tabIndex = 1;
break; break;
case ABOUT_PAGE: case PAGE.ABOUT:
tabIndex = 2; tabIndex = 2;
break; break;
case DISCUSSION_PAGE: case PAGE.DISCUSSION:
tabIndex = 3; tabIndex = 3;
break; break;
default: default:
@ -165,20 +169,20 @@ function ChannelPage(props: Props) {
let search = '?'; let search = '?';
if (newTabIndex === 0) { if (newTabIndex === 0) {
search += `${PAGE_VIEW_QUERY}=${CONTENT_PAGE}`; search += `${PAGE_VIEW_QUERY}=${PAGE.CONTENT}`;
} else if (newTabIndex === 1) { } else if (newTabIndex === 1) {
search += `${PAGE_VIEW_QUERY}=${LISTS_PAGE}`; search += `${PAGE_VIEW_QUERY}=${PAGE.LISTS}`;
} else if (newTabIndex === 2) { } else if (newTabIndex === 2) {
search += `${PAGE_VIEW_QUERY}=${ABOUT_PAGE}`; search += `${PAGE_VIEW_QUERY}=${PAGE.ABOUT}`;
} else { } else {
search += `${PAGE_VIEW_QUERY}=${DISCUSSION_PAGE}`; search += `${PAGE_VIEW_QUERY}=${PAGE.DISCUSSION}`;
} }
push(`${url}${search}`); push(`${url}${search}`);
} }
React.useEffect(() => { React.useEffect(() => {
if (currentView === DISCUSSION_PAGE) { if (currentView === PAGE.DISCUSSION) {
setDiscussionWasMounted(true); setDiscussionWasMounted(true);
} }
}, [currentView]); }, [currentView]);
@ -241,7 +245,7 @@ function ChannelPage(props: Props) {
<Button <Button
button="alt" button="alt"
title={__('Edit')} title={__('Edit')}
onClick={() => push(`?${PAGE_VIEW_QUERY}=${EDIT_PAGE}`)} onClick={() => push(`?${PAGE_VIEW_QUERY}=${PAGE.EDIT}`)}
icon={ICONS.EDIT} icon={ICONS.EDIT}
iconSize={18} iconSize={18}
disabled={pending} disabled={pending}
@ -304,7 +308,7 @@ function ChannelPage(props: Props) {
<ChannelAbout uri={uri} /> <ChannelAbout uri={uri} />
</TabPanel> </TabPanel>
<TabPanel> <TabPanel>
{(discussionWasMounted || currentView === DISCUSSION_PAGE) && <ChannelDiscussion uri={uri} />} {(discussionWasMounted || currentView === PAGE.DISCUSSION) && <ChannelDiscussion uri={uri} />}
</TabPanel> </TabPanel>
</TabPanels> </TabPanels>
</Tabs> </Tabs>