Commit graph

15 commits

Author SHA1 Message Date
zeppi
ee9f63a161 integrate all the things
bugfix

wip

flow

fix

cleaning

clean
2021-10-15 23:49:41 -04:00
infinite-persistence
d97a23b699 Rename default import/exports for clarity in text search (no functional change)
I believe it was just due to copy/pasting from another file and not renaming it.
2021-07-09 08:40:26 +08:00
infinite-persistence
fc7edc875b
ChannelThumbnail improvements
- [x] (6332) The IntersectionObserver method of lazy-loading loads cached images visibly late on slower devices. Previously, it was also showing the "broken image" icon briefly, which we mended by placing a dummy transparent image as the initial src.
  - Reverted that ugly transparent image fix.
  - Use the browser's built-in `loading="lazy"` instead. Sorry, Safari.

- [x] Size-optimization did not take "device pixel ratio" into account.
  - When resizing an image through the CDN, we can't just take the dimensions of the tag in pixels directly -- we need to take zooming into account, otherwise the image ends up blurry.
  - Previously, we quickly disabled optimization for the channel avatar in the Channel Page because of this. Now that we know the root-cause, the change was reverted and we now go through the CDN with appropriate sizes. This also improves our Web Vital scores.

- [x] Size-optimization wasn't really implemented for all ChannelThumbnail instances.
  - The CDN-optimized size was hardcoded to the largest instance, so small images like sidebar thumbnails are still loading images that are unnecessarily larger.
  - There's a little-bit of hardcoding of values from CSS here, but I think it's a ok compromise (not something we change often). It also doesn't need to be exact -- the "device pixel ratio" calculate will ensure it's slightly larger than what we need.

- [x] Set `width` and `height` of `<img>` to improve CLS.
  - Addresses Ligthhouse complaints, although technically the shifting was addressed at the `ClaimPreviewTile` level (sub-container dimensions are well defined).
  - Notes: the values don't need to be the final CSS-adjusted sizes. It just needs to be in the right aspect ratio to help the browser pre-allocate space to avoid shifts.

- [x] Add option to disable lazy-load Channel Thumbnails
  - The guidelines mentioned that items that are already in the viewport should not enable `loading="lazy"`.
  - We have a few areas where it doesn't make sense to lazy-load (e.g. thumbnail in Header, channel selector dropdown, publish preview, etc.).
2021-07-05 16:04:10 +08:00
saltrafael
c92bcc945f remove analytics 2021-06-15 13:47:56 -04:00
saltrafael
3a6bddc588 fix multiple channels analytics bug 2021-06-15 13:47:56 -04:00
Sean Yesmunt
da3e3c8404 add new 'livestream' publish mode 2021-03-22 15:30:03 -07:00
infiinte-persistence
f660267dc5 Untranslated strings
Included the memes as well per translator request. I've been excluding it since I wasn't sure if memes can be translated, but I guess they can change it to something equivalent in their language.
2021-02-19 14:28:50 -05:00
Sean Yesmunt
db87125dc8 refactor 'active' channel usage across the app 2021-02-11 10:45:34 -05:00
btzr-io
6c9538e4f5 remove unnecessary div wraper 2020-05-08 14:16:40 -04:00
btzr-io
a8f6185f12 fix channel selector styles
fix #4072
2020-05-08 14:16:40 -04:00
Sean Yesmunt
6af22e7caf only select new channels in selector if they aren't currently selected 2020-03-20 15:17:15 -04:00
seanyesmunt
4420983a79 cleanup 2020-03-19 12:12:19 -04:00
seanyesmunt
73b7b45b73 improve empty states 2020-03-19 12:12:19 -04:00
seanyesmunt
a4f1a2e224 add badge to analytics page link 2020-03-19 12:12:19 -04:00
seanyesmunt
bc32341aab initial commit for creator analytics 2020-03-19 12:12:19 -04:00