Commit graph

78 commits

Author SHA1 Message Date
btzr-io 2dbd5d0f00 fix sidebar shortcut activation on textarea: #6326 2021-07-13 18:07:41 -04:00
jessopb be879ae90a
Recon 7 6 b (#6418)
* changes

* clean

* showNoSourceClaims
2021-07-07 14:21:11 -04:00
infinite-persistence fc7edc875b
ChannelThumbnail improvements
- [x] (6332) The IntersectionObserver method of lazy-loading loads cached images visibly late on slower devices. Previously, it was also showing the "broken image" icon briefly, which we mended by placing a dummy transparent image as the initial src.
  - Reverted that ugly transparent image fix.
  - Use the browser's built-in `loading="lazy"` instead. Sorry, Safari.

- [x] Size-optimization did not take "device pixel ratio" into account.
  - When resizing an image through the CDN, we can't just take the dimensions of the tag in pixels directly -- we need to take zooming into account, otherwise the image ends up blurry.
  - Previously, we quickly disabled optimization for the channel avatar in the Channel Page because of this. Now that we know the root-cause, the change was reverted and we now go through the CDN with appropriate sizes. This also improves our Web Vital scores.

- [x] Size-optimization wasn't really implemented for all ChannelThumbnail instances.
  - The CDN-optimized size was hardcoded to the largest instance, so small images like sidebar thumbnails are still loading images that are unnecessarily larger.
  - There's a little-bit of hardcoding of values from CSS here, but I think it's a ok compromise (not something we change often). It also doesn't need to be exact -- the "device pixel ratio" calculate will ensure it's slightly larger than what we need.

- [x] Set `width` and `height` of `<img>` to improve CLS.
  - Addresses Ligthhouse complaints, although technically the shifting was addressed at the `ClaimPreviewTile` level (sub-container dimensions are well defined).
  - Notes: the values don't need to be the final CSS-adjusted sizes. It just needs to be in the right aspect ratio to help the browser pre-allocate space to avoid shifts.

- [x] Add option to disable lazy-load Channel Thumbnails
  - The guidelines mentioned that items that are already in the viewport should not enable `loading="lazy"`.
  - We have a few areas where it doesn't make sense to lazy-load (e.g. thumbnail in Header, channel selector dropdown, publish preview, etc.).
2021-07-05 16:04:10 +08:00
zeppi 16cfe1c815 remove junk 2021-06-22 14:18:31 -04:00
zeppi 2268ab01fb app works when id api fails 2021-06-18 10:57:19 -04:00
zeppi eb0992879c sidebar channels no staked 2021-06-17 10:44:10 -04:00
Marios Vladimerou d8b40931f3 Show channel thumbnails in side menu 2021-06-17 10:28:16 -04:00
zeppi ff5c28a70f lists for all 2021-06-15 18:37:35 -04:00
zeppi ca116ba010 wip
wip

wip - everything but publish, autoplay, and styling

collection publishing

add channel to collection publish

cleanup

wip

bump

clear mass add after success

move collection item management controls

redirect replace to published collection id

bump

playlist selector on create

bump

use new collection add ui element

bump

wip

gitignore

add content json

wip

bump

context add to playlist

basic collections page style pass wip

wip: edits, buttons, styles...

change fileAuthor to claimAuthor

update, pending bugfixes, delete modal progress, collection header, other bugfixes

bump

cleaning

show page bugfix

builtin collection headers

no playlists, no grid title

wip

style tweaks

use normal looking claim previews for collection tiles

add collection changes

style library previews

collection menulist for delete/view on library

delete modal works for unpublished

rearrange collection publish tabs

clean up collection publishing and items

show on odysee

begin collectoin edit header and css renaming

better thumbnails

bump

fix collection publish redirect

view collection in menu does something

copy and thumbs

list previews, pending, context menus, list page

enter to add collection, lists page empty state

playable lists only, delete feature, bump

put fileListDownloaded back

better collection titles

improve collection claim details

fix horiz more icon

fix up channel page

style, copy, bump

refactor preview overlay properties,
fix reposts showing as floppydisk
add watch later toast,
small overlay properties on wunderbar results,
fix collection actions buttons

bump

cleanup

cleaning, refactoring

bump

preview thumb styling, cleanup

support discover page lists search

sync, bump

bump, fix sync more

enforce builtin order for now

new lists page empty state

try to indicate unpublished edits in lists

bump

fix autoplay and linting

consts, fix autoplay

bugs

fixes

cleanup

fix, bump

lists experimental ui, fixes

refactor listIndex out

hack in collection fallback thumb

bump
2021-06-08 13:25:52 -04:00
infinite-persistence d6d1cf58e9 Fix SidebarNavigation key errors 2021-06-01 11:15:30 -04:00
Sean Yesmunt 9f3d779cf2 add tags to mobile navigation and add manage tags link on tag page 2021-04-13 17:08:24 -04:00
Sean Yesmunt 1aaaf118c5 remove signup nudge in sidebar for lbry.tv 2021-03-21 20:48:27 -04:00
infinite-persistence b467873f0b Notification bell shows is_read, not is_seen
## Issue
Closes 5664: notification bell shows is_read, not is_seen
2021-03-16 11:39:52 -04:00
Sean Yesmunt b9f8fd73f1 fix sidebar for mobile 2020-12-17 13:55:58 -05:00
Sean Yesmunt e6b502dd4a hide duplicate purchase page link on sidebar 2020-12-15 16:22:40 -05:00
Sean Yesmunt caae63b44b refresh homepage if clicking 'home' while on the homepage 2020-12-08 11:45:18 -05:00
zeppi cf1d051288 no tiny sidebar signup 2020-12-04 09:22:36 -05:00
Sean Yesmunt d012300fe9 remove double 'discover' link showing up in mobile side nav 2020-11-23 14:03:51 -05:00
Sean Yesmunt 89aaf523ca keep discover page only for non SIMPLE_SITEs 2020-11-17 18:45:26 -05:00
Sean Yesmunt e5301dec04 move nudge to FileReactions and add src param to sign up redirects 2020-11-17 14:32:53 -05:00
Sean Yesmunt 29e7af5bfc move links for better odysee parity 2020-11-16 19:09:09 -05:00
Sean Yesmunt 3b6882412a enable 'discover' page for everyone 2020-11-16 14:11:52 -05:00
infiinte-persistence fc79c87bba Fix sidebar tooltip showing string with context metadata.
## Issue
In the odysee branch, the tooltip for "Following" in the Sidebar was shown as "Following --[sidebar]--". In lbry.tv, the tooltip doesn't appear.

I believe the tooltip appeared due to the name change from 'label' to 'title' and then being passed to Button through '...passedProps'.

Fix by explicitly setting the Button's 'title' to the localized text.
2020-11-12 15:21:40 -05:00
zeppi 3da7ec5c2c fix links spread bug 2020-11-10 14:02:59 -05:00
Sean Yesmunt 47f45fce0c fix typos 2020-11-10 12:22:25 -05:00
Sean Yesmunt 4b59bd0223 add back help links for SIMPLE_SITE 2020-11-10 12:08:19 -05:00
Sean Yesmunt 1023f30b4c initial PR for custom homepages - take 2 2020-11-10 12:08:19 -05:00
Sean Yesmunt 353c1a5689 Revert "unified custom homepage"
This reverts commit 55768fc6b5.
2020-11-10 10:36:11 -05:00
Sean Yesmunt 1814733d5b Revert "add back sign up nudge"
This reverts commit f0cabbff7d.
2020-11-10 10:36:11 -05:00
Sean Yesmunt f0cabbff7d add back sign up nudge 2020-11-10 10:24:04 -05:00
jessop 55768fc6b5 unified custom homepage 2020-11-10 10:24:04 -05:00
Sean Yesmunt f63de7f930 add nudges to sign up 2020-11-10 00:33:27 -05:00
infiinte-persistence 80b4600f60 Str-context-split: "Follow"
## Issue
4192
2020-10-14 17:44:44 -04:00
Sean Yesmunt 30e18a2d99 fix rebase 2020-09-29 17:12:32 -04:00
Sean Yesmunt 49a7f30f45 fix loading state for tile layout 2020-09-29 17:12:32 -04:00
Sean Yesmunt 2dee81b624 Sign In => Log in 2020-09-29 17:12:32 -04:00
Sean Yesmunt 14113f3c35 handle external pinned links 2020-09-23 11:01:56 -04:00
Sean Yesmunt 51214bd246 add back pinned sidebar links 2020-09-22 18:35:13 -04:00
infiinte-persistence a0df0a0e0a Sidebar: Bring back the "Followed Tags" list
## Issue
4708: Bring back tag list in side bar when Tags view selected

## Approach
- Instead of displaying either Channels or Tags, both will now be displayed.
- The tags will simply be a the same button component as the "channels", but with a "#" prefix. This simplifies the CSS-side changes, and looks better overall as well.
2020-09-04 11:50:02 -04:00
Sean Yesmunt 6377dc86e0 fix side navigation scroll behavior on mobile 2020-08-26 11:01:33 -04:00
jessop 4a86d25891 fix react dom warning passing hideForUnauth 2020-08-26 10:25:36 -04:00
Sean Yesmunt e0e33eb148 additional copy changes 2020-08-21 11:47:41 -04:00
Sean Yesmunt 7e35de3760 Register => Sign Up 2020-08-21 11:47:41 -04:00
Sean Yesmunt 764af3a5db wrap IS_MAC statements inside app ifdef 2020-08-21 11:47:41 -04:00
Sean Yesmunt b688fc1cc0 use 'Library' label instead of 'Purchased' on desktop 2020-08-20 22:33:13 -04:00
Sean Yesmunt 7b23126379 fix side navigation on mac
mac has an extra header height to handle the top level menu buttons
2020-08-20 22:33:13 -04:00
Sean Yesmunt 17feef93df add back sign out link on mobile 2020-08-20 11:14:51 -04:00
infiinte-persistence b49df1fc0a Fix translation failure on the Sidebar
## Issue
The sidebar text stuck in English despite already translated.

I'm guessing the i18n macro only ran once for the global object.

## Change
Run the macro on the label when passing it to the `Button`.
2020-08-13 11:10:08 -04:00
Sean Yesmunt a31f14b016 cleanup 2020-08-11 17:04:14 -04:00
Sean Yesmunt 692862c769 collapsable sidebar initial commit 2020-08-11 17:04:14 -04:00