Commit graph

11412 commits

Author SHA1 Message Date
infinite-persistence
fd66e6b9b1
Refactor Commentron error msg handling
## Issue
6832: Pass through commenting error if it fails current error list

## Changes
- Refactor the error-msg-replacing code to make it easier to add new ones in the future.
- Made the new error message localizable (i.e. extract the variable value, pass to `__()`)
- Fallback to Commentron original message for those unhandled ones (usually fresh messages from Commentron).
2021-08-10 10:26:58 +08:00
infinite-persistence
19091f249a
Fix 'Favorites' string issue
Renamed variables for clarity while at it.

"Item added to %name%" is probably redundant due to toast passing through <i18nMessage>, causing a double translation.

Anyway, added all the resolved string for now to avoid them popping up in app-string during development.
2021-08-10 00:48:37 +08:00
infinite-persistence
9d663b3789
i18n 2021-08-09 11:47:32 +08:00
infinite-persistence
cf905d25d5
Add keyword hint | Collapse "PR Checklist" and "PR Type"
## Changes
1. Add hint on adding "Closes", "Fixes", etc. keywords to directly update the Issue state when the PR gets merged
2. Collapse "PR Checklist" and "PR Type".
    - With the assumption that these 2 items are mainly reminders for contributors, and that reviewers will typically only look at it one time, we collapse these sections to reduce clutter in the PR description.
2021-08-08 09:47:08 +08:00
Baltazar Gomez
dbaa702888
fix wrong embed og metadata: #6814 2021-08-08 09:10:01 +08:00
infinite-persistence
b7cbbd0694
#6787 Use resolve for OG metadata 2021-08-07 19:41:24 +08:00
btzr-io
c85e448499
fix redirection and normalization of claim urls 2021-08-07 19:23:14 +08:00
btzr-io
68e4684ccd
use better resolve url 2021-08-07 19:23:00 +08:00
btzr-io
2c812da785
fix embed claim url 2021-08-07 10:16:10 +08:00
btzr-io
722f933052
use value.release_time 2021-08-07 10:16:09 +08:00
btzr-io
67f956f3a0
update changelog 2021-08-07 10:16:09 +08:00
btzr-io
45fcf0d518
use value.audio for google video metadata 2021-08-07 10:16:08 +08:00
Baltazar Gomez
6d91d1c799
use resolve for og metadata 2021-08-07 10:16:07 +08:00
zeppi
be4c75c047 v0.51.2-rc.1 2021-08-06 17:12:35 -04:00
Thomas Zarebczan
6db75f8a66 rss tests
Various fixes and improvements to work with Apple Podcasts

f

f

image support
2021-08-06 17:05:36 -04:00
saltrafael
7921c0971e Improve style 2021-08-06 15:07:10 -04:00
saltrafael
c55978f9d6 Allow to delete downloaded content from popup 2021-08-06 15:07:10 -04:00
saltrafael
4f0c6030e1 Add back file download link 2021-08-06 15:07:10 -04:00
Baltazar Gomez
cc7d2803bc update changelog 2021-08-06 14:55:17 -04:00
Baltazar Gomez
155309deee fix line breaking links: #6805 2021-08-06 14:55:17 -04:00
Franco Montenegro
6b071bab21 Fix amountNeededForTakeover message for bids. 2021-08-06 14:16:38 -04:00
zeppi
ab2bf481d1 bump 2021-08-06 14:16:27 -04:00
zeppi
5b4d8065e6 fix dislike crash when no claim 2021-08-06 14:10:05 -04:00
zeppi
1487b83ac5 branded site default 2021-08-06 13:46:32 -04:00
zeppi
4b64c35360 sunset link 2021-08-06 13:30:33 -04:00
zeppi
4bcd5942af oops 2021-08-06 12:27:37 -04:00
zeppi
2a19f9f63c lrytv sunset nag 2021-08-06 12:27:37 -04:00
Baltazar Gomez
ddb4c051ee Update CHANGELOG.md 2021-08-06 09:45:04 -04:00
Baltazar Gomez
76201e5955 fix text overflow past 3 dot menu: #6602 2021-08-06 09:45:04 -04:00
eniamza
8bec365fb4
Added: PR 6733 to changelog 2021-08-05 11:09:44 -04:00
eniamza
c146bfcd2d
Fix: Added \ and = to Reserved symbols warning 2021-08-05 11:09:30 -04:00
dependabot[bot]
ceb1b91273 Bump tar from 4.4.13 to 4.4.15 in /web
Bumps [tar](https://github.com/npm/node-tar) from 4.4.13 to 4.4.15.
- [Release notes](https://github.com/npm/node-tar/releases)
- [Changelog](https://github.com/npm/node-tar/blob/main/CHANGELOG.md)
- [Commits](https://github.com/npm/node-tar/compare/v4.4.13...v4.4.15)

---
updated-dependencies:
- dependency-name: tar
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-08-04 12:20:10 -04:00
Baltazar Gomez
8a89645f73 update changelog 2021-08-04 12:17:14 -04:00
Baltazar Gomez
1a1f145d14 fix desktop deep links handler 2021-08-04 12:17:14 -04:00
infinite-persistence
f2e583f314 RSS: change from 'download' to 'stream' url to pass Media Test
This apparently ensures the media is playable across all devices and apps.
2021-08-04 12:07:14 -04:00
infinite-persistence
0af1dfe282 RSS: podcast support
## Issue
`https://github.com/lbryio/lbry-desktop/issues/6369#issuecomment-882081892`

## Changes
- Replace 'feed' with 'node-rss' for itunes spec support.
- Replace content type from 'rss+xml' to 'xml' so that the browser will display it nicely using the document tree without us having to re-format it ('node-rss' does not). Seems like all feeds that I found does it this way.
- There is no need to escape characters now that 'node-rss' does it. Nice.
2021-08-04 12:07:14 -04:00
saltrafael
60f4cca007 Fix no expand button bug 2021-08-04 09:33:42 -04:00
infinite-persistence
2cb950b6d8
Fix string context entry
Forgot to remove the context string from the actual string.
2021-08-04 14:43:46 +08:00
zeppi
fe35ea3764 stream type string or array 2021-08-03 14:49:59 -04:00
zeppi
67bcc1b1ec build 2021-08-03 14:49:59 -04:00
zeppi
ff5ca7398c naming 2021-08-03 13:38:17 -04:00
zeppi
e3e5c50a13 style logo in embed 2021-08-03 13:38:17 -04:00
saltrafael
426042feab Fix icon color 2021-08-03 13:23:31 -04:00
saltrafael
a6ad758c71 Show on content page if a file is part of a playlist already 2021-08-03 13:23:31 -04:00
zeppi
413b19a7e9 sync edited playlists 2021-08-03 11:47:54 -04:00
infinite-persistence
4156e83f57 Fix: OG messed up if $" is in title
## Issue
5951: OG messed up if `$"` is in title

The replacement string would contain `...$&quot...`. The character `$&` has special meaning in `replace`, so the output was messed up.

## Approach
Use a direct slice approach. A bit less elegant.
2021-08-03 11:36:26 -04:00
zeppi
2d66b8666d styling 2021-08-03 11:05:32 -04:00
saltrafael
f01fb7dd22 Mobile view: Make comments expandable 2021-08-03 11:05:32 -04:00
infinite-persistence
1d6101ddd2 Report recsys info when 'share_data_usage' is enabled.
Previous:
~~Although it was collecting info for all platforms, the data is only sent for Odysee.~~ Correction: it became enabled for all platform after `master` became Odysee.

New:
Only send out the telemetry for `IS_WEB` or if there's user consent.
2021-08-03 09:34:36 -04:00
infinite-persistence
34368760de Fill in remaining Recsys fields
## Issue
6366 Recsys Evaluation Telemetry

The recommended list from lighthouse is obtained from `makeSelectRecommendedContentForUri`. This list is further tweaked by the GUI (e.g. move autoplay next item to top, remove blocked content, etc.). Recsys wants the final recommendation list and the clicked index (in exact order), so we need pass these info to the videojs recsys plugin somehow. Also, Recsys wants a recommendation list ID as well as the parent (referrer) ID, we so need to track the clicks and navigation.

## General Approach
- It seems easiest to just spew back the final (displayed) list and all the required info to Redux, and the recsys plugin (or anyone else in the future) can grab it.
- Try to touch few files as possible. The dirty work should all reside in `<RecommendedContent>` only.

## Changes
- `ClaimPreview`: add optional parameters to store an ID of the container that it is in (for this case, it is `ClaimList`) as well as the index within the container.
  - When clicked, we store the container ID in the navigation history `state` object.
    - For general cases, anyone can check this state from  `history.location.state` to know which container referred/navigated to the current page. For the recsys use case, we can use this as the `parentUUID`.
- `ClaimList`: just relay `onClick` and set IDs.
- `RecommendedContent`: now handles the uuid generation (for both parent and child) and stores the data in Redux.
2021-08-03 09:34:36 -04:00