Commit graph

3976 commits

Author SHA1 Message Date
zeppi
248bb406e9 bugfix 2021-07-29 13:09:03 -04:00
zeppi
816c7089c1 wpe on ody 2021-07-29 13:09:03 -04:00
infinite-persistence
4ff0a2f916
Fix missing file-thumbnail in Notifications
## Issue
6721 Notifications: Thumbnail for "new content" not showing up in Desktop layout

## Change
The `className` wasn't propagated during the `FileThumbnail` refactoring to `Thumbs`.
2021-07-29 16:03:51 +08:00
zeppi
69676b3de5 livestream api constant rename 2021-07-28 15:53:34 -04:00
zeppi
0468863daf live url 2021-07-28 15:53:34 -04:00
zeppi
d6c53b9389 embed 2021-07-28 15:53:34 -04:00
zeppi
148e6a0fa1 livestream endpoint 2021-07-28 15:53:34 -04:00
Anthony
a2104318b6 odysee
pull out variable for max and min fiat amounts

odysee

fix replay select styling

make meme a link

Fix audio references

get newest livestream claim in livestreamLink

pin crackermilk

fix livestream banner placement

fix live page

fix rebase

fix rebase

fix error nag

fix darkmode blockquote style

break word on livestream comment text

fix dark mode snack

fix live badge

fix lint

small fixes - word wrap, live badge

wip

Fix invisible snack in Odysee Light Theme

Revert "wip"

This reverts commit d17e477fe0.

Revert "small fixes - word wrap, live badge"

This reverts commit 0e431d4038.

fix blank

pinned destiny

fix badges and homepage again

only get livestreams live for less than a day

pinned hammy and olivia

multi pin

pin destiny

updated pinned videos

update tagline

Update view.jsx

pins

updated destiny's video

updated pinned videos

removed destiny, added lie likes music

pinned destiny and mason's woodshop

removed hammy and olivia

unpinned mason's woodshop

removed pins

added hammy and olivia
pinned sam seder
unpinned destiny and hammy and olivia
Fix merge on ChannelThumbnails

- sam seder, + hammy & olivia and passion for food
update tagline (#6086)

removed everyone, added kona and suba
Theme color fixes (odysee) (#6089)

* Cherry-pick master's 'base-theme.scss'

* Non-functional cleanup (remove dups, re-order, etc.)

* Dark: update positive Toast to --color-primary as well.

This follows the intention of the refactoring, which I guess was (1) reduce the number of color names (2) reduce the number of customizations needed.

The only issue I have with this is that the current Odysee primary color is pink, which can be intepreted as an error.

The original (pre-refactoring color was green).

For now, I follow the refactoring path. We can tweak this later.

* Fix text color inside '--color-card-background-highlighted'

Light: use base-theme (it was the same value anyway).
Dark: use bright text.

* Dark: add some contrast between the components

The color for the background, header, card, placeholder, etc. is almost identical -- it looks like there are all in the same component. The almost-invisible border doesn't help. One would have to crank up the monitor's contrast setting to see separation of components.

Brighten up the components a bit, somewhat following the same scale as lbry.tv's dark theme.

Overall, I still think it's too dark. The Card's background color can still be brightened up further for better contrast, but I try not to make too drastic of a change for now.

The original lbry.tv's gray theme is the most pleasant theme I've seen so far, but this is all subjective.
changed pins

removed kona and suba
added destiny
changed pins

removed destiny
pinned sgtducky
changed pins

removed sgtducky
added hammy and olivia
added chrissie mayr
added the bite shot
changed pins

removed the bite shot
added heads of tech
changed pins

removed hammy and olivia
removed chrissie mayr
changed pins

removed heads of tech
added crackermilk
changed pins

removed crackermilk
added some ordinary gamer
added passion for food
changed pins

removed some ordinary gamers
removed passion for food
added emmy hucker
changed pins

added game knights
Update view.jsx

Force rebuild
changed pins

removed emmy hucker
changed pins

removed game knights
added crackermilk
changed pins

removed crackermilk
added some ordinary gamer
changed pins

removed some ordinary gamers
added passion for food
added green renaissance
changed pins

removed passion for food
removed green renaissance
added expand love
changed pins

removed expand love
added dr nora
change tagline (#6122)

there's so much room for activities

comment out music

changed pins

removed dr nora
added kona and suba

changed pins

removed kona and suba
added destiny
changed pins

removed destiny
added crackermilk
changed pins

removed crackermilk
added someordinarygamers
change tagline

Drake, where's the door hole?

changed pins

unpinned someordinarygamers
pinned kona and suba
Add message for mature content

changed pin
changed pins

removed creative model

changed pins

added bcpov
added krish mohan
added cigarvixen

changed pins

removed krish mohan
added adrian logan

bump

fix footer

change tagline

just like the simulations

changed pins

removed:
bcpov
cigarvixen
adrian logan

added:
someordinarygamers

quick fix for reposts

oops

fix channel tabs

changed pin

removed someordinarygamers
added kona and suba
changed pins

removed kona and suba
added dirtyworkz
added crackermilk

fix channel tabs again again

changed pins

someordinarygamers
arvie's cookbook

changed pins

removed some ordinary gamers
removed arvie's cookbook
added fna van life

changed pins

removed fna vanlife
added game knights

change tagline

"this cave is not a natural formation"

changed pins

removed game knights
added some ordinary gamers

fix popup

put footer back

bump lightouse throttle

bump lighthouse throttle

changed pins

removed some orginary gamers
added adrian logan

pinned bret weinstein

fix referral

fix-superchats

changed pins

removed bret weinstein
added passion for food
added dark horse clips

fix incorrect variable being used to determine view state

changed pins

removed passion for food

changed pins

removed bret weinstein
added sgt ducky

add recsys related functionality

Create plugin to hold code for recsys

send recsys on dispose

cleanup recsys code

add userId to props validation

appease the linter

add todo note

extra characters

pinned jungle survival

fix autoplay for transcoded files

change tagline

changed pins

pinned destiny

pinned chris williamson

FIX video.js event firing issues fore RecsysPlugin

- The `rateChange` event now logs the updated speed,
   not just the    time at which it occurred.
- The `scrub` now (more) accurately logs the position
   it came from before the destination.
- The recsys events get consolidated for logical consistency.

Wunderbar: change throttle to debounce + add min chars

6314: prevent lighthouse spam from wunderbar

- Wunderbar: change throttle to debounce + add min chars.
- useLighthouse: added option to not throttle.

Wunderbar: immediate feedback to convey status

Make immediate GUI feedback to convey the current status, which can be the following:
- typing
- waiting lighthouse results
- waiting claim resolve
- no results or failed.

pinned someordinarygamers

Wunderbar: bump debounce to 1s

per feedback

pinned jungle survival

pinned james julier

Fix compile error

Lint

summit pin

summit pin

update pins

added humblemechanic
removed everyone else

update pins

pinned samtime

FIX stop event translation and remove preprocessing

I think different browsers behave in different ways for the media
API. As a result, I think I was losing information for browsers
that weren't the same as mine (Chromium). For now, preprocessing
is removed. In the future, I'll add it again (better storage
and transmission properties).

updated pin

change pins

(cherry picked from commit 041f420416)

pinned someordinarygamers

auth only for stripe

restore playlists tab

fix missing i18n on channel page

pinned zimmerhandcrafted

change tagline

big gulps, huh?

change pin

Revert lazy-loading videojs

The loading circle wasn't showing up, causing confusion.

Splitting CSS doesn't seem trivial as there seems to be a huge dependency on the load order. Pretty much similar to what this person is facing https://lihautan.com/css-code-splitting/#the-problem

This reverts videojs-specific changes from 4d638bcf.

odyrecon

use ENABLE_UI_NOTIFICATIONS

use ENABLE_MATURE

oops

use ENABLE_MATURE for fileTitleSection

pinned orf

pinned ourselves

selecthumb copy

use ENABLE_UI_NOT. on sideNav

showNoSourceClaims

changed pin

fix livestream claims display

...

fix?

fix

Fix invalid semicolon

alison morrow

Odysee: fix missing '--color-help-warning-bg' for Dark

someordinarygamers

pinned some new channels

watch guy

hotfix error returning to settings

emplemon

fix showMature

test bump parsing

better colon handling

cherrypick pins

unpin emplemon for now

delete unused components (#6531)

more recon (#6534)

emplemon

Latest changes to odysee (#6536)

* disable review button if no card saved also some cleanup

* fix flow errors

move stuff to web

Revert "move stuff to web"

This reverts commit 17b13d8b19.

hotfix for odysee

change tagline

don't dead open inside

rm style

site help email -odysee tx failed

recon for notification components

tagsIntro behind config

env part

webuploads-rcon

commentReactions recon ody

update meme

headnotify recon

modal publish recon

preview index recon

disable aniview

disable google imasdk

safe

pin us

Fix channel-selector thumbnail not updating

Recently changed to `<OptimizedImg>`, which was assuming the `src` never changes.

dejavu ... we also hit this issue when implementing the `IntersectionObserver` lazy-loading.

user verify sms copy

restore paid content

clear publish once

copy

pub file copy

chris williamson

try follow disc recon

Disable "missing-chunks auto reload"

To confirm if this is causing "6636 Slow Embed".  Most likely it is.

settings Recon

delete spaceman

revert disable chunking

Fix didn't work

bugfix not updating the frontend on account add

chris williamson

pinning-ody

Fix muted-words now returning null instead of ""

Creating Settings suddenly start to stop loading correctly for some of my channels.

`settings.List` now returns null instead of empty array. Double-checked the Commentron repo and this is indeed the case.

Updated the code to handle null.

recon publish form

add default

Reinstate music category metadata

meme setting

bugfix

bugfix

fix

meme fix

gr

exempt news from hp

recon query params

footer recon

pull out variable for max and min fiat amounts

odysee

fix replay select styling

make meme a link

Fix audio references

get newest livestream claim in livestreamLink

pin crackermilk

fix livestream banner placement

fix live page

fix rebase

fix rebase

fix error nag

fix darkmode blockquote style

break word on livestream comment text

fix dark mode snack

fix live badge

fix lint

small fixes - word wrap, live badge

wip

Fix invisible snack in Odysee Light Theme

Revert "wip"

This reverts commit d17e477fe0.

Revert "small fixes - word wrap, live badge"

This reverts commit 0e431d4038.

fix blank

pinned destiny

fix badges and homepage again

only get livestreams live for less than a day

pinned hammy and olivia

multi pin

pin destiny

updated pinned videos

update tagline

Update view.jsx

pins

updated destiny's video

updated pinned videos

removed destiny, added lie likes music

pinned destiny and mason's woodshop

removed hammy and olivia

unpinned mason's woodshop

removed pins

added hammy and olivia
pinned sam seder
unpinned destiny and hammy and olivia
Fix merge on ChannelThumbnails

- sam seder, + hammy & olivia and passion for food
update tagline (#6086)

removed everyone, added kona and suba
Theme color fixes (odysee) (#6089)

* Cherry-pick master's 'base-theme.scss'

* Non-functional cleanup (remove dups, re-order, etc.)

* Dark: update positive Toast to --color-primary as well.

This follows the intention of the refactoring, which I guess was (1) reduce the number of color names (2) reduce the number of customizations needed.

The only issue I have with this is that the current Odysee primary color is pink, which can be intepreted as an error.

The original (pre-refactoring color was green).

For now, I follow the refactoring path. We can tweak this later.

* Fix text color inside '--color-card-background-highlighted'

Light: use base-theme (it was the same value anyway).
Dark: use bright text.

* Dark: add some contrast between the components

The color for the background, header, card, placeholder, etc. is almost identical -- it looks like there are all in the same component. The almost-invisible border doesn't help. One would have to crank up the monitor's contrast setting to see separation of components.

Brighten up the components a bit, somewhat following the same scale as lbry.tv's dark theme.

Overall, I still think it's too dark. The Card's background color can still be brightened up further for better contrast, but I try not to make too drastic of a change for now.

The original lbry.tv's gray theme is the most pleasant theme I've seen so far, but this is all subjective.
changed pins

removed kona and suba
added destiny
changed pins

removed destiny
pinned sgtducky
changed pins

removed sgtducky
added hammy and olivia
added chrissie mayr
added the bite shot
changed pins

removed the bite shot
added heads of tech
changed pins

removed hammy and olivia
removed chrissie mayr
changed pins

removed heads of tech
added crackermilk
changed pins

removed crackermilk
added some ordinary gamer
added passion for food
changed pins

removed some ordinary gamers
removed passion for food
added emmy hucker
changed pins

added game knights
Update view.jsx

Force rebuild
changed pins

removed emmy hucker
changed pins

removed game knights
added crackermilk
changed pins

removed crackermilk
added some ordinary gamer
changed pins

removed some ordinary gamers
added passion for food
added green renaissance
changed pins

removed passion for food
removed green renaissance
added expand love
changed pins

removed expand love
added dr nora
change tagline (#6122)

there's so much room for activities

comment out music

changed pins

removed dr nora
added kona and suba

changed pins

removed kona and suba
added destiny
changed pins

removed destiny
added crackermilk
changed pins

removed crackermilk
added someordinarygamers
change tagline

Drake, where's the door hole?

changed pins

unpinned someordinarygamers
pinned kona and suba
Add message for mature content

changed pin
changed pins

removed creative model

changed pins

added bcpov
added krish mohan
added cigarvixen

changed pins

removed krish mohan
added adrian logan

bump

fix footer

change tagline

just like the simulations

changed pins

removed:
bcpov
cigarvixen
adrian logan

added:
someordinarygamers

quick fix for reposts

oops

fix channel tabs

changed pin

removed someordinarygamers
added kona and suba
changed pins

removed kona and suba
added dirtyworkz
added crackermilk

fix channel tabs again again

changed pins

someordinarygamers
arvie's cookbook

changed pins

removed some ordinary gamers
removed arvie's cookbook
added fna van life

changed pins

removed fna vanlife
added game knights

change tagline

"this cave is not a natural formation"

changed pins

removed game knights
added some ordinary gamers

fix popup

put footer back

bump lightouse throttle

bump lighthouse throttle

changed pins

removed some orginary gamers
added adrian logan

pinned bret weinstein

fix referral

fix-superchats

changed pins

removed bret weinstein
added passion for food
added dark horse clips

fix incorrect variable being used to determine view state

changed pins

removed passion for food

changed pins

removed bret weinstein
added sgt ducky

add recsys related functionality

Create plugin to hold code for recsys

send recsys on dispose

cleanup recsys code

add userId to props validation

appease the linter

add todo note

extra characters

pinned jungle survival

fix autoplay for transcoded files

change tagline

changed pins

pinned destiny

pinned chris williamson

FIX video.js event firing issues fore RecsysPlugin

- The `rateChange` event now logs the updated speed,
   not just the    time at which it occurred.
- The `scrub` now (more) accurately logs the position
   it came from before the destination.
- The recsys events get consolidated for logical consistency.

Wunderbar: change throttle to debounce + add min chars

6314: prevent lighthouse spam from wunderbar

- Wunderbar: change throttle to debounce + add min chars.
- useLighthouse: added option to not throttle.

Wunderbar: immediate feedback to convey status

Make immediate GUI feedback to convey the current status, which can be the following:
- typing
- waiting lighthouse results
- waiting claim resolve
- no results or failed.

pinned someordinarygamers

Wunderbar: bump debounce to 1s

per feedback

pinned jungle survival

pinned james julier

Fix compile error

Lint

summit pin

summit pin

update pins

added humblemechanic
removed everyone else

update pins

pinned samtime

FIX stop event translation and remove preprocessing

I think different browsers behave in different ways for the media
API. As a result, I think I was losing information for browsers
that weren't the same as mine (Chromium). For now, preprocessing
is removed. In the future, I'll add it again (better storage
and transmission properties).

updated pin

change pins

(cherry picked from commit 041f420416)

pinned someordinarygamers

auth only for stripe

restore playlists tab

fix missing i18n on channel page

pinned zimmerhandcrafted

change tagline

big gulps, huh?

change pin

Revert lazy-loading videojs

The loading circle wasn't showing up, causing confusion.

Splitting CSS doesn't seem trivial as there seems to be a huge dependency on the load order. Pretty much similar to what this person is facing https://lihautan.com/css-code-splitting/#the-problem

This reverts videojs-specific changes from 4d638bcf.

odyrecon

use ENABLE_UI_NOTIFICATIONS

use ENABLE_MATURE

oops

use ENABLE_MATURE for fileTitleSection

pinned orf

pinned ourselves

selecthumb copy

use ENABLE_UI_NOT. on sideNav

showNoSourceClaims

changed pin

fix livestream claims display

...

fix?

fix

Fix invalid semicolon

alison morrow

Odysee: fix missing '--color-help-warning-bg' for Dark

someordinarygamers

pinned some new channels

watch guy

hotfix error returning to settings

emplemon

fix showMature

test bump parsing

better colon handling

cherrypick pins

unpin emplemon for now

delete unused components (#6531)

more recon (#6534)

emplemon

Latest changes to odysee (#6536)

* disable review button if no card saved also some cleanup

* fix flow errors

move stuff to web

Revert "move stuff to web"

This reverts commit 17b13d8b19.

hotfix for odysee

change tagline

don't dead open inside

rm style

site help email -odysee tx failed

recon for notification components

tagsIntro behind config

env part

webuploads-rcon

commentReactions recon ody

update meme

headnotify recon

modal publish recon

preview index recon

disable aniview

disable google imasdk

safe

pin us

Fix channel-selector thumbnail not updating

Recently changed to `<OptimizedImg>`, which was assuming the `src` never changes.

dejavu ... we also hit this issue when implementing the `IntersectionObserver` lazy-loading.

user verify sms copy

restore paid content

clear publish once

copy

pub file copy

chris williamson

try follow disc recon

Disable "missing-chunks auto reload"

To confirm if this is causing "6636 Slow Embed".  Most likely it is.

settings Recon

delete spaceman

revert disable chunking

Fix didn't work

bugfix not updating the frontend on account add

chris williamson

favicon custom

html fav tag remove

basic meta favi

missing favicon

recon
2021-07-27 15:19:33 -04:00
zeppi
2a69c42e5b back to img tag 2021-07-27 15:13:29 -04:00
zeppi
b1e8d2d6db desktop logo 2021-07-27 15:13:29 -04:00
zeppi
ef77a5cd00 optimizedImage 2021-07-27 15:13:29 -04:00
zeppi
71d9b0d973 default logo 2021-07-27 15:13:29 -04:00
zeppi
3f4c601428 logo component on embeds/embeds ended 2021-07-27 15:13:29 -04:00
zeppi
19f8b0adac logoComponent 2021-07-27 15:13:29 -04:00
zeppi
e4d7e4f69d force has source channel page 2021-07-26 14:17:52 -04:00
zeppi
403ea8f6f4 no livestreams on channel content 2021-07-26 14:17:52 -04:00
infinite-persistence
6de16813cb
i18n update 2021-07-26 23:31:03 +08:00
infinite-persistence
077207e203
ChannelPage: Don't mount inactive ChannelContent
## Issue
In the Channel Page, if the _Collections_ `claim_search` comes in after the main content's `claim_search`, the Collection's `ChannelContent` is being re-rendered despite not being in the active Tab. This causes a 0.4 CLS score (it's ridiculous that invisible components are taken into account). Apparently 41% of users are hitting this scenario, causing a poor aggregate.

## Change
Don't mount the `ChannelContent` components unless its tab is the active one. It doesn't seem like Reach Tab hides components under the inactive tab.
2021-07-26 22:01:31 +08:00
infinite-persistence
f6e648222e
Change constants to object for IDE auto complete
No functional change; just thought this is cleaner (group up the constants) and easier to type via IDE auto-complete, at the expense of creating an extra object.
2021-07-26 22:01:30 +08:00
infinite-persistence
8dc18e8fcd
Fix split (concat) string usage
Concatenated strings are hard to translate.
2021-07-26 12:37:59 +08:00
zeppi
8fef6c6160 ugly discover recon 2021-07-24 11:29:30 -04:00
zeppi
e3006a0edb exempt news from hp 2021-07-23 16:03:01 -04:00
infinite-persistence
76a6c0441c Beautify/elaborate comment spam-check message 2021-07-23 13:33:10 -04:00
zeppi
ad3fd5700f default search types from config 2021-07-23 10:31:07 -04:00
zeppi
0987c6e94f publish form recon 2021-07-23 10:14:22 -04:00
infinite-persistence
ffad52d5b7 Remove console.log
Seems like lint is being bypassed recently?
2021-07-23 08:42:58 -04:00
infinite-persistence
6e402240b0
Fix muted-words now returning null instead of ""
## Issue
Creating Settings suddenly start to stop loading correctly for some of my channels.

## Change
`settings.List` now returns null instead of empty array. Double-checked the Commentron repo and this is indeed the case.

Updated the code to handle null.
2021-07-23 15:46:38 +08:00
infinite-persistence
7a8d213861
Eliminate CLS in Recommended due to wrapper mismatch
Seem like `type === small` was missed out, so it was using a wrapper than necessary, causing the shift.
2021-07-23 13:23:52 +08:00
infinite-persistence
c62c667436
CLS: reserve space for injected video ads 2021-07-23 13:23:51 +08:00
zeppi
038431f95c channel follow first run on master 2021-07-23 00:00:32 -04:00
zeppi
ed0387d94a pinning 2021-07-22 23:24:55 -04:00
zeppi
f2cd9f372e Chan fol disc recon 2021-07-22 23:08:33 -04:00
zeppi
d88752c646 music icon, fix lint 2021-07-22 17:31:46 -04:00
Anthony
15e696c4d6 bugfix not updating the frontend on account add 2021-07-22 17:23:51 -04:00
zeppi
085ea15247 settings page recon 2021-07-22 14:43:01 -04:00
zeppi
e920738cd1 file page recon 2021-07-22 14:28:12 -04:00
Anthony
78b4fa05b3 pull out variable for max and min fiat amounts 2021-07-22 14:06:59 -04:00
Anthony
7975ccf3e0 disable button if theres a fiat tip error 2021-07-22 14:06:59 -04:00
Anthony
713dc69ed7 add check for two decimals and fix showing error for fiat tip 2021-07-22 14:06:59 -04:00
infinite-persistence
ecb14be871
Fix broken embeds in incognito
## Issue
Closes 6490
Embeds in https://lbry.com/news/2002dtf was crashing in incognito

## Change
Ensure localStorage is available before using it. Jessop warned me before...
2021-07-23 00:50:02 +08:00
zeppi
f4559c1cce fileSubtitle recon 2021-07-22 12:09:54 -04:00
zeppi
8919182c0c default avatar config 2021-07-22 09:44:57 -04:00
infinite-persistence
032e17cecd
Improve CLS on Posts
## Issue
6068 Fix "Cumulative Layout Shift" for Core Web Vitals

In Posts, the Comments section appears first while we fetch the MD file. When the MD is fetched, Comments get pushed to the bottom (or shifted up for short posts), hence the red CLS scores.

## Approach
There are too many layers between `<FilePage>` and `<DocumentViewer>` to pass the `loading` state around to hide the Comments section, so just make Comments fade in after a 2s delay.

## Changes
- Posts: Add 2s fade-in delay to Comments.
- Posts: remove the gray placeholder. This improves the score a bit more, and reduces flicker as well. There's already a spinner from `FileRenderInline` to tell the user to be patient.
- Posts: add a minimum 30vh height so that short posts don't get collapsed too much, causing the `FileDetails` and Comments to shift. Small shifts are fine as long as CLS is below 0.1.
2021-07-22 10:38:01 +08:00
infinite-persistence
50c606d916 claimListDiscover: don't re-render until query is done
## Issue
6542 Livestream listing and blocked list kills CLS score

This is basically a repeat of what was done on `claimTileDiscover` (homepage), but now on `claimListDiscover` (category pages).

This handles the unnecessary re-render when:
- the uri list temporarily being zero while waiting for new claim-search results.
- livestream claim-search invalidating the list.

## Changes
Store the last uri list and use that when we know that claim-search is still not done.

## Tests
1. Ran Lighthouse on category pages (force a livestream channel on it). CLS score must be green.
2. Block `claim_search` from Dev Tools and move to another category. The page should say "timed out" instead of "no results" (i.e. maintain existing behavior).
2021-07-21 21:51:12 -04:00
zeppi
1994b5da04 guidelines optional in sidenav 2021-07-21 20:26:17 -04:00
zeppi
fbf105e113 fileActions recon 2021-07-21 18:37:43 -04:00
zeppi
573ed1e88c recon followDisc 2021-07-21 16:58:13 -04:00
zeppi
91b908ad50 pubfile copy 2021-07-21 16:18:46 -04:00
zeppi
6ec95647e7 lbc remove file 2021-07-21 15:56:09 -04:00
infinite-persistence
4fc6b89975 Fix reposted channels incorrectly showing the channel thumb
## Issue
6589

## Notes
`parseURI` will return `isChannel=false` due to the reposted channel URL not having the '@' symbol.

Since we already have the claim object, check `value_type` directly instead.
2021-07-21 14:41:47 -04:00