LBRYCommunity/lbry-desktop
1
0
Fork 0
Code Issues 596 Pull requests 6 Projects Releases 238 Packages Wiki Activity
8795 commits 144 branches 725 tags 262 MiB
Commit graph

3074 commits

Author SHA1 Message Date
Sean Yesmunt
3b6882412a enable 'discover' page for everyone 2020-11-16 14:11:52 -05:00
infiinte-persistence
18debf51cd FloatingPlayer: fix unusable volume slider in fp-mode 
4913: Can't slide volume slider in pop out mode

I first tried to handle this at the floating player level, but it was impossible to hack there due to how 'react-draggable' works (it already moved the window before the "move" handler is called, so we can't do much).

Fix by overriding the dragging behavior of the videojs' VolumeBar class by not propagating the event further. It is odd that videojs didn't already do this, since it's SeekBar does stop the propagation.
 2020-11-16 10:38:29 -05:00
zeppi
ef06c75e8f send none with en language 2020-11-16 10:34:16 -05:00
jessop
f334c07c29 pass language to authenticate 
update api language when setLanguage

yarn
 2020-11-16 10:31:06 -05:00
Sean Yesmunt
00fb833c38 fix claim_search filter dropdown style 2020-11-16 10:19:50 -05:00
Thomas Zarebczan
07916059ed
Don't hard fail on sync set error 
Need to fix double sync loop first.
 2020-11-14 01:17:26 -05:00
Sean Yesmunt
a4c9115063 cleanup from last PR 2020-11-13 15:54:00 -05:00
Sean Yesmunt
026b416ca1 clean up claim_search filters 2020-11-13 15:51:29 -05:00
Sean Yesmunt
49a7dfd76d don't delete saved-password on preference_get fail 2020-11-13 14:48:04 -05:00
Sean Yesmunt
abacafb0c5 better handle bad wallet password errors 2020-11-13 14:48:04 -05:00
Sean Yesmunt
f1adfddded bump lbry-redux and handle other fatal sync errors 2020-11-13 14:48:04 -05:00
Sean Yesmunt
cfb10db4ea add fatal error handling when sync/get fails with unknown error 2020-11-13 14:48:04 -05:00
infiinte-persistence
dfef97d715 claim_search: Don't clear past page results if subsequent pages timeout. 
## Issue
4609: If claim search on latter page fails, don't clear out all previous data

## Note
This requires an accompanying change in `lbry-redux` to mark `claimSearchResultLastPageReached` during timeout and to not purge past results.

## Change
The previous flow was: increment the page, and expect the next render to either be 0 (timeout + purge) or fill in at least 1 new item.

Since it is now possible for no results to be returned for the new page (due to timeout + no purging), the code continues to make another query. This commit stops the perpetual querying.

## Test Case:
1. https://lbry.tv/$/discover?t=imherelbry&content=video&order=top&fresh=year
2. Scroll down a few pages until it timeout happens. Past results are gone.
 2020-11-13 13:23:50 -05:00
Sean Yesmunt
96e28aadf5 don't trigger sync when changing tile layout 2020-11-13 13:17:25 -05:00
Sean Yesmunt
5cfa46d14d fix card spacing on settings page 2020-11-13 13:17:25 -05:00
Sean Yesmunt
509cbb07fe fix notification icons 2020-11-13 13:17:25 -05:00
zeppi
92817203fc send nudge source to matomo 2020-11-13 11:07:31 -05:00
Sean Yesmunt
64ea6e6adc fix lbc icon on notifications page 2020-11-13 00:36:23 -05:00
infiinte-persistence
fc79c87bba Fix sidebar tooltip showing string with context metadata. 
## Issue
In the odysee branch, the tooltip for "Following" in the Sidebar was shown as "Following --[sidebar]--". In lbry.tv, the tooltip doesn't appear.

I believe the tooltip appeared due to the name change from 'label' to 'title' and then being passed to Button through '...passedProps'.

Fix by explicitly setting the Button's 'title' to the localized text.
 2020-11-12 15:21:40 -05:00
Sean Yesmunt
fce6c17f4f remove channel preview in comments 2020-11-12 13:46:40 -05:00
Sean Yesmunt
881ce59ade add basic message for thumbnail uploads 2020-11-11 22:49:41 -05:00
zeppi
fff599d56a delete util/homepage 2020-11-11 10:47:47 -05:00
jessopb
697651b0e8
pass domain to authenticate for appid (#5012) 2020-11-10 21:47:51 -05:00
zeppi
463f72ee56 channel avatar fix 2020-11-10 16:41:21 -05:00
Sean Yesmunt
94f8db4da9 update order on settings page 2020-11-10 15:32:45 -05:00
Sean Yesmunt
73e1db7bb4 allow changing language for unauth users 2020-11-10 15:32:45 -05:00
zeppi
3da7ec5c2c fix links spread bug 2020-11-10 14:02:59 -05:00
zeppi
fe8adaaa49 hp description 2020-11-10 14:02:59 -05:00
zeppi
ad7a0c9cac reconcile more 2020-11-10 14:02:59 -05:00
Sean Yesmunt
47f45fce0c fix typos 2020-11-10 12:22:25 -05:00
Sean Yesmunt
60bac01a4a remove extra prop 2020-11-10 12:08:19 -05:00
Sean Yesmunt
4b59bd0223 add back help links for SIMPLE_SITE 2020-11-10 12:08:19 -05:00
Sean Yesmunt
1023f30b4c initial PR for custom homepages - take 2 2020-11-10 12:08:19 -05:00
Sean Yesmunt
353c1a5689 Revert "unified custom homepage" 
This reverts commit 55768fc6b5.
 2020-11-10 10:36:11 -05:00
Sean Yesmunt
1814733d5b Revert "add back sign up nudge" 
This reverts commit f0cabbff7d.
 2020-11-10 10:36:11 -05:00
Sean Yesmunt
f0cabbff7d add back sign up nudge 2020-11-10 10:24:04 -05:00
jessop
55768fc6b5 unified custom homepage 2020-11-10 10:24:04 -05:00
Sean Yesmunt
e2b30b7d17 add basic dmca message on embeds page 2020-11-10 01:26:38 -05:00
Sean Yesmunt
ca6ce23494 fix nudge mobile styling 2020-11-10 01:10:22 -05:00
Sean Yesmunt
f63de7f930 add nudges to sign up 2020-11-10 00:33:27 -05:00
Sean Yesmunt
631d67ad0b fix typo 2020-11-09 16:07:14 -05:00
jessop
391ab15b15 dont set sync enabled on web on sign up 2020-11-09 15:06:14 -05:00
Sean Yesmunt
1ef587b8c2 fix typos and bump lbryinc 2020-11-09 13:37:51 -05:00
Sean Yesmunt
1cc7be746b move splash animation out of settings 2020-11-09 13:37:51 -05:00
Sean Yesmunt
6626cc1059 fix floating player location on desktop 2020-11-09 13:37:51 -05:00
Sean Yesmunt
467d9b9f47 fix channel ellispis on claimPreview 2020-11-09 13:37:51 -05:00
infiinte-persistence
a71c66bfb7 Localize the "analytics down" message. 2020-11-09 10:44:45 -05:00
Sean Yesmunt
3a96382901
add basic message for creator analytics issues (#5001) 
* add basic message for creator analytics issues

Co-authored-by: Thomas Zarebczan <tzarebczan@users.noreply.github.com>
 2020-11-08 10:57:02 -05:00
Sean Yesmunt
e00b98226c remove old import 2020-11-06 00:02:53 -05:00
Sean Yesmunt
c21fef5b24 new ads provider 2020-11-05 12:21:32 -05:00
Sean Yesmunt
98855d4fd5 fix top claim search result 2020-11-04 16:08:23 -05:00
Sean Yesmunt
d408b0fd96 fix page crash on mailto links 2020-11-04 16:08:23 -05:00
Sean Yesmunt
dc3fac6a4c don't hide lbc details if no description 2020-11-04 16:08:23 -05:00
Sean Yesmunt
fd5cde08c3 add back video player on adstest pagegaa 2020-11-04 12:00:31 -05:00
Sean Yesmunt
485a734c9b make notifications deleteable + unsub from the bell on notifications page 2020-11-04 10:25:49 -05:00
Sean Yesmunt
a836467714 content notification style cleanup 2020-11-04 10:25:49 -05:00
Sean Yesmunt
8f7c16cc39 fix 'best' comment sort 2020-11-02 17:15:53 -05:00
Sean Yesmunt
cb50b8a9bc Revert "Improve IOS inline experience" 
This reverts commit 9b38ba6c02.
 2020-11-02 17:15:02 -05:00
Sean Yesmunt
68b1a0971c Revert "remove unused style" 
This reverts commit 57a69be7e8.
 2020-11-02 17:15:02 -05:00
Sean Yesmunt
3f76092a3b per channel notification settings take 2 2020-11-02 15:50:53 -05:00
Sean Yesmunt
3f7d7674ff Revert "only show bell for users with notifications on" 
This reverts commit c94d22994f.
 2020-11-02 15:31:09 -05:00
Sean Yesmunt
c94d22994f only show bell for users with notifications on 2020-11-02 14:19:01 -05:00
Sean Yesmunt
25085fe881 update bell icon 2020-11-02 14:13:13 -05:00
Sean Yesmunt
63f1fed33c per channel notification settings 2020-11-02 14:13:13 -05:00
Sean Yesmunt
e6016538b4 add ads script to head for test 2020-11-02 12:01:58 -05:00
infiinte-persistence
591f604073 Remove translation macro on native language names. 
I believe we don't translate these since this is already the translated form?

When the language is supported later, the English version will be added to the string database instead.
 2020-10-30 00:21:51 -04:00
Sean Yesmunt
52eb4de7a9 add adstest page to test player ads 2020-10-30 00:20:42 -04:00
Sean Yesmunt
dfe1bf5c62 remove unused style 2020-10-30 00:04:59 -04:00
Sean Yesmunt
46fbcb5a0f fix autoplay countdown 2020-10-30 00:04:59 -04:00
Sean Yesmunt
419dd6431e fix exact claim not showing up when copying url 2020-10-30 00:04:59 -04:00
Sean Yesmunt
b33f14cca4 make file details smaller 2020-10-30 00:04:59 -04:00
Sean Yesmunt
57a69be7e8 remove unused style 2020-10-29 17:02:40 -04:00
Thomas Zarebczan
9b38ba6c02 Improve IOS inline experience 
Also puts back the video js player which has rate support - but it's hidden on smaller devices...maybe someone can fix later on.
 2020-10-29 17:02:40 -04:00
jessop
734e08a209 bump and bugfix 2020-10-29 15:20:18 -04:00
jessop
c4d05a5a1a claim-search by language 
setting to search only in language as default

add channel update language selection and about

bump

searchable languages
 2020-10-29 15:20:18 -04:00
jessopb
54466edafc
Merge pull request #4963 from lbryio/feat-userIconIdentity 
make header user icon reflect comment identity
 2020-10-29 08:27:34 -04:00
jessop
91f748d566 enable owners to tag claims and channels disable-support 2020-10-29 01:11:39 -04:00
jessop
ed61ac44bf make header user icon reflect comment identity 2020-10-28 17:49:28 -04:00
Sean Yesmunt
f2c6986a6f show channels + streams as winning claim from search query 2020-10-28 16:28:36 -04:00
Sean Yesmunt
4d9731d9c2 fix url wrapping on markdown links 2020-10-28 14:45:04 -04:00
Sean Yesmunt
e198caffd7 make sure comments with 0 likes are sorted to bottom 2020-10-28 14:45:04 -04:00
Sean Yesmunt
9c20a63ad5 add spinner when waiting for 'user' so page doesn't look broken 2020-10-28 14:45:04 -04:00
Sean Yesmunt
aed74c4608 fix creator reactions on file pages 2020-10-28 14:45:04 -04:00
Sean Yesmunt
cf40313383 update creator like style 2020-10-27 22:18:22 -04:00
Sean Yesmunt
e901daa849 wait to render comments until reactions are fetched 2020-10-27 22:18:22 -04:00
Thomas Zarebczan
43c2e9e0ed
Fix: channel page search limit 2020-10-27 14:51:05 -04:00
infiinte-persistence
93b1de8ed9 Fix long tag query-URL when changing between [Trending|New|Top] 
## Issue
4393: Tag query URL goes on indefinitely as you change between [Trending|New|Top]

## Change
Change from `append` to `set` when building the query to remove duplicates.

Flow hates null being not a string, so the FixMe was retained.
 2020-10-27 12:38:41 -04:00
Sean Yesmunt
ad20e355cf creator only like reactions 2020-10-27 12:27:30 -04:00
Sean Yesmunt
d8aecaeb29 only call sync_apply if no wallet found 2020-10-27 10:17:11 -04:00
jessop
9d4f7dc642 sync reducer stuff 
bring tags into app repo

prevent prefset until prefsReady

prefs ready on sign up

prefsReady-desktop
 2020-10-27 10:17:11 -04:00
Sean Yesmunt
f54a0de797 bring in sync code from lbryinc 2020-10-27 10:17:11 -04:00
Thomas Zarebczan
19664726d6
Fix media type app crash on Publish 2020-10-26 14:56:38 -04:00
Sean Yesmunt
ca7a0794a8 lower threshold for comments slimed to death 2020-10-26 14:06:33 -04:00
Sean Yesmunt
2716d9441c add unlock button nex to expandable credits button 2020-10-26 11:36:10 -04:00
Sean Yesmunt
ffdac06b80 fix typo 2020-10-23 15:26:39 -04:00
Sean Yesmunt
82b460f53d add back support button on top page 2020-10-23 15:08:27 -04:00
Sean Yesmunt
6516d9ffa6 only includeSupportAction for not SIMPLE_SITE 2020-10-23 15:08:27 -04:00
Sean Yesmunt
f54f4fc65d clean up markdown post style 2020-10-23 15:08:27 -04:00
Sean Yesmunt
54fa36abc0 bring in lbc/file details for everyone 2020-10-23 15:08:27 -04:00
Sean Yesmunt
1711dc6601 enable top claim on search page for everyone 2020-10-23 15:08:27 -04:00
Sean Yesmunt
5a1eecfc4b fix iframe lbry links in markdown posts 2020-10-23 13:15:13 -04:00
Sean Yesmunt
33bf50e91b fix simpleLinks in MarkdownLink 2020-10-23 10:30:11 -04:00
Sean Yesmunt
6c6dacb195 fix strings 2020-10-23 01:53:09 -04:00
Sean Yesmunt
221ae5b821 fix inline player not showing up broken from previous commit 2020-10-22 18:09:17 -04:00
Sean Yesmunt
c9fdaec997 don't show external link modal for lbry links 2020-10-22 14:30:40 -04:00
Sean Yesmunt
6659ef50ff don't show ClaimLinks in file description 2020-10-22 14:16:42 -04:00
Sean Yesmunt
ad88d8993d fix app crash 2020-10-22 14:08:53 -04:00
Sean Yesmunt
851b2d13e4 remove homepage hack from ClaimListDiscover and fix order so release_time filter is set properly 2020-10-22 13:01:17 -04:00
Sean Yesmunt
cd3f30e03e don't pass fee_amount: >=0 when nothing is set to avoid timeouts 2020-10-22 13:01:17 -04:00
Sean Yesmunt
bf27692a65 use lbc icon for reward notifications 2020-10-22 12:41:29 -04:00
Sean Yesmunt
1cb0685b61 pass is_app_readable to notification/list 2020-10-22 12:41:29 -04:00
Sean Yesmunt
788fd153da fix thumbnail gifs in comments 2020-10-21 16:45:43 -04:00
jessop
51c94d334a set userid regardless of signin 2020-10-21 15:30:26 -04:00
jessop
fab03d337e ad fix 2 2020-10-21 15:30:01 -04:00
Sean Yesmunt
295b8cf2e1 refactor floatingUri to allow inline players in comments/markdown 2020-10-21 15:29:29 -04:00
Sean Yesmunt
3b20104261 bump allowed upload size to 2gb on web 2020-10-20 13:13:08 -04:00
jessop
14e1b6c1f7 pin only top level 2020-10-20 13:09:08 -04:00
jessop
91d034954e mark notification seen on relevant interaction 2020-10-20 13:09:08 -04:00
Sean Yesmunt
41dfd8a0f8 return early for undefined i18n messages 
could happen when we map over a list of objects to create buttons and one only has an icon
 2020-10-19 23:54:32 -04:00
Sean Yesmunt
a0320f8cef remove comment 2020-10-19 23:37:39 -04:00
Sean Yesmunt
a045ddf23e bump lbry-redux + pin icon tweaks 2020-10-19 23:37:39 -04:00
Sean Yesmunt
106f5a0ac2 initial comment pin PR with new commit 2020-10-19 23:37:39 -04:00
jessop
2f84d94c66 related add full width 2020-10-19 22:59:24 -04:00
Sean Yesmunt
264a85d837 Revert "comment pin action" 
This reverts commit 636ab7427d.
 2020-10-19 15:01:09 -04:00
jessop
636ab7427d comment pin action 
owners can pin and unpin comments

tweak pin icon styles

move commenting activeChannel from localStorage to redux
 2020-10-19 14:48:01 -04:00
jessop
9fb13975b4 email resend requests limited to once per thirty seconds 2020-10-16 16:38:52 -04:00
Sean Yesmunt
3bb5c06f44 openItem => openPath 2020-10-16 10:49:01 -04:00
jessop
6284f86026 fix reward rates crash 2020-10-16 00:07:30 -04:00
Thomas Zarebczan
f5900795c4
Show own channels on blocked list 2020-10-15 19:10:58 -04:00
Sean Yesmunt
cfd4e8a05d rc fixes for electron 9 2020-10-15 19:06:47 -04:00
Thomas Zarebczan
ba786fa50e
Show unblock button on own blocked channels 2020-10-15 17:49:05 -04:00
Sean Yesmunt
c5a2126abe disable snapshot thumbnail on desktop to prevent desktop crashes 
https://github.com/electron/electron/issues/20750\#issuecomment-709505902
 2020-10-15 14:32:58 -04:00
infiinte-persistence
e947307f86 Fix typo "Logging in in as ..." 2020-10-15 00:09:01 -04:00
infiinte-persistence
511a746871 Str-context-split: "To" and "From" 
## Note from Russian translator
"To/From" in the 'automatic dark mode setting' cannot be re-used for the one in the 'Tip Modal'.

## Change
Wanted to split this into "general" and "time", but I'm guessing it won't satisfy all languages, so we'll just use the usage as the context since there's just 2 instances.
 2020-10-14 17:44:44 -04:00
infiinte-persistence
80b4600f60 Str-context-split: "Follow" 
## Issue
4192
 2020-10-14 17:44:44 -04:00
infiinte-persistence
d7a178d259 Str-context-split: "Post" 
Splitting the context between "Markdown post" (noun) vs. "Post something" (verb)
 2020-10-14 17:44:44 -04:00
infiinte-persistence
6dd40df93b Str-context-split: "Support" 
Chinese, Spanish and other translators reported the difficulty in using "Support" as both a noun and verb in their language.
 2020-10-14 17:44:44 -04:00
infiinte-persistence
567316cfbe Support for multiple string context + "About" as initial example. 
## Issue
4796 - i18n: Allow support for string overloading (multiple contexts)

## Approach
- Minimal code and process change.
- Handle on a case-by-case basis when reported by translators.
- Split the affected key in the string json by appending the context.
- Translators need to be aware of the new format and not translate context itself. Code is added to detect bad translations and will revert to English.

Sample in json:
  "About --[About section in Help Page]--": "About",
  "About --[tab title in Channel Page]--":  "About",

Sample in client code:
  title={__('About --[About section in Help Page]--')}

- "--[ ]--" was chosen as it's unique enough (unlikely for real strings to use it) and hopefully not that distracting in the client code.
- In the key itself, spaces are allowed after the string (i.e. before '--[') for neatness. It will be trimmed by the system.

## First example
"About" is used in 3 places:
   - Channel Page
   - Help Page
   - Footer (in Odysee branch)

For Russian, the word "About" is "O" and is usually not used standalone, but requires something behind it. A translator said so, and seems to be the case in other sites as well.
   "O xxx"
   "O yyy"

## Other languages
For other languages that are not impacted, they can just clone the same translation for each of the split keys, just like in English.

## Possible enhancement in Transifex
I see that Transifex's API includes a `context` entry. It might be possible to move the context-metadata there during the upload, so translators will never see the "--[]--" messiness (it will be shown as "Context: xxx" in the Transifex GUI).

I'm not sure how to test the Transifex side, so I did not investigate further.
 2020-10-14 17:44:44 -04:00
Sean Yesmunt
44bcc943a0 add new sort icons for new/best/controversial 2020-10-14 16:51:48 -04:00
Sean Yesmunt
77aa580690 add spacing for ul/ol next to p elements 2020-10-14 11:33:39 -04:00
Sean Yesmunt
172e918de5 pass to 2020-10-13 15:31:07 -04:00
Sean Yesmunt
4b98cf45f3 prevent clicking through help links 2020-10-12 23:21:23 -04:00
Sean Yesmunt
88c86ff447 add help link 2020-10-12 23:21:23 -04:00
Sean Yesmunt
4815aa9ff1 add reward rate + analytics link on channels page 2020-10-12 23:21:23 -04:00
Sean Yesmunt
65c39cbbc8 fix mobile comments on ios devices 2020-10-12 15:21:03 -04:00
Sean Yesmunt
03f1fe3ee5 make youtube sync web only 2020-10-09 17:08:38 -04:00
Sean Yesmunt
8bb6643a41 switch back to 'slimed to death' 2020-10-09 11:38:50 -04:00
Sean Yesmunt
60569de672 hide comments that were slimed to death TM 2020-10-08 15:57:20 -04:00
Sean Yesmunt
b1bca7982a re-enable lbry:// link styles in comments 
will add support for odysee/lbry.tv once the style is finalized
 2020-10-08 14:19:21 -04:00
Sean Yesmunt
480d8a8786 wait to scroll to linked comments until readyToDisplay=true 2020-10-08 14:19:21 -04:00