Commit graph

41 commits

Author SHA1 Message Date
infiinte-persistence 567316cfbe Support for multiple string context + "About" as initial example.
## Issue
4796 - i18n: Allow support for string overloading (multiple contexts)

## Approach
- Minimal code and process change.
- Handle on a case-by-case basis when reported by translators.
- Split the affected key in the string json by appending the context.
- Translators need to be aware of the new format and not translate context itself. Code is added to detect bad translations and will revert to English.

Sample in json:
  "About --[About section in Help Page]--": "About",
  "About --[tab title in Channel Page]--":  "About",

Sample in client code:
  title={__('About --[About section in Help Page]--')}

- "--[ ]--" was chosen as it's unique enough (unlikely for real strings to use it) and hopefully not that distracting in the client code.
- In the key itself, spaces are allowed after the string (i.e. before '--[') for neatness. It will be trimmed by the system.

## First example
"About" is used in 3 places:
   - Channel Page
   - Help Page
   - Footer (in Odysee branch)

For Russian, the word "About" is "O" and is usually not used standalone, but requires something behind it. A translator said so, and seems to be the case in other sites as well.
   "O xxx"
   "O yyy"

## Other languages
For other languages that are not impacted, they can just clone the same translation for each of the split keys, just like in English.

## Possible enhancement in Transifex
I see that Transifex's API includes a `context` entry. It might be possible to move the context-metadata there during the upload, so translators will never see the "--[]--" messiness (it will be shown as "Context: xxx" in the Transifex GUI).

I'm not sure how to test the Transifex side, so I did not investigate further.
2020-10-14 17:44:44 -04:00
Sean Yesmunt c1b5280446 move youtube badge to 'channel about' section 2020-10-06 16:30:03 -04:00
Sean Yesmunt 295fec0370 copy changes 2020-09-29 17:12:32 -04:00
Sean Yesmunt bc89d774ba add youtube sync to first run 2020-09-29 17:12:32 -04:00
Sean Yesmunt 5014b1a027 fix notification linking to channel page 2020-09-29 17:12:32 -04:00
Sean Yesmunt ca89dab45f move claim uri under file/channel details 2020-07-29 13:04:58 -04:00
jessop d9bf72a351 all settings constants come from redux
sync settings

backout nav cases and anon preference key

more robust backout header

put notificationSettings under backout bar

review changes
2020-07-27 11:53:14 -04:00
infiinte-persistence 2f5beb84fa Fix sluggish Back button when navigation back to channels with lots of comments
## Issue
When navigating back and forth between a File and Channel page, the back-action will be laggy (no response) if the channel contains a lot of comments and is in the midst of resolving them.

## Changes
The "full" fix would be to batch-load comments, as this would improve the performance of fetching both Channel and File comments. For now, this commit focuses on the Back action problem only.

Skip fetching comments by not mounting 'ChannelDiscussion' until the tab is selected. I couldn't find anything in the Reach UI documentation on how to not render inactive `TabPanel`s, so I used the straight-forward state method.
2020-07-24 09:22:35 -04:00
infiinte-persistence cba2ccf1cb Show "YT Creator" label in File Page as well.
## Issue
Closes 3964 `Add Youtuber info to file page`

## Changes
(1) Refactor the YT-info query into `YoutubeBadge` component.
(2) For the File Page case, don't show "- last sync <date>" since the date has nothing to do with the file.

## Test
[x] YT Channel page
[x] YT Channel's claim page
[x] Non YT Channel page
[x] Non YT Channel's claim page
[x] No channel (anonymous) claim page
[x] Various RENDER_MODES
2020-07-15 15:27:03 -04:00
Sean Yesmunt 259f51abd6 style pass for channel edit
clean up sections and improve navigation handling

cleanup + image upload modal styling
2020-07-01 22:04:23 -04:00
jessop 36f93343f6 new channel creating and editing 2020-07-01 22:01:48 -04:00
infiinte-persistence 192bf12a0e refresh youtube creator status when switching between channels
Issue 3750
2020-06-29 10:19:05 -04:00
jessop e065c81f88 support channel pending state 2020-06-22 11:27:03 -04:00
jessopb dbac4aca39
Revert "improve channel update" 2020-06-19 13:10:34 -04:00
jessop 99753f7717 improve channel edit 2020-06-19 12:41:45 -04:00
Sean Yesmunt 7f6c5c544e only add gradient to bottom of channel cover 2020-06-18 12:19:21 -04:00
Sean Yesmunt fa246a7f1f move channel search into ChannelContent component 2020-06-18 12:19:21 -04:00
Sean Yesmunt 019d1f9176 tip/support marriage 2020-06-15 10:50:01 -04:00
jessop 91662a9d57 force https thumbs or handle img src error 2020-06-08 09:42:19 -04:00
Sean Yesmunt 85ec35f246 pause gifs until hover round 2 2020-05-28 13:07:51 -04:00
Sean Yesmunt 06f71f2f0d Revert "pause gifs until hover"
This reverts commit e97a03c5c9.
2020-05-28 12:31:45 -04:00
Sean Yesmunt e97a03c5c9 pause gifs until hover 2020-05-28 11:39:39 -04:00
Sean Yesmunt b244261715 commas 2020-05-25 13:29:38 -04:00
Sean Yesmunt 25984444ca hide footer on channel pages 2020-05-15 10:27:38 -04:00
infiinte-persistence 598c336b66 Refactor DateTime to allow it's translated result string to be re-used elsewhere, for consistency. 2020-05-11 14:54:05 -04:00
Sean Yesmunt 85ac7c5aac move edit button on channel pages 2020-05-04 11:38:35 -04:00
Sean Yesmunt 419b3890cd improve share modal 2020-03-30 09:40:23 -04:00
Sean Yesmunt c154db73fd slightly improve channel edits 2020-03-16 14:52:29 -04:00
Sean Yesmunt c9e759fc9f add youtube verified message 2020-02-12 14:11:13 -05:00
jessop 7f0fd02ffc pass nsfw=false to lighthouse searches 2020-01-29 14:27:50 -05:00
Dalton 9323b456bf fixes #3507 by adding 'no results' text to channel search if no results are returned from search
search results now have same style as default content

used ClaimList instead of copying code

addressing pr comments
2020-01-21 11:53:47 -05:00
Dalton 8df1e3f6c7 fixes #3502 by changing the way we 'queue' search queries 2020-01-16 11:27:24 -05:00
Dalton fb7fa5a19e fixes #3303 by stopping event propagation for left and right arrow keys in the search bar 2020-01-15 10:16:42 -05:00
Dalton afda19ccd8 fixes #3306 by not showing the edit screen on a channel that is not yours 2020-01-13 10:42:40 -05:00
Sean Yesmunt a31178318a fix channel page style 2020-01-03 14:25:00 -05:00
Sean Yesmunt 0b38bb1f1a moar cleanup 2020-01-02 18:16:54 -05:00
Sean Yesmunt 7e13493f8e subscriber => follower 2019-12-11 12:10:55 -05:00
Sean Yesmunt bf512e8338 use same code for handling open links on lbry.tv and desktop 2019-12-03 13:25:17 -05:00
Sean Yesmunt 15815e5071 remove [data-mode='dark'] 2019-11-22 16:45:33 -05:00
Sean Yesmunt 97cb4ff3bc hide embed area for channel share modal 2019-11-14 13:04:23 -05:00
Sean Yesmunt 6ad31a3ce9 refactor lbrytv web server 2019-11-11 13:27:29 -05:00
Renamed from src/ui/page/channel/view.jsx (Browse further)