- Buttons on dialogs were not getting width and height
- Tooltip buttons were getting standard button spacing when they
should be closer to their corresponding menu button
- Several buttons and other elements had containers just to get
spacing in button sets; rename button-container class to
button-set-item and apply directly to elements where possible.
This reverts commit c209c1f84f.
This commit may have broken downloading/watching by never showing the download button.
Let's see if reverting it fixes the issue. --grin
Clamp.js doesn't handle fractional-pixel line heights reliably. It
always rounds down the line height when calculating the target height
for the element, and you end up with one less line than you asked for.
On search results pages, stream_cost_estimate is called on every
result. If there's some problem in the daemon that affects all calls
to stream_cost_estimate, this can lead to 25 error boxes. Better to
just suppress the error and not display a price.
Also switched to the new name for the daemon method (get_cost_est ->
stream_cost_estimate)
After moving the padding to the content of buttons, we ended up with
extra padding around text buttons that wasn't there before. The
"Download" bar doesn't look great with no padding at all, but it needs
to match the text buttons so the text doesn't jump to the right when
it switches from "Download" (text button) to "Connecting" (progress bar).
So we pad both text buttons and progress bars just a little bit, less
than a standard button but enough that progress bars look OK.
- Don't fade out tile
- Display message in place of buttons with an option to bypass the
message
- Factor out message into its own FileUnavailableMessage component
Before this fix, if the daemon wasn't accepting connections
the UI would get an error and then be stuck on the loading screen.
We now check if the daemon is accepting connections first, and then
check for the status.
