Commit graph

334 commits

Author SHA1 Message Date
infiinte-persistence
80b4600f60 Str-context-split: "Follow"
## Issue
4192
2020-10-14 17:44:44 -04:00
infiinte-persistence
567316cfbe Support for multiple string context + "About" as initial example.
## Issue
4796 - i18n: Allow support for string overloading (multiple contexts)

## Approach
- Minimal code and process change.
- Handle on a case-by-case basis when reported by translators.
- Split the affected key in the string json by appending the context.
- Translators need to be aware of the new format and not translate context itself. Code is added to detect bad translations and will revert to English.

Sample in json:
  "About --[About section in Help Page]--": "About",
  "About --[tab title in Channel Page]--":  "About",

Sample in client code:
  title={__('About --[About section in Help Page]--')}

- "--[ ]--" was chosen as it's unique enough (unlikely for real strings to use it) and hopefully not that distracting in the client code.
- In the key itself, spaces are allowed after the string (i.e. before '--[') for neatness. It will be trimmed by the system.

## First example
"About" is used in 3 places:
   - Channel Page
   - Help Page
   - Footer (in Odysee branch)

For Russian, the word "About" is "O" and is usually not used standalone, but requires something behind it. A translator said so, and seems to be the case in other sites as well.
   "O xxx"
   "O yyy"

## Other languages
For other languages that are not impacted, they can just clone the same translation for each of the split keys, just like in English.

## Possible enhancement in Transifex
I see that Transifex's API includes a `context` entry. It might be possible to move the context-metadata there during the upload, so translators will never see the "--[]--" messiness (it will be shown as "Context: xxx" in the Transifex GUI).

I'm not sure how to test the Transifex side, so I did not investigate further.
2020-10-14 17:44:44 -04:00
Sean Yesmunt
172e918de5 pass to 2020-10-13 15:31:07 -04:00
Sean Yesmunt
88c86ff447 add help link 2020-10-12 23:21:23 -04:00
Sean Yesmunt
4815aa9ff1 add reward rate + analytics link on channels page 2020-10-12 23:21:23 -04:00
infiinte-persistence
1100a07108 Comment v69 strings and misc. 2020-10-08 10:37:17 -04:00
Sean Yesmunt
c1b5280446 move youtube badge to 'channel about' section 2020-10-06 16:30:03 -04:00
ioancole
9d51cee72c Correctly navigate to channel URL 2020-10-05 16:43:29 -04:00
infiinte-persistence
ef12914cad Rebranding: 'Publish' --> 'Upload'; Use LBC icon 2020-10-02 10:25:17 -04:00
infiinte-persistence
16b1605a35 Add SETTINGS.ENABLE_PUBLISH_PREVIEW
This option allows users to bypass the "publish preview" modal. Users can disable it by checking "don't show this again" in the modal, and re-enable it in the Settings Page.
2020-10-02 10:25:17 -04:00
Sean Yesmunt
a92a3305b1 align FileActions with odysee style 2020-09-30 17:00:18 -04:00
infiinte-persistence
5df4ed2783 String scrub from odysee/release merge
- More missing strings
- Moved strings around to keep related strings together (easier for translators to guess the context)
- Removed translation macro for blank string
- Fix typo for 'Neetwork'
2020-09-30 14:06:11 -04:00
Sean Yesmunt
b0d19455c1 add placeholder upvote/downvote buttons on comments 2020-09-29 17:12:32 -04:00
Sean Yesmunt
bf9be7c46d keep header on regular discover page 2020-09-29 17:12:32 -04:00
Sean Yesmunt
51d8d85c60 re-enable reposts for SIMPLE_SITE 2020-09-29 17:12:32 -04:00
Sean Yesmunt
6b8a38b894 add spinner to web upload message and fix double card issue 2020-09-29 17:12:32 -04:00
Sean Yesmunt
23f218a568 use backout mode on publish page 2020-09-29 17:12:32 -04:00
Sean Yesmunt
299301b633 make channel/tag follow intro optional 2020-09-29 17:12:32 -04:00
Sean Yesmunt
4e1076e01b make category header clickable 2020-09-29 17:12:32 -04:00
Sean Yesmunt
c1e6e90896 large claim-grid header text + optional icon 2020-09-29 17:12:32 -04:00
Sean Yesmunt
cc0b1aea65 add backout option for youtube sync and fix scroll reset 2020-09-29 17:12:32 -04:00
Sean Yesmunt
ac770518bf remove old syncSettings usage 2020-09-29 17:12:32 -04:00
Sean Yesmunt
f547053ebc add yotube sync to initial sign up flow 2020-09-29 17:12:32 -04:00
Sean Yesmunt
295fec0370 copy changes 2020-09-29 17:12:32 -04:00
Sean Yesmunt
bc89d774ba add youtube sync to first run 2020-09-29 17:12:32 -04:00
Sean Yesmunt
83a6589cd0 new lbc icon 2020-09-29 17:12:32 -04:00
Sean Yesmunt
5014b1a027 fix notification linking to channel page 2020-09-29 17:12:32 -04:00
Sean Yesmunt
3f32f5a0ca make sure notifications aren't hidden 2020-09-29 17:12:32 -04:00
Sean Yesmunt
14355ed966 fix copy 2020-09-29 17:12:32 -04:00
Sean Yesmunt
1f2fabe81b Use sentence case for all card titles 2020-09-29 17:12:32 -04:00
Sean Yesmunt
7f6ab894d1 create YrblWalletEmpty for generic yrbl with empty wallet message 2020-09-29 17:12:32 -04:00
Sean Yesmunt
391cc76bd8 use consitent style for 'empty wallet' message on pages that require LBC 2020-09-29 17:12:32 -04:00
Sean Yesmunt
a5107f075c wip with channel prompts on comments 2020-09-29 17:12:32 -04:00
Sean Yesmunt
87247feb23 copy 2020-09-29 17:12:32 -04:00
Sean Yesmunt
88fac1b30b copy changes 2020-09-29 17:12:32 -04:00
Sean Yesmunt
2dee81b624 Sign In => Log in 2020-09-29 17:12:32 -04:00
Sean Yesmunt
248e578422 new comments 2020-09-29 17:12:32 -04:00
Sean Yesmunt
b4106b1a65 fix library page for new ClaimListDiscover styling 2020-09-29 17:12:32 -04:00
Sean Yesmunt
19fb7d7f06 new layout 🕺 2020-09-29 17:12:32 -04:00
jessop
9127266956 get sync password out of signing flow 2020-09-21 14:11:25 -04:00
jessop
3b23f09bed fix sync clean wallet bug
remove previous changes,keep syncpref in wallet, change anon wallet pref key to local

sync choices wip

dont relocate syncenable setting

bump

no prefs on web unauth

bugfix redux bump

pull after sync change

bump
2020-09-21 14:11:25 -04:00
infiinte-persistence
631b069f9a Missing translation in the Discover page. 2020-09-21 11:57:16 -04:00
Sean Yesmunt
ccd1cabe04 add option for light background on embeds 2020-09-21 11:38:56 -04:00
jessop
6c4842a111 sync changes 2020-09-10 14:20:02 -04:00
ioancole
055a476d2f Hide search page URI header for invalid channel/stream name 2020-09-10 13:36:33 -04:00
Sean Yesmunt
c80b28ade9 Revert "Hiding URIs header for invalid URIs"
This reverts commit 8f407a36d4.
2020-09-10 11:30:55 -04:00
ioancole
8f407a36d4 Hiding URIs header for invalid URIs 2020-09-10 11:08:22 -04:00
Sean Yesmunt
4035c18f8e Publishes => Uploads 2020-08-25 12:25:25 -04:00
Sean Yesmunt
22586c802c revert redirect after signin until we can signin users from verfication token 2020-08-25 12:25:25 -04:00
Sean Yesmunt
9ee4b256fb add mark as seen to notifications 2020-08-21 16:04:27 -04:00