Commit graph

8968 commits

Author SHA1 Message Date
Sean Yesmunt
b4851e6045 bring in email preferences page from lbry.com 2020-06-22 09:45:49 -04:00
Alex Grin
8440a31a28 typo 2020-06-22 09:35:39 -04:00
Alex Grin
d8b4c91259 minor typo
this is the more common spelling of revocable
2020-06-22 09:35:39 -04:00
infiinte-persistence
1cd18ac9f4 Inf-scroll: (1) Reset to top (2) Fix "page vs. results" being out of sync.
--- Issues:
(1) #-2669: Page does not restore to top when navigating new tags.

(2) "Encountered children with the same key" error (duplicate entries shown).
https://github.com/lbryio/lbry-desktop/issues/4367#issuecomment-645449206

--- Changes:
(1) Ignore the history if it's a new query (i.e. explicitly clicked). The BACK history will still behave as normal (doesn't reset to top).

(2) Previously, the `page` variable will continue to increment as you scroll and stay within the page (e.g. Trending vs New, or clicked another Tag). As you move between queries, we hit a scenario where `page` is significantly under or over the latest retrieved `claimSearchResult.length`. This messes up the rest of the code.

Fix by correcting the value of `page` according to the current `claimSearchResult.length` when necessary.
2020-06-22 09:31:05 -04:00
eatdostacos
c1df38f41c Update app-strings (Rebased) 2020-06-22 09:30:09 -04:00
jessopb
95a9848293
Merge pull request #4406 from lbryio/revert-4405-feat-channelUpdatesPending
Revert "improve channel update"
2020-06-19 13:10:53 -04:00
jessopb
dbac4aca39
Revert "improve channel update" 2020-06-19 13:10:34 -04:00
jessopb
802f0baeea
Merge pull request #4405 from lbryio/feat-channelUpdatesPending
improve channel update
2020-06-19 12:58:32 -04:00
jessop
a0a461efe0 bump 2020-06-19 12:45:44 -04:00
jessop
1b185942e4 appstrings 2020-06-19 12:42:17 -04:00
jessop
99753f7717 improve channel edit 2020-06-19 12:41:45 -04:00
infiinte-persistence
644e76fd81 Tip-Modal: Add settings persistence and UX improvements.
--- Issues:
(1) #-4394 add persistence to new support modal.
(2) Should collapse the custom field when presets are selected.
Even though the Send button repeats the amount for Tip, it's still confusing to see both the Preset being active and Custom numeric field visible.
(3) Missing localization tags.
2020-06-18 22:01:49 -04:00
Sean Yesmunt
117ccd87e1 move repost icon to submit button instead of card for consistency 2020-06-18 12:19:21 -04:00
Sean Yesmunt
a4a80ee2f6 handle language fetch failure 2020-06-18 12:19:21 -04:00
Sean Yesmunt
7f6c5c544e only add gradient to bottom of channel cover 2020-06-18 12:19:21 -04:00
Sean Yesmunt
fa246a7f1f move channel search into ChannelContent component 2020-06-18 12:19:21 -04:00
Joshua Strobl
a479c70021 Resolve corejs3-shipped-proposals build issues.
@babel/compat-data 7.8.6 to pre-7.10 series has compilation issues with newer node 12.x and 13.x releases. Using 7.8.6 will cause the failure to find the module `'@babel/compat-data/corejs3-shipped-proposals'`, causing build failures on systems with those node releases (e.g. Solus).

This patch bumps @babel/preset-env, @babel/preset-flow, and @babel/preset-react specifically to newer releases to resolve compilation. Please note that this does not update all of babel to newer 7.10 series releases, just specifically resolves compilation on specific Linux platforms.
2020-06-17 00:54:00 -04:00
Sean Yesmunt
cc6ca19a62 update changelog 2020-06-16 17:14:22 -04:00
Sean Yesmunt
c45e5c751e use css variables for button placement 2020-06-16 17:14:22 -04:00
infiinte-persistence
d01c20394e Fix "muted=false + volume=0" case.
We need to handle two types of "mute":
- Volume icon is pressed to mute.
- Volume slider moved to 0%.
2020-06-16 17:14:22 -04:00
infiinte-persistence
662778c47b Use 'process.env.NODE_ENV' instead of 'electron-is-dev' for spewing debug logs. 2020-06-16 17:14:22 -04:00
infiinte-persistence
a20ea08ac7 Show "unmute" option on videos automatically muted by browser.
Implementation:
- The code is placed in <VideoJs> instead of <VideoViewer> as we need to control the video itself. It's more self-contained here, rather than trying to pass refs around between parent and child.
- useState cannot be used as it will cause a re-render when the hint it clicked and dismissed. The DOM is used to hide the button.
2020-06-16 17:14:22 -04:00
infiinte-persistence
bbda69dc5f Inf-scroll: Don't add pages when no more results are available.
--- The bad scenario:
A less popular tag like 'kanji' yields only 23 results today. The code continues to increase the page count. We'll either see some blank page glitches at the bottom, or repeated entries being shown.

--- The fix:
Assume that an unfilled page means "no more results" and stop incrementing the page. This seems true based on empirical evidence.
2020-06-16 16:59:00 -04:00
infiinte-persistence
522c6ddcd6 Inf-scroll: Fix "am I at bottom" logic.
If you are at the bottom and you hit the UP_ARROW key one time, the logic still thinks we are at the bottom, despite the component has clearly moved. Similar to the issue noted in the previous commit, this causes the page to increment incorrectly.

My wild guess is that the previous logic depends on the css height, so it might got broken due to css changes. Hopefully the new calculation is more robust and works for all cases.
2020-06-16 16:59:00 -04:00
infiinte-persistence
c957b159b1 Inf-scroll: Debounce before handling 'onscroll'.
---The bad scenario:
If you're at the bottom and you go up using UP_ARROW or HOME key, the coordinate is still at the bottom if we service the callback immediately. This causes 'contentWrapperAtBottomOfPage' to be true and we ended up incrementing the page unnecessarily (even for searches that no longer yield any extra results).

---Fix:
Fix by adding a delay. The value can probably be fine-tuned further.
2020-06-16 16:59:00 -04:00
infiinte-persistence
ff7b4092c9 Publish: Make 'Channel' setting persistent.
Per discussion with Tom.
2020-06-16 16:36:23 -04:00
infiinte-persistence
9d6af38a21 Persist trending selectors between tags.
---The issue:
When switching between tags, the selector defaults back to Trending even though you had another option already selected.

---Changes:
- 'orderParamUser' will store the last user state persistently. The persistent state is also made unique for each page (i.e. Your Tags and All Content will be unique).

- If the parent component passes in a specific order, that will be respected and will also become the new persisted value. One example is "Your Following", where it always starts at 'New'.

- Handled navigation history correctly
The test case:
   - Enter "Your Tags" (assume start at 'Trending')
   - Click 'New'
   - Click 'Top'
   - Back
   - Back (it should return to 'Trending')
As the top page history does not have any "?order=" value, we ended up with a no-op for the last Back. 'orderParamEntry' is added to handle this.
2020-06-16 16:36:23 -04:00
Sean Yesmunt
19eefdf1da adjust sizes 2020-06-16 16:24:12 -04:00
Alex Grintsvayg
b26a586fb5 wider diff in header sizes for md posts 2020-06-16 16:24:12 -04:00
eatdostacos
bcbb0685e4 Add new app strings from tip/support merge 2020-06-16 16:11:33 -04:00
Sean Yesmunt
ea90fd8b18 fix number width and update lbryinc 2020-06-16 09:56:32 -04:00
Sean Yesmunt
2066205b8f add user + rewards redux code from lbryinc 2020-06-16 09:56:32 -04:00
Sean Yesmunt
7138fe54bc bring in 'notifications' state from lbry-redux 2020-06-16 09:56:32 -04:00
eatdostacos
5a219c7b4b Add link to "Buy More LBC" button
Previously, the link was missing and the button didn't do anything.
2020-06-16 09:13:15 -04:00
eatdostacos
178fcf28c9 Add new unreleased version to changelog 2020-06-16 09:12:43 -04:00
Sean Yesmunt
8a825b1a83 fix typo 2020-06-15 19:18:34 -04:00
Sean Yesmunt
f13cc3c51c fix label on tx table for supports 2020-06-15 19:02:03 -04:00
Sean Yesmunt
ca988d38ae fix layout on '/$/report' 2020-06-15 14:11:15 -04:00
infiinte-persistence
fe431c30a7 SimpleMDE: Add character-count display and standardize look with basic editor's. 2020-06-15 10:53:17 -04:00
infiinte-persistence
805904360e Set "Description" field limit to 5000 characters.
This applies to both Channel and Claim description.
2020-06-15 10:53:17 -04:00
infiinte-persistence
749b13e3eb Rename: "constants/comments.js" --> "constants/form-field.js" 2020-06-15 10:53:17 -04:00
infiinte-persistence
96041e8b09 SimpleMDE: Add character limit functionality. 2020-06-15 10:53:17 -04:00
infiinte-persistence
c197a1f230 Don't gray out on "Support/tip unlock" or "Abandon Claim" failures.
#4379
2020-06-15 10:51:50 -04:00
infiinte-persistence
22f272d53e Accumulated string updates. 2020-06-15 10:51:26 -04:00
infiinte-persistence
140364cb67 Fix translation issues in the Publish modal dialog.
Two issues:
1. Values not marked with __()
2. Split sentence.

For #2, it seems like there are translations that don't make sense when combined, because the values are being translated independently from full sentence in Transifex. Decided to just make it full sentences.
2020-06-15 10:51:26 -04:00
Sean Yesmunt
4bbd831a16 fix mobile style 2020-06-15 10:50:01 -04:00
Sean Yesmunt
c3cdc742ab fix submit button after confirming 2020-06-15 10:50:01 -04:00
Sean Yesmunt
deb4107dd0 confirmation cleanup 2020-06-15 10:50:01 -04:00
Sean Yesmunt
01e0a2a5db improve support/tip for 0 balance and own claims 2020-06-15 10:50:01 -04:00
Sean Yesmunt
019d1f9176 tip/support marriage 2020-06-15 10:50:01 -04:00