Commit graph

2843 commits

Author SHA1 Message Date
Sean Yesmunt c5a2126abe disable snapshot thumbnail on desktop to prevent desktop crashes
https://github.com/electron/electron/issues/20750\#issuecomment-709505902
2020-10-15 14:32:58 -04:00
infiinte-persistence e947307f86 Fix typo "Logging in in as ..." 2020-10-15 00:09:01 -04:00
infiinte-persistence 511a746871 Str-context-split: "To" and "From"
## Note from Russian translator
"To/From" in the 'automatic dark mode setting' cannot be re-used for the one in the 'Tip Modal'.

## Change
Wanted to split this into "general" and "time", but I'm guessing it won't satisfy all languages, so we'll just use the usage as the context since there's just 2 instances.
2020-10-14 17:44:44 -04:00
infiinte-persistence 80b4600f60 Str-context-split: "Follow"
## Issue
4192
2020-10-14 17:44:44 -04:00
infiinte-persistence d7a178d259 Str-context-split: "Post"
Splitting the context between "Markdown post" (noun) vs. "Post something" (verb)
2020-10-14 17:44:44 -04:00
infiinte-persistence 6dd40df93b Str-context-split: "Support"
Chinese, Spanish and other translators reported the difficulty in using "Support" as both a noun and verb in their language.
2020-10-14 17:44:44 -04:00
infiinte-persistence 567316cfbe Support for multiple string context + "About" as initial example.
## Issue
4796 - i18n: Allow support for string overloading (multiple contexts)

## Approach
- Minimal code and process change.
- Handle on a case-by-case basis when reported by translators.
- Split the affected key in the string json by appending the context.
- Translators need to be aware of the new format and not translate context itself. Code is added to detect bad translations and will revert to English.

Sample in json:
  "About --[About section in Help Page]--": "About",
  "About --[tab title in Channel Page]--":  "About",

Sample in client code:
  title={__('About --[About section in Help Page]--')}

- "--[ ]--" was chosen as it's unique enough (unlikely for real strings to use it) and hopefully not that distracting in the client code.
- In the key itself, spaces are allowed after the string (i.e. before '--[') for neatness. It will be trimmed by the system.

## First example
"About" is used in 3 places:
   - Channel Page
   - Help Page
   - Footer (in Odysee branch)

For Russian, the word "About" is "O" and is usually not used standalone, but requires something behind it. A translator said so, and seems to be the case in other sites as well.
   "O xxx"
   "O yyy"

## Other languages
For other languages that are not impacted, they can just clone the same translation for each of the split keys, just like in English.

## Possible enhancement in Transifex
I see that Transifex's API includes a `context` entry. It might be possible to move the context-metadata there during the upload, so translators will never see the "--[]--" messiness (it will be shown as "Context: xxx" in the Transifex GUI).

I'm not sure how to test the Transifex side, so I did not investigate further.
2020-10-14 17:44:44 -04:00
Sean Yesmunt 44bcc943a0 add new sort icons for new/best/controversial 2020-10-14 16:51:48 -04:00
Sean Yesmunt 77aa580690 add spacing for ul/ol next to p elements 2020-10-14 11:33:39 -04:00
Sean Yesmunt 172e918de5 pass to 2020-10-13 15:31:07 -04:00
Sean Yesmunt 4b98cf45f3 prevent clicking through help links 2020-10-12 23:21:23 -04:00
Sean Yesmunt 88c86ff447 add help link 2020-10-12 23:21:23 -04:00
Sean Yesmunt 4815aa9ff1 add reward rate + analytics link on channels page 2020-10-12 23:21:23 -04:00
Sean Yesmunt 65c39cbbc8 fix mobile comments on ios devices 2020-10-12 15:21:03 -04:00
Sean Yesmunt 03f1fe3ee5 make youtube sync web only 2020-10-09 17:08:38 -04:00
Sean Yesmunt 8bb6643a41 switch back to 'slimed to death' 2020-10-09 11:38:50 -04:00
Sean Yesmunt 60569de672 hide comments that were slimed to death TM 2020-10-08 15:57:20 -04:00
Sean Yesmunt b1bca7982a re-enable lbry:// link styles in comments
will add support for odysee/lbry.tv once the style is finalized
2020-10-08 14:19:21 -04:00
Sean Yesmunt 480d8a8786 wait to scroll to linked comments until readyToDisplay=true 2020-10-08 14:19:21 -04:00
Sean Yesmunt 6d4a92ad27 format reaction count to include commas 2020-10-08 14:19:21 -04:00
Sean Yesmunt c1bd9ad6af update app-strings 2020-10-08 13:15:22 -04:00
Sean Yesmunt 761b93d811 add style for comments with is_pinned=true 2020-10-08 11:48:32 -04:00
jessop 7678eedf4d catch claim error on referrer set 2020-10-08 10:52:44 -04:00
infiinte-persistence 1100a07108 Comment v69 strings and misc. 2020-10-08 10:37:17 -04:00
Sean Yesmunt 5d2d6d2a94 always show your own comments at the top 2020-10-07 17:11:22 -04:00
Sean Yesmunt c43eff8587 comments v69 2020-10-07 17:11:22 -04:00
infiinte-persistence 6198ab57de String: fix untranslated 'File|Post' tab
Both "File" and "Post" are already added in the database, so this should now work.
2020-10-07 16:25:03 -04:00
infiinte-persistence 4294e0109a String: fix variable-resolving problems 2020-10-07 16:25:03 -04:00
infiinte-persistence 54cdf2a7e6 Add comment sorting strings 2020-10-07 16:25:03 -04:00
infiinte-persistence 4a2e9bf1c7 Fix: Videos start muted on initial session
## Issue
4831: Videos start muted on Desktop (fresh install) and web (sometimes resets)

This covers the Desktop fresh install and Web fresh session (incognito) part. It doesn't cover the "sometimes reset" part as I don't know how to reproduce that.

## Change
`sessionStorage` is always empty when that piece of code is called, even for non-fresh Desktop and even in Brave. We now fallback to `1` when `volume` is `null`. Still not sure the purpose of that code, but leaving it there just in case something relies on it.

## Tests
[/] Desktop fresh-install is not muted.
[/] Desktop return session restores previous volume level.
[/] Web* fresh session (cleared data) is not muted.
[/] Web return session restores previous volume level.

*Web = Chrome, Firefox and Brave.
2020-10-07 16:24:34 -04:00
Sean Yesmunt 85e2ee28a3 add referral code to embed links 2020-10-07 16:23:53 -04:00
jessop 3ca19744c4 only autoset referrer if not authenticated 2020-10-07 13:30:49 -04:00
jessop 10ce772bcb initial page view sets referring channel 2020-10-07 11:44:12 -04:00
Sean Yesmunt ec3307320a fix controversial icon spacing 2020-10-06 17:46:32 -04:00
Sean Yesmunt f534291767 update comment sort icons 2020-10-06 17:36:13 -04:00
Sean Yesmunt 0326e266d4 make sure comments are rendered before trying to render more 2020-10-06 16:33:51 -04:00
Sean Yesmunt c1b5280446 move youtube badge to 'channel about' section 2020-10-06 16:30:03 -04:00
Sean Yesmunt fc2a79242e don't add scroll listener until comments have been fetched 2020-10-06 16:13:42 -04:00
Sean Yesmunt 00c05437ca add comment sorting and improve comment focus styles 2020-10-06 16:04:52 -04:00
Thomas Zarebczan 136d73d2ff
Fix Japanese language code 2020-10-06 11:37:19 -04:00
infiinte-persistence 329f6b3da6 Comment: Change 'shift+enter' to 'ctrl|cmd+enter' for quick submit.
ctrl+enter is generally used for this action, while shift+enter generally used to insert a <br>.
2020-10-06 02:02:11 -04:00
Sean Yesmunt c159f34b24 add infinite scroll for comments 2020-10-05 17:34:06 -04:00
ioancole 9d51cee72c Correctly navigate to channel URL 2020-10-05 16:43:29 -04:00
ioancole 7f00a01c2b Check search string for web URL prefixes and remove 2020-10-05 16:43:29 -04:00
Sean Yesmunt d9acb034e1 odysee alignment 2020-10-05 14:55:52 -04:00
Sean Yesmunt 00b23cbee4 moar alignment 2020-10-05 14:28:19 -04:00
Sean Yesmunt 46a0d213fb fix channel profile img in header 2020-10-05 14:04:31 -04:00
Sean Yesmunt 2abd1ca6c2 fix invite page crashing on large screen 2020-10-05 13:56:43 -04:00
Sean Yesmunt 489a4855e9 alignment with odysee branch 2020-10-05 13:56:43 -04:00
Sean Yesmunt 61dfc2f74a handle comment time display correctly immediately after posting 2020-10-05 11:54:20 -04:00