Commit graph

3971 commits

Author SHA1 Message Date
zeppi d25896d99c recon commentCreate 2021-07-28 15:43:56 -04:00
zeppi b6c21dcb84 patch devmode for custom lbry api 2021-07-28 11:49:36 -04:00
zeppi edebde5a2e file reactions recon 2021-07-28 08:12:29 -04:00
zeppi 2a69c42e5b back to img tag 2021-07-27 15:13:29 -04:00
zeppi b1e8d2d6db desktop logo 2021-07-27 15:13:29 -04:00
zeppi ef77a5cd00 optimizedImage 2021-07-27 15:13:29 -04:00
zeppi 71d9b0d973 default logo 2021-07-27 15:13:29 -04:00
zeppi 3f4c601428 logo component on embeds/embeds ended 2021-07-27 15:13:29 -04:00
zeppi 19f8b0adac logoComponent 2021-07-27 15:13:29 -04:00
zeppi e4d7e4f69d force has source channel page 2021-07-26 14:17:52 -04:00
zeppi 403ea8f6f4 no livestreams on channel content 2021-07-26 14:17:52 -04:00
infinite-persistence 6de16813cb
i18n update 2021-07-26 23:31:03 +08:00
infinite-persistence 077207e203
ChannelPage: Don't mount inactive ChannelContent
## Issue
In the Channel Page, if the _Collections_ `claim_search` comes in after the main content's `claim_search`, the Collection's `ChannelContent` is being re-rendered despite not being in the active Tab. This causes a 0.4 CLS score (it's ridiculous that invisible components are taken into account). Apparently 41% of users are hitting this scenario, causing a poor aggregate.

## Change
Don't mount the `ChannelContent` components unless its tab is the active one. It doesn't seem like Reach Tab hides components under the inactive tab.
2021-07-26 22:01:31 +08:00
infinite-persistence f6e648222e
Change constants to object for IDE auto complete
No functional change; just thought this is cleaner (group up the constants) and easier to type via IDE auto-complete, at the expense of creating an extra object.
2021-07-26 22:01:30 +08:00
infinite-persistence 8dc18e8fcd
Fix split (concat) string usage
Concatenated strings are hard to translate.
2021-07-26 12:37:59 +08:00
zeppi 8fef6c6160 ugly discover recon 2021-07-24 11:29:30 -04:00
zeppi e3006a0edb exempt news from hp 2021-07-23 16:03:01 -04:00
infinite-persistence 76a6c0441c Beautify/elaborate comment spam-check message 2021-07-23 13:33:10 -04:00
zeppi ad3fd5700f default search types from config 2021-07-23 10:31:07 -04:00
zeppi 0987c6e94f publish form recon 2021-07-23 10:14:22 -04:00
infinite-persistence ffad52d5b7 Remove console.log
Seems like lint is being bypassed recently?
2021-07-23 08:42:58 -04:00
infinite-persistence 6e402240b0
Fix muted-words now returning null instead of ""
## Issue
Creating Settings suddenly start to stop loading correctly for some of my channels.

## Change
`settings.List` now returns null instead of empty array. Double-checked the Commentron repo and this is indeed the case.

Updated the code to handle null.
2021-07-23 15:46:38 +08:00
infinite-persistence 7a8d213861
Eliminate CLS in Recommended due to wrapper mismatch
Seem like `type === small` was missed out, so it was using a wrapper than necessary, causing the shift.
2021-07-23 13:23:52 +08:00
infinite-persistence c62c667436
CLS: reserve space for injected video ads 2021-07-23 13:23:51 +08:00
zeppi 038431f95c channel follow first run on master 2021-07-23 00:00:32 -04:00
zeppi ed0387d94a pinning 2021-07-22 23:24:55 -04:00
zeppi f2cd9f372e Chan fol disc recon 2021-07-22 23:08:33 -04:00
zeppi d88752c646 music icon, fix lint 2021-07-22 17:31:46 -04:00
Anthony 15e696c4d6 bugfix not updating the frontend on account add 2021-07-22 17:23:51 -04:00
zeppi 085ea15247 settings page recon 2021-07-22 14:43:01 -04:00
zeppi e920738cd1 file page recon 2021-07-22 14:28:12 -04:00
Anthony 78b4fa05b3 pull out variable for max and min fiat amounts 2021-07-22 14:06:59 -04:00
Anthony 7975ccf3e0 disable button if theres a fiat tip error 2021-07-22 14:06:59 -04:00
Anthony 713dc69ed7 add check for two decimals and fix showing error for fiat tip 2021-07-22 14:06:59 -04:00
infinite-persistence ecb14be871
Fix broken embeds in incognito
## Issue
Closes 6490
Embeds in https://lbry.com/news/2002dtf was crashing in incognito

## Change
Ensure localStorage is available before using it. Jessop warned me before...
2021-07-23 00:50:02 +08:00
zeppi f4559c1cce fileSubtitle recon 2021-07-22 12:09:54 -04:00
zeppi 8919182c0c default avatar config 2021-07-22 09:44:57 -04:00
infinite-persistence 032e17cecd
Improve CLS on Posts
## Issue
6068 Fix "Cumulative Layout Shift" for Core Web Vitals

In Posts, the Comments section appears first while we fetch the MD file. When the MD is fetched, Comments get pushed to the bottom (or shifted up for short posts), hence the red CLS scores.

## Approach
There are too many layers between `<FilePage>` and `<DocumentViewer>` to pass the `loading` state around to hide the Comments section, so just make Comments fade in after a 2s delay.

## Changes
- Posts: Add 2s fade-in delay to Comments.
- Posts: remove the gray placeholder. This improves the score a bit more, and reduces flicker as well. There's already a spinner from `FileRenderInline` to tell the user to be patient.
- Posts: add a minimum 30vh height so that short posts don't get collapsed too much, causing the `FileDetails` and Comments to shift. Small shifts are fine as long as CLS is below 0.1.
2021-07-22 10:38:01 +08:00
infinite-persistence 50c606d916 claimListDiscover: don't re-render until query is done
## Issue
6542 Livestream listing and blocked list kills CLS score

This is basically a repeat of what was done on `claimTileDiscover` (homepage), but now on `claimListDiscover` (category pages).

This handles the unnecessary re-render when:
- the uri list temporarily being zero while waiting for new claim-search results.
- livestream claim-search invalidating the list.

## Changes
Store the last uri list and use that when we know that claim-search is still not done.

## Tests
1. Ran Lighthouse on category pages (force a livestream channel on it). CLS score must be green.
2. Block `claim_search` from Dev Tools and move to another category. The page should say "timed out" instead of "no results" (i.e. maintain existing behavior).
2021-07-21 21:51:12 -04:00
zeppi 1994b5da04 guidelines optional in sidenav 2021-07-21 20:26:17 -04:00
zeppi fbf105e113 fileActions recon 2021-07-21 18:37:43 -04:00
zeppi 573ed1e88c recon followDisc 2021-07-21 16:58:13 -04:00
zeppi 91b908ad50 pubfile copy 2021-07-21 16:18:46 -04:00
zeppi 6ec95647e7 lbc remove file 2021-07-21 15:56:09 -04:00
infinite-persistence 4fc6b89975 Fix reposted channels incorrectly showing the channel thumb
## Issue
6589

## Notes
`parseURI` will return `isChannel=false` due to the reposted channel URL not having the '@' symbol.

Since we already have the claim object, check `value_type` directly instead.
2021-07-21 14:41:47 -04:00
saltrafael b164a5d1f4 Pop up Menu Fixes and Improvements
Pop up Menu Fixes and Improvements

Improve re-directs

Fix file deletion

Improve code, and more

Fix List Layout collection popup

Allow to edit list

Fix blocking when not logged or no channel

Fix Edit and Delete showing for not owned Lists

Fix actions breaking when not logged in

Fix List options not showing

Lint

Shorten logic

Lint
2021-07-21 14:40:44 -04:00
zeppi fdca58727c restore paid content 2021-07-21 12:49:56 -04:00
zeppi 1600bb69b9 sms copy 2021-07-21 08:11:33 -04:00
infinite-persistence 6b2548cc49
Fix channel-selector thumbnail not updating
Recently changed to `<OptimizedImg>`, which was assuming the `src` never changes.

dejavu ... we also hit this issue when implementing the `IntersectionObserver` lazy-loading.
2021-07-21 16:38:54 +08:00
Dispatch e138673d27
Merge pull request #6508 from saltrafael/live_comments
Fix 'Recent Comments' button for livestreams
2021-07-20 12:33:52 -07:00