[redesign] implement dark mode #1034

New issue

Closed

opened 2018-02-21 19:45:06 +01:00 by neb-b · 3 comments

neb-b commented

2018-02-21 19:45:06 +01:00

(Migrated from github.com)

This will include cleaning up all the color variables/removing what we don't need

btzr-io commented

2018-02-28 03:34:39 +01:00

(Migrated from github.com)

@seanyesmunt Do you need any help with this ?
I'm currently fixing the dark theme on redesign just to see how will look 👀

BTW redesign is looking awesome 👍

@seanyesmunt Do you need any help with this ? I'm currently fixing the dark theme on `redesign` just to see how will look :eyes: BTW `redesign` is looking awesome :+1:

neb-b commented

2018-02-28 03:43:47 +01:00

(Migrated from github.com)

Yeah if you are interested I would love some help with this! Colors across the redesign branch are missing a lot of stuff. I was planning on working on this last so feel free to make a PR to redesign if you would like!

You can check out http://lbry.zzk.fr/explore to get an idea of the new dark mode colors.

Yeah if you are interested I would love some help with this! Colors across the `redesign` branch are missing a lot of stuff. I was planning on working on this last so feel free to make a PR to `redesign` if you would like! You can check out http://lbry.zzk.fr/explore to get an idea of the new dark mode colors.

👍 1

neb-b commented

2018-02-28 03:51:12 +01:00

(Migrated from github.com)

@btzr-io I think currently there are a fair bit of color variables that aren't being used. Feel free to delete those/rename any that are confusing.

I know I've used color variables instead of a specific element variables as I've been working on this just to save some time. Ex:

.btn {
  background-color: var(--color-primary);
}

which should be something like

.btn {
  background-color: var(--button-background);
}

Same for color: var(--color-black) instead of color: var(--text-color)

Let me know if you have any questions!

@btzr-io I think currently there are a fair bit of color variables that aren't being used. Feel free to delete those/rename any that are confusing. I know I've used color variables instead of a specific element variables as I've been working on this just to save some time. Ex: ``` .btn { background-color: var(--color-primary); } ``` which should be something like ``` .btn { background-color: var(--button-background); } ``` Same for `color: var(--color-black)` instead of `color: var(--text-color)` Let me know if you have any questions!

👍 1