Retain previous screen sizing on startup #1057

Merged
miikkatu merged 1 commit from master into master 2018-03-21 14:29:51 +01:00
miikkatu commented 2018-03-01 11:47:03 +01:00 (Migrated from github.com)

This change fixes issue #338.

This change fixes issue #338.
liamcardenas (Migrated from github.com) reviewed 2018-03-02 02:57:28 +01:00
liamcardenas (Migrated from github.com) left a comment

Hey thanks so much for this! I ran you code and it looks great. I just have one question

Hey thanks so much for this! I ran you code and it looks great. I just have one question
liamcardenas (Migrated from github.com) commented 2018-03-02 02:56:44 +01:00

is there any way that we can have a fully maximized default?

is there any way that we can have a fully maximized default?
miikkatu (Migrated from github.com) reviewed 2018-03-02 08:41:45 +01:00
miikkatu (Migrated from github.com) commented 2018-03-02 08:41:45 +01:00

I updated this PR so that if the window state is not saved yet (the default situation with new app installs), the display resolution is asked from Electron and that's used as the default.

I updated this PR so that if the window state is not saved yet (the default situation with new app installs), the display resolution is asked from Electron and that's used as the default.
tzarebczan commented 2018-03-14 16:09:30 +01:00 (Migrated from github.com)

@seanyesmunt do you think you can review this?

@seanyesmunt do you think you can review this?
neb-b commented 2018-03-15 17:58:26 +01:00 (Migrated from github.com)

@miikkatu Looks great. Could you fix the conflicts? I'll merge after that

@miikkatu Looks great. Could you fix the conflicts? I'll merge after that
miikkatu commented 2018-03-16 05:30:23 +01:00 (Migrated from github.com)

@seanyesmunt PR updated.

@seanyesmunt PR updated.
tzarebczan commented 2018-03-19 20:16:21 +01:00 (Migrated from github.com)

@IGassmann can you review when you get a moment. This touches similar files to the URL issue we've discussed.

@IGassmann can you review when you get a moment. This touches similar files to the URL issue we've discussed.
IGassmann commented 2018-03-20 22:20:47 +01:00 (Migrated from github.com)

@miikkatu Please add a new changelog entry in the CHANGELOG.md file. After that, this should be ready to merge.

@miikkatu Please add a new changelog entry in the CHANGELOG.md file. After that, this should be ready to merge.
miikkatu commented 2018-03-21 07:06:55 +01:00 (Migrated from github.com)

@IGassmann Ok, change log is now updated.

@IGassmann Ok, change log is now updated.
IGassmann (Migrated from github.com) approved these changes 2018-03-21 14:29:03 +01:00
tzarebczan commented 2018-03-21 20:52:44 +01:00 (Migrated from github.com)

Thanks again @miikkatu , sending over a tip shortly :)

Thanks again @miikkatu , sending over a tip shortly :)
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#1057
No description provided.