Remove call to lbry.report_bug #1078

New issue

Closed

opened 2018-03-08 23:39:45 +01:00 by kauffj · 9 comments

kauffj commented

2018-03-08 23:39:45 +01:00

(Migrated from github.com)

This call is deprecated and will be removed in the next daemon release.

It is still being used by the <ReportPage> component.

Instead, an API call should be made directly to HelpScout.

This call is deprecated and will be removed in the next daemon release. It is still being used by the `<ReportPage>` component. Instead, an API call should be made directly to HelpScout.

tzarebczan commented

2018-03-11 21:33:23 +01:00

(Migrated from github.com)

Already reported here https://github.com/lbryio/lbry-app/issues/759, feel free to close this one/mine

kauffj commented

2018-03-12 18:07:05 +01:00

(Migrated from github.com)

See https://developer.helpscout.com/help-desk-api/

tzarebczan commented

2018-04-06 22:22:47 +02:00

(Migrated from github.com)

We broke the report_bug daemon call in 0.19.1 by trying to deprecate it. We either have to fix that or we just switch to the helpscout api for the redesign.

neb-b commented

2018-04-17 01:01:08 +02:00

(Migrated from github.com)

Can we make this call from the app? Or does it have to go through the api?

tzarebczan commented

2018-04-17 01:07:54 +02:00

(Migrated from github.com)

Good point - since there is authentication required for the Helpscout API, we probably can't do this directly from the app right? @kauffj, thoughts?

neb-b commented

2018-04-17 02:46:17 +02:00

(Migrated from github.com)

I think it might be ok to keep the api key in the app, since it will be less prone to abuse than phone verification. Not sure if one is better than the other. Easier to keep it in the app

kauffj commented

2018-04-17 15:35:48 +02:00

(Migrated from github.com)

@tzarebczan @seanyesmunt yes it can be in the app. It's already in the daemon (until report_bug dies) and there's no real difference.

It may be preferable to only check in a dev/test key (if such exist) and have the build process inject the real key, but I don't want to over-engineer this either.

@tzarebczan @seanyesmunt yes it can be in the app. It's already in the daemon (until `report_bug` dies) and there's no real difference. It may be preferable to only check in a dev/test key (if such exist) and have the build process inject the real key, but I don't want to over-engineer this either.

lyoshenka commented

2018-04-18 20:58:18 +02:00

(Migrated from github.com)

I put the daemon command back for now so this is not a release-blocker anymore. Turns out "deprecated" in the daemon actually means "removed".

tzarebczan commented

2019-03-21 15:17:10 +01:00

(Migrated from github.com)

This is now going to internal apis on master, closing