tell user that turning off diagnostic makes them ineligible for rewards #1089

New issue

Closed

opened 2018-03-12 16:56:32 +01:00 by liamcardenas · 4 comments

liamcardenas commented

2018-03-12 16:56:32 +01:00

(Migrated from github.com)

The Issue

Steps to reproduce

Expected behaviour

Tell us what should happen

Actual behaviour

Tell us what happens instead

System Configuration

LBRY Daemon version:
LBRY App version:
LBRY Installation ID:
Operating system:

Anything Else

Screenshots

## The Issue ### Steps to reproduce 1. 2. 3. ### Expected behaviour Tell us what should happen ### Actual behaviour Tell us what happens instead ## System Configuration   - LBRY Daemon version: - LBRY App version: - LBRY Installation ID: - Operating system: ## Anything Else  ## Screenshots

neb-b commented

2018-03-12 17:01:10 +01:00

(Migrated from github.com)

A really simple fix for now would be to just add a message in the label on
the settings page. That should be added before the release

On Mar 12, 2018 11:56 AM, "Liam Cardenas" notifications@github.com wrote:

The Issue Steps to reproduce

Expected behaviour

Tell us what should happen
Actual behaviour

Tell us what happens instead
System Configuration

LBRY Daemon version:

LBRY App version:

LBRY Installation ID:

Operating system:

Anything Else Screenshots

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/lbryio/lbry-app/issues/1089, or mute the thread
https://github.com/notifications/unsubscribe-auth/AQGcji3Dk138Z2qxryRhUkcRKrRrKx70ks5tdpqygaJpZM4Sm57f
.

A really simple fix for now would be to just add a message in the label on the settings page. That should be added before the release On Mar 12, 2018 11:56 AM, "Liam Cardenas" <notifications@github.com> wrote: > The Issue Steps to reproduce > > 1. > 2. > 3. > > Expected behaviour > > Tell us what should happen > Actual behaviour > > Tell us what happens instead > System Configuration > > - LBRY Daemon version: > - LBRY App version: > - LBRY Installation ID: > - Operating system: > > Anything Else Screenshots > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > <https://github.com/lbryio/lbry-app/issues/1089>, or mute the thread > <https://github.com/notifications/unsubscribe-auth/AQGcji3Dk138Z2qxryRhUkcRKrRrKx70ks5tdpqygaJpZM4Sm57f> > . >

LavRadis commented

2018-03-13 13:56:05 +01:00

(Migrated from github.com)

Something like this:

<section className="card"> <div className="card__content"> <h4>{__('Share Diagnostic Data')}</h4> </div> <div className="card__content"> <FormRow type="checkbox" onChange={this.onShareDataChange.bind(this)} defaultChecked={daemonSettings.share_usage_data} label={__( 'Help make LBRY better by contributing analytics and diagnostic data about my usage' helper={__( 'If you disable the sharing of diagnostic data, you will not be eligible to receive LBRY rewards. ' )} /> </div> </section>

I didn't want to make PR since my previous PR is still under review and I still don't have local dev version.

Something like this: `<section className="card"> <div className="card__content"> <h4>{__('Share Diagnostic Data')}</h4> </div> <div className="card__content"> <FormRow type="checkbox" onChange={this.onShareDataChange.bind(this)} defaultChecked={daemonSettings.share_usage_data} label={__( 'Help make LBRY better by contributing analytics and diagnostic data about my usage' helper={__( 'If you disable the sharing of diagnostic data, you will not be eligible to receive LBRY rewards. ' )} /> </div> </section>` I didn't want to make PR since my previous PR is still under review and I still don't have local dev version.

tzarebczan commented

2018-03-16 21:34:36 +01:00

(Migrated from github.com)

When a user tries to claim the reward and it fails due to the setting, they should be alerted to it.

tzarebczan commented

2018-03-20 03:18:05 +01:00

(Migrated from github.com)

Fixed in https://github.com/lbryio/lbry-app/pull/1116