LBRYCommunity/lbry-desktop

Make error modals display full screen properly #113

Merged

alexliebowitz merged 1 commit from fix-error-modals into master

2017-05-05 15:00:10 +02:00

alexliebowitz commented

2017-05-05 06:46:27 +02:00

(Migrated from github.com)

Was not passing in the generic modal-overlay class. (ExpandableModal doesn't provide it automatically so you can omit it and make a totally custom overlay if you want.)

Was not passing in the generic modal-overlay class. (ExpandableModal doesn't provide it automatically so you can omit it and make a totally custom overlay if you want.)

alexliebowitz (Migrated from github.com) reviewed 2017-05-05 06:50:38 +02:00

ui/js/component/modal.js

					
				@ -30,3 +30,3 @@

				                  className={(this.props.className || '') + ' modal'}

				                  overlayClassName={[null, undefined, ""].indexOf(this.props.overlayClassName) === -1 ? this.props.overlayClassName : 'modal-overlay'}>

				                  overlayClassName={![null, undefined, ""].includes(this.props.overlayClassName) ? this.props.overlayClassName : 'modal-overlay'}>

				        <div>

alexliebowitz (Migrated from github.com) commented

2017-05-05 06:50:38 +02:00

No logic problem here, just updating to use the ES6 function

No logic problem here, just updating to use the ES6 function

Sign in to join this conversation.

No reviewers

No labels

area: discovery

area: installer

area: livestream

area: performance

area: subscriptions

feature request

first-timers-only

good first issue

merge when green

needs: exploration

needs: grooming

needs: priority

needs: tech design

priority: blocker

priority: medium

protocol dependent

type: discussion

type: improvement

type: new feature

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#113

No description provided.