LBRYCommunity/lbry-desktop

Fork 0

Shouldn't allow to open multiple export and choose file dialogs #1175

New issue

Closed

opened 2018-03-24 02:31:05 +01:00 by namujan78 · 10 comments

namujan78 commented

2018-03-24 02:31:05 +01:00

(Migrated from github.com)

The Issue

User can open many "Choose file" windows to select files to publish
Same for "Choose directory" in Settings page
Same for "EXPORT" in History page (transaction history) and Overview page

Steps to reproduce

Click on "PUBLISH" button
Click on "CHOOSE FILE" button ==> "Choose file" window will display
Click on "CHOOSE FILE" button again ==> another "Choose file" window will display
Repeat step 3 many time ==> many "Choose file" windows will display

Expected behaviour

User should open only one "Choose file" windows, and it will be in top selection, User cannot focus on the Publish page after selected file success or close the "Choose file" windows

Actual behaviour

User can open many "Choose file" windows by clicking on "Choose file" button.
Same for "Choose directory" in Settings page
Same for "EXPORT" in History page (transaction history)

System Configuration

LBRY Daemon version: 0.19.1
LBRY App version: 0.21.2
LBRY Installation ID: N/A
Operating system: Windows (Windows-10-10.0.16299)
Wallet (lbryum): 3.2.0

Anything Else

Same for "Choose directory" in Settings page
Same for "EXPORT" in History page (transaction history) and Overview page

Screenshots

N/A

## The Issue User can open many "Choose file" windows to select files to publish Same for "Choose directory" in Settings page Same for "EXPORT" in History page (transaction history) and Overview page ### Steps to reproduce 1. Click on "PUBLISH" button 2. Click on "CHOOSE FILE" button ==> "Choose file" window will display 3. Click on "CHOOSE FILE" button again ==> another "Choose file" window will display 4. Repeat step 3 many time ==> many "Choose file" windows will display ### Expected behaviour User should open only one "Choose file" windows, and it will be in top selection, User cannot focus on the Publish page after selected file success or close the "Choose file" windows ### Actual behaviour User can open many "Choose file" windows by clicking on "Choose file" button. Same for "Choose directory" in Settings page Same for "EXPORT" in History page (transaction history) ## System Configuration - LBRY Daemon version: 0.19.1 - LBRY App version: 0.21.2 - LBRY Installation ID: N/A - Operating system: Windows (Windows-10-10.0.16299) - Wallet (lbryum): 3.2.0 ## Anything Else  Same for "Choose directory" in Settings page Same for "EXPORT" in History page (transaction history) and Overview page ## Screenshots  N/A

👍 1

tzarebczan commented

2018-03-26 15:06:02 +02:00

(Migrated from github.com)

@namujan78 thanks for the detailed write-up! I've sent you a tip on Discord :)

👍 1 😆 1

btzr-io commented

2018-06-27 00:33:57 +02:00

(Migrated from github.com)

Fixed and merged in master.

👍 1

namujan78 commented

2018-07-14 12:08:36 +02:00

(Migrated from github.com)

@tzarebczan This issue still happens when you quickly click multiple times on CHOOSE FILE after the PUBLISH screen appeared.
CC @btzr-io

@tzarebczan This issue still happens when you quickly click multiple times on CHOOSE FILE after the PUBLISH screen appeared. CC @btzr-io ![image](https://user-images.githubusercontent.com/37721875/42723471-89758d56-8788-11e8-97e6-14158d74bba0.png)

btzr-io commented

2018-07-14 21:09:37 +02:00

(Migrated from github.com)

I can confirm this is working on linux, not sure about macOS,
Maybe this is a windows-bug ?

I can confirm this is working on `linux`, not sure about `macOS`, Maybe this is a `windows-bug` ?

tzarebczan commented

2018-07-14 21:14:50 +02:00

(Migrated from github.com)

He's clicking it really quickly... I'll try on windows. This is an edge case though, someone won't click like that :)

🎉 1 😆 1

btzr-io commented

2018-07-14 22:56:48 +02:00

(Migrated from github.com)

Clicking really quick freezes the window:
https://github.com/electron/electron/issues/11323

Clicking really quick freezes the window: https://github.com/electron/electron/issues/11323

namujan78 commented

2018-07-15 03:43:15 +02:00

(Migrated from github.com)

It’s not freeze, but the app become slow responsive in some seconds, then back to normal after open multiple choose file windows.

namujan78 commented

2018-07-15 03:57:44 +02:00

(Migrated from github.com)

One more thing, it happen only for first time you go to Publish app.
Next time it doesn’t happen. Maybe the app load complete all components successfull.

One more thing, it happen only for first time you go to Publish app. Next time it doesn’t happen. Maybe the app load complete all components successfull.

neb-b commented

2018-07-16 15:29:10 +02:00

(Migrated from github.com)

It doesn't happen on macOS.

namujan78 commented

2018-09-15 02:35:59 +02:00

(Migrated from github.com)

@tzarebczan How about the status of this issue?
I think we should change the Closed to open/in progress if you still want fix it.
If not we just ignore this case.

Procedure of this case is:

Click on "PUBLISH" button then quickly multi click on "Choose file" when you can see "Choose file" button ==> Multi windows will appear

I don't have macOS so that I cannot confirm it happen or not on macOS. As well as Ubuntu.

CC @btzr-io @seanyesmunt

@tzarebczan How about the status of this issue? I think we should change the Closed to open/in progress if you still want fix it. If not we just ignore this case. **Procedure of this case is:** - Click on "PUBLISH" button then quickly multi click on "Choose file" when you can see "Choose file" button ==> Multi windows will appear I don't have macOS so that I cannot confirm it happen or not on macOS. As well as Ubuntu. CC @btzr-io @seanyesmunt