[redesign] fixes #1194

2018-03-27T23:26:33+02:00

neb-b commented

2018-03-27 23:26:33 +02:00

(Migrated from github.com)

Fixes:

#1204
#1195
screen shot 2018-03-30 at 1 14 01 am

#1205
screen shot 2018-03-30 at 1 13 16 am

#1211
screen shot 2018-03-30 at 1 10 06 am

Changes

Improved backup page styling
screen shot 2018-03-30 at 1 19 27 am

#### Fixes: #1204 #1195 <img width="400" alt="screen shot 2018-03-30 at 1 14 01 am" src="https://user-images.githubusercontent.com/16882830/38125469-a7e2fe06-33b7-11e8-9ebe-fcf36aa8af49.png"> #1205 <img width="400" alt="screen shot 2018-03-30 at 1 13 16 am" src="https://user-images.githubusercontent.com/16882830/38125459-9447b1a2-33b7-11e8-8786-59e22b4c6e9c.png"> #1211 <img width="400" alt="screen shot 2018-03-30 at 1 10 06 am" src="https://user-images.githubusercontent.com/16882830/38125412-3fba690e-33b7-11e8-9450-7505218505e6.png"> #### Changes Improved backup page styling <img width="400" alt="screen shot 2018-03-30 at 1 19 27 am" src="https://user-images.githubusercontent.com/16882830/38125573-6a3589ec-33b8-11e8-905b-e9bd3a20989d.png">

neb-b (Migrated from github.com) reviewed 2018-03-30 02:53:41 +02:00

.eslintrc.json

					
				@ -36,2 +36,3 @@

				    "func-names": ["warn", "as-needed"]

				    "func-names": ["warn", "as-needed"],

				    "jsx-a11y/label-has-for": 0

				  }

neb-b (Migrated from github.com) commented

2018-03-30 02:53:40 +02:00

This was throwing linting errors even though we are properly handling this. I will keep an eye out for it, but we should be ok since all inputs should use the FormField component which has labels.

This was throwing linting errors even though we are properly handling this. I will keep an eye out for it, but we should be ok since all inputs should use the `FormField` component which has labels.

liamcardenas (Migrated from github.com) reviewed 2018-03-30 17:20:21 +02:00

src/renderer/scss/component/_card.scss

liamcardenas (Migrated from github.com) commented

2018-03-30 17:20:20 +02:00

-12 - 20 = -32, not -31. Was this intentional?

liamcardenas (Migrated from github.com) approved these changes 2018-03-30 17:21:23 +02:00

liamcardenas (Migrated from github.com) left a comment

looks good (with 1 comment)

neb-b (Migrated from github.com) reviewed 2018-03-30 18:32:02 +02:00

src/renderer/scss/component/_card.scss

neb-b (Migrated from github.com) commented

2018-03-30 18:32:02 +02:00

Yeah it was a little off

ykris45 commented

2018-03-30 19:51:27 +02:00

(Migrated from github.com)

@seanyesmunt are my referenced pr integrated

neb-b commented

2018-03-30 20:02:48 +02:00

(Migrated from github.com)

Yep! It is in the master branch.

On Fri, Mar 30, 2018, 1:51 PM YULIUS KURNIAWAN KRISTIANTO <
notifications@github.com> wrote:

@seanyesmunt https://github.com/seanyesmunt are my referenced pr
integrated

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/lbryio/lbry-app/pull/1194#issuecomment-377581693, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AQGcjqT4bUVp-ff5JLGuG04Los6qrcbWks5tjnCggaJpZM4S9qlS
.

Yep! It is in the master branch. On Fri, Mar 30, 2018, 1:51 PM YULIUS KURNIAWAN KRISTIANTO < notifications@github.com> wrote: > @seanyesmunt <https://github.com/seanyesmunt> are my referenced pr > integrated > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/lbryio/lbry-app/pull/1194#issuecomment-377581693>, or mute > the thread > <https://github.com/notifications/unsubscribe-auth/AQGcjqT4bUVp-ff5JLGuG04Los6qrcbWks5tjnCggaJpZM4S9qlS> > . >

Sign in to join this conversation.

No reviewers

liamcardenas