LBRYCommunity/lbry-desktop

Make FileTile resolve URIs (fixes exact search matching) #120

Merged

6ea86b96 merged 2 commits from redux into redux

2017-05-09 22:13:24 +02:00

6ea86b96 commented

2017-05-09 08:40:23 +02:00

(Migrated from github.com)

Fixes exact search matching and search results HTML @kauffj.

I have no idea why default thumbnails aren't resolving any more or when that stopped working :(

I think in order for this to be mergable to master we need to:

fix default thumbnails
store file info in the state by sd_hash rather than URI and then fix the downloaded/published pages (right now published appear in downloaded after you loaded both and it starts throwing errors)
do a test run to make sure rewards is still working

We'd need to then lookup files by first selecting the claim for a URI, then running a selector that iterates all files in the state and grabs the one with the matching outpoint. It seems to make sense to store files by sd_hash though, as claim and outpoint can sometimes be null, in the case of files that are being uploaded or failed to upload for example.

Fixes exact search matching and search results HTML @kauffj. I have no idea why default thumbnails aren't resolving any more or when that stopped working :( I think in order for this to be mergable to master we need to: - fix default thumbnails - store file info in the state by `sd_hash` rather than URI and then fix the downloaded/published pages (right now published appear in downloaded after you loaded both and it starts throwing errors) - do a test run to make sure rewards is still working We'd need to then lookup files by first selecting the claim for a URI, then running a selector that iterates all files in the state and grabs the one with the matching outpoint. It seems to make sense to store files by `sd_hash` though, as claim and outpoint can sometimes be `null`, in the case of files that are being uploaded or failed to upload for example.

Sign in to join this conversation.

No reviewers

No labels

area: discovery

area: installer

area: livestream

area: performance

area: subscriptions

feature request

first-timers-only

good first issue

merge when green

needs: exploration

needs: grooming

needs: priority

needs: tech design

priority: blocker

priority: medium

protocol dependent

type: discussion

type: improvement

type: new feature

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#120

No description provided.