feat: add keyboard shortcut to quit the app on Windows #1202

Merged
ykris45 merged 11 commits from patch-1 into master 2018-03-30 20:37:31 +02:00
ykris45 commented 2018-03-28 23:10:20 +02:00 (Migrated from github.com)

based on @IGassmann comment to my PR earlier ,

based on @IGassmann comment to my PR earlier ,
ykris45 commented 2018-03-28 23:42:31 +02:00 (Migrated from github.com)

image
image
when i press ctrl+q app closed

![image](https://user-images.githubusercontent.com/26609573/38057972-63290636-330b-11e8-841b-eba98ad63b46.png) ![image](https://user-images.githubusercontent.com/26609573/38057985-71fbf3b2-330b-11e8-90bc-331fb3d34cd1.png) when i press ctrl+q app closed
IGassmann commented 2018-03-29 00:09:33 +02:00 (Migrated from github.com)

@ykris45, Please format your code with Prettier: https://github.com/lbryio/lbry-app/blob/master/CONTRIBUTING.md#code-formatting

Also, I would recommend you to use a text editor and not a word processor like WordPad to develop. A simple to use and a good one is: https://code.visualstudio.com/

@ykris45, Please format your code with Prettier: https://github.com/lbryio/lbry-app/blob/master/CONTRIBUTING.md#code-formatting Also, I would recommend you to use a text editor and not a word processor like WordPad to develop. A simple to use and a good one is: https://code.visualstudio.com/
ykris45 commented 2018-03-29 00:24:25 +02:00 (Migrated from github.com)

@IGassmann that is correct bro
image

@IGassmann that is correct bro ![image](https://user-images.githubusercontent.com/26609573/38059640-6690b11a-3311-11e8-85bd-18584fc6bfd4.png)
ykris45 commented 2018-03-29 00:34:10 +02:00 (Migrated from github.com)

or i use VS Code Prettier Formatter guys

or i use VS Code Prettier Formatter guys
ykris45 commented 2018-03-29 00:53:40 +02:00 (Migrated from github.com)

i fixed link to this pr on changelog

i fixed link to this pr on changelog
ykris45 commented 2018-03-29 15:30:23 +02:00 (Migrated from github.com)

@tzarebczan done sir

@tzarebczan done sir
IGassmann (Migrated from github.com) requested changes 2018-03-30 17:28:19 +02:00
IGassmann (Migrated from github.com) commented 2018-03-30 17:25:20 +02:00

Please rename this as "Add keyboard shortcut to quit the app on Windows" under an unreleased section and not under "Fix".

Please rename this as "Add keyboard shortcut to quit the app on Windows" under an unreleased section and not under "Fix".
IGassmann (Migrated from github.com) commented 2018-03-30 17:28:02 +02:00

This shouldn't be under the help menu. Add it to a new submenu "File".

This shouldn't be under the help menu. Add it to a new submenu "File".
IGassmann (Migrated from github.com) commented 2018-03-30 17:28:12 +02:00

Remove the label "Close" as it should be automatically specified by the role.

Remove the label "Close" as it should be automatically specified by the role.
ykris45 (Migrated from github.com) reviewed 2018-03-30 18:16:02 +02:00
ykris45 (Migrated from github.com) commented 2018-03-30 18:16:02 +02:00

@IGassmann i cannot see where a unreleased section

@IGassmann i cannot see where a unreleased section
IGassmann (Migrated from github.com) reviewed 2018-03-30 18:16:37 +02:00
IGassmann (Migrated from github.com) commented 2018-03-30 18:16:37 +02:00

You have to add one.

You have to add one.
ykris45 (Migrated from github.com) reviewed 2018-03-30 18:21:43 +02:00
ykris45 (Migrated from github.com) commented 2018-03-30 18:21:43 +02:00

image
@IGassmann like this guys

![image](https://user-images.githubusercontent.com/26609573/38144917-10ac8dda-3471-11e8-82c1-7f0f67c5a7db.png) @IGassmann like this guys
ykris45 (Migrated from github.com) reviewed 2018-03-30 18:29:38 +02:00
ykris45 (Migrated from github.com) commented 2018-03-30 18:29:38 +02:00

572d68d880 done

https://github.com/lbryio/lbry-app/pull/1202/commits/572d68d880d2d216d74df66662600e59d439a54e done
IGassmann (Migrated from github.com) reviewed 2018-03-30 18:35:53 +02:00
IGassmann (Migrated from github.com) commented 2018-03-30 18:35:53 +02:00

It also needs to be under an Added subsection. Also, notice that the pull request number doesn't match the link number.

It also needs to be under an Added subsection. Also, notice that the pull request number doesn't match the link number.
ykris45 commented 2018-03-30 18:50:35 +02:00 (Migrated from github.com)

i think this mission completed

i think this mission completed
IGassmann (Migrated from github.com) reviewed 2018-03-30 18:52:57 +02:00
IGassmann (Migrated from github.com) commented 2018-03-30 18:52:57 +02:00

This has to be under a submenu called ”File" and not the window one.

This has to be under a submenu called ”File" and not the window one.
ykris45 (Migrated from github.com) reviewed 2018-03-30 19:16:29 +02:00
ykris45 (Migrated from github.com) commented 2018-03-30 19:16:29 +02:00

@IGassmann like this guys
{
role: 'file',
submenu: [{ role: 'quit', accelerator: 'CmdOrCtrl+Q' }],
},

@IGassmann like this guys { role: 'file', submenu: [{ role: 'quit', accelerator: 'CmdOrCtrl+Q' }], },
ykris45 (Migrated from github.com) reviewed 2018-03-30 19:50:20 +02:00
ykris45 (Migrated from github.com) commented 2018-03-30 19:50:20 +02:00

or do you mean submenu label : 'file'

or do you mean submenu label : 'file'
ykris45 commented 2018-03-30 20:15:30 +02:00 (Migrated from github.com)

image
LGTM @tzarebczan ...

![image](https://user-images.githubusercontent.com/26609573/38148476-e6385254-3480-11e8-9a0d-ea8a09a3269a.png) LGTM @tzarebczan ...
IGassmann (Migrated from github.com) reviewed 2018-03-30 20:20:25 +02:00
IGassmann (Migrated from github.com) commented 2018-03-30 20:20:25 +02:00

Please remove this line.

Please remove this line.
IGassmann (Migrated from github.com) approved these changes 2018-03-30 20:24:44 +02:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#1202
No description provided.