feat: add keyboard shortcut to quit the app on Windows #1202
No reviewers
Labels
No labels
accessibility
app-parity
area: creator
area: daemon
area: design
area: devops
area: discovery
area: docs
area: installer
area: internal
area: livestream
area: performance
area: proposal
area: reposts
area: rewards
area: search
area: security
area: subscriptions
area: sync
area: ux
area: viewer
area: wallet
BEAMER
channel
comments
community PR
consider soon
core team
css
dependencies
electron
Epic
feature request
first-timers-only
good first issue
hacktoberfest
help wanted
hub-dependent
icebox
Invalid
level: 0
level: 1
level: 2
level: 3
level: 4
merge when green
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
notifications
odysee
on hold
playlists
priority: blocker
priority: high
priority: low
priority: medium
protocol dependent
recsys
redesign
regression
resilience
sdk dependent
Tom's Wishlist
trending
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
windows
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: LBRYCommunity/lbry-desktop#1202
Loading…
Reference in a new issue
No description provided.
Delete branch "patch-1"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
based on @IGassmann comment to my PR earlier ,
when i press ctrl+q app closed
@ykris45, Please format your code with Prettier: https://github.com/lbryio/lbry-app/blob/master/CONTRIBUTING.md#code-formatting
Also, I would recommend you to use a text editor and not a word processor like WordPad to develop. A simple to use and a good one is: https://code.visualstudio.com/
@IGassmann that is correct bro
or i use VS Code Prettier Formatter guys
i fixed link to this pr on changelog
@tzarebczan done sir
Please rename this as "Add keyboard shortcut to quit the app on Windows" under an unreleased section and not under "Fix".
This shouldn't be under the help menu. Add it to a new submenu "File".
Remove the label "Close" as it should be automatically specified by the role.
@IGassmann i cannot see where a unreleased section
You have to add one.
@IGassmann like this guys
572d68d880
doneIt also needs to be under an Added subsection. Also, notice that the pull request number doesn't match the link number.
i think this mission completed
This has to be under a submenu called ”File" and not the window one.
@IGassmann like this guys
{
role: 'file',
submenu: [{ role: 'quit', accelerator: 'CmdOrCtrl+Q' }],
},
or do you mean submenu label : 'file'
LGTM @tzarebczan ...
Please remove this line.