Share speech URLs on File and Channel pages #1222
No reviewers
Labels
No labels
accessibility
app-parity
area: creator
area: daemon
area: design
area: devops
area: discovery
area: docs
area: installer
area: internal
area: livestream
area: performance
area: proposal
area: reposts
area: rewards
area: search
area: security
area: subscriptions
area: sync
area: ux
area: viewer
area: wallet
BEAMER
channel
comments
community PR
consider soon
core team
css
dependencies
electron
Epic
feature request
first-timers-only
good first issue
hacktoberfest
help wanted
hub-dependent
icebox
Invalid
level: 0
level: 1
level: 2
level: 3
level: 4
merge when green
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
notifications
odysee
on hold
playlists
priority: blocker
priority: high
priority: low
priority: medium
protocol dependent
recsys
redesign
regression
resilience
sdk dependent
Tom's Wishlist
trending
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
windows
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: LBRYCommunity/lbry-desktop#1222
Loading…
Reference in a new issue
No description provided.
Delete branch "share-speech-urls"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
New PR for #1028 @tzarebczan @liamcardenas
This creates
<ViewOnWebButton>
with aGLOBE
icon and uses it on<FilePage>
and<ChannelPage>
Also fixes ~10 eslint errors
Tested and looks good.
@ -14,6 +14,8 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/).
* Pre-fill publish URL after clicking "Put something here" link ([#1303](https://github.com/lbryio/lbry-app/pull/1303))
* Add Danger JS to automate code reviews ([#1289](https://github.com/lbryio/lbry-app/pull/1289))
you request seems to be intertwined with another one somehow. Can you please figure out how to take out these pagination related changes?
I assume this is from the pagination PR?
does
free
need to be its own variable?have you run
yarn format
?I meant to request changes
I did, and it did not change anything
I am not sure what's going on with this conflict in
src/renderer/scss/component/_form-field.scss
What Github tells me is a problem on lines 54-58 is not a problem locally
Can you rebase and get this up to date?
@seanyesmunt Tired of adding buttons to the show page yet? haha Wonder how this fits in with your changes to file actions. I'll try to give it a whirl today.
This is awesome. I think the button placement is fine.