Share speech URLs on File and Channel pages #1222

Merged
daovist merged 2 commits from share-speech-urls into master 2018-05-30 04:42:49 +02:00
daovist commented 2018-03-30 18:44:43 +02:00 (Migrated from github.com)

New PR for #1028 @tzarebczan @liamcardenas

This creates <ViewOnWebButton> with a GLOBE icon and uses it on <FilePage> and <ChannelPage>

Also fixes ~10 eslint errors

New PR for #1028 @tzarebczan @liamcardenas This creates `<ViewOnWebButton>` with a `GLOBE` icon and uses it on `<FilePage>` and `<ChannelPage>` Also fixes ~10 eslint errors
liamcardenas (Migrated from github.com) approved these changes 2018-03-30 21:23:34 +02:00
liamcardenas (Migrated from github.com) left a comment

Tested and looks good.

Tested and looks good.
@ -14,6 +14,8 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/).
* Pre-fill publish URL after clicking "Put something here" link ([#1303](https://github.com/lbryio/lbry-app/pull/1303))
* Add Danger JS to automate code reviews ([#1289](https://github.com/lbryio/lbry-app/pull/1289))
liamcardenas (Migrated from github.com) commented 2018-03-30 21:09:58 +02:00

you request seems to be intertwined with another one somehow. Can you please figure out how to take out these pagination related changes?

you request seems to be intertwined with another one somehow. Can you please figure out how to take out these pagination related changes?
liamcardenas (Migrated from github.com) commented 2018-03-30 21:10:28 +02:00

I assume this is from the pagination PR?

I assume this is from the pagination PR?
liamcardenas (Migrated from github.com) commented 2018-03-30 21:13:51 +02:00

does free need to be its own variable?

does `free` need to be its own variable?
liamcardenas (Migrated from github.com) commented 2018-03-30 21:12:27 +02:00

have you run yarn format?

have you run `yarn format`?
liamcardenas (Migrated from github.com) requested changes 2018-03-30 21:23:57 +02:00
liamcardenas (Migrated from github.com) left a comment

I meant to request changes

I meant to request changes
daovist (Migrated from github.com) reviewed 2018-03-30 21:48:38 +02:00
daovist (Migrated from github.com) commented 2018-03-30 21:48:38 +02:00

I did, and it did not change anything

I did, and it did not change anything
daovist commented 2018-03-30 21:53:10 +02:00 (Migrated from github.com)

I am not sure what's going on with this conflict in src/renderer/scss/component/_form-field.scss

What Github tells me is a problem on lines 54-58 is not a problem locally

I am not sure what's going on with this conflict in `src/renderer/scss/component/_form-field.scss` What Github tells me is a problem on lines 54-58 is not a problem locally
neb-b commented 2018-05-11 04:13:23 +02:00 (Migrated from github.com)

Can you rebase and get this up to date?

Can you rebase and get this up to date?
tzarebczan commented 2018-05-29 15:46:37 +02:00 (Migrated from github.com)

@seanyesmunt Tired of adding buttons to the show page yet? haha Wonder how this fits in with your changes to file actions. I'll try to give it a whirl today.

@seanyesmunt Tired of adding buttons to the show page yet? haha Wonder how this fits in with your changes to file actions. I'll try to give it a whirl today.
neb-b (Migrated from github.com) approved these changes 2018-05-30 04:42:40 +02:00
neb-b (Migrated from github.com) left a comment

This is awesome. I think the button placement is fine.

This is awesome. I think the button placement is fine.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#1222
No description provided.