LBRYCommunity/lbry-desktop

Obscure NSFW content title #1233

Merged

miikkatu merged 1 commit from obscure-nsfw-content-title into master

2018-04-10 22:14:17 +02:00

miikkatu commented

2018-04-01 12:36:15 +02:00

(Migrated from github.com)

If NSFW content is not enabled in settings, thumbnails for NSFW content are obscured, but the file titles are not. This change hides the title information, so no (likely) NSFW text (in the title or username) is shown either. The implementation before redesign actually blurred both the image and the text.

It looks like this now:

screen shot 2018-04-01 at 13 33 56

If NSFW content is not enabled in settings, thumbnails for NSFW content are obscured, but the file titles are not. This change hides the title information, so no (likely) NSFW text (in the title or username) is shown either. The implementation before redesign actually blurred both the image and the text. It looks like this now: <img width="679" alt="screen shot 2018-04-01 at 13 33 56" src="https://user-images.githubusercontent.com/16205520/38172244-60bf3840-35b1-11e8-82fc-456329ea4018.png">

QuirkyRobots commented

2018-04-01 13:18:07 +02:00

(Migrated from github.com)

Personally, I think all NSFW content should be omitted from the home screen is disabled, rather than having a home screen full of pointless blurred spaces.

Personally, I think all **NSFW** content should be **omitted** from the home screen is disabled, rather than having a home screen full of pointless blurred spaces.

neb-b commented

2018-04-02 06:26:23 +02:00

(Migrated from github.com)

@Smurphonomics I agree. I'm pretty sure there is an issue to add an additonal setting which would remove NSFW content from the app.

There will be two settings (worded better than what I have):

Obscure NSFW files
Hide all NSFW content

Maybe instead of hiding the title all together, we can show a message? Saying this is hidden because you have a setting checked.

Also should we hide the channel name too?

@liamcardenas @tzarebczan @kauffj

@Smurphonomics I agree. I'm pretty sure there is an issue to add an additonal setting which would remove NSFW content from the app. There will be two settings (worded better than what I have): - Obscure NSFW files - Hide all NSFW content Maybe instead of hiding the title all together, we can show a message? Saying this is hidden because you have a setting checked. Also should we hide the channel name too? @liamcardenas @tzarebczan @kauffj

neb-b commented

2018-04-02 06:28:12 +02:00

(Migrated from github.com)

I am very much in favor of allowing you to navigate to the file page and showing the full title there (still obscuring the thumbnail). I do not like how you have to turn off the setting to view NSFW content.

I am very much in favor of allowing you to navigate to the file page and showing the full title there (still obscuring the thumbnail). I do not like how you have to turn off the setting to view NSFW content.

kauffj commented

2018-04-02 15:23:09 +02:00

(Migrated from github.com)

Great ideas @seanyesmunt and @Smurphonomics !

Some thoughts:

I prefer to not to add additional settings until it's clear that it's necessary.
I like the idea of the NSFW filter hiding items entirely. The main reason it doesn't already is because we wanted people to know they were there. Particularly new users who might want to change the setting.
Maybe hide them and put a small message at the bottom like "x pieces of content are hidden due to your content filters" that links to settings.
I like the idea of showing the titles but blurring the images, however, this also poses risks. We can all imagine some titles that would be offensive even without the images...

Great ideas @seanyesmunt and @Smurphonomics ! Some thoughts: 1. I prefer to not to add additional settings until it's clear that it's necessary. 2. I like the idea of the NSFW filter hiding items entirely. The main reason it doesn't already is because we wanted people to know they were there. Particularly new users who might want to change the setting. 3. Maybe hide them and put a small message at the bottom like "x pieces of content are hidden due to your content filters" that links to settings. 4. I like the idea of showing the titles but blurring the images, however, this also poses risks. We can all imagine some titles that would be offensive even without the images...

miikkatu commented

2018-04-02 15:36:01 +02:00

(Migrated from github.com)

@kauffj Yes, the point 4. was why I made this PR. If only to prevent this happening while a more permanent solution is implemented.

@kauffj Yes, the point 4. was why I made this PR. If only to prevent this happening while a more permanent solution is implemented.

kauffj commented

2018-04-02 16:03:51 +02:00

(Migrated from github.com)

@miikkatu Ah, I'm a bit slow sometimes (actually I was racing through email and should have taken longer to get the full context). Good and thoughtful change!

@miikkatu Ah, I'm a bit slow sometimes (actually I was racing through email and should have taken longer to get the full context). Good and thoughtful change!

tzarebczan commented

2018-04-02 16:06:37 +02:00

(Migrated from github.com)

@seanyesmunt I like how it was done in the previous version of the app - I believe the channel name + entire card was blurred which alerted the user and gave them an option to go into settings.

What do we want to go forward with in the redesign release?

@seanyesmunt I like how it was done in the previous version of the app - I believe the channel name + entire card was blurred which alerted the user and gave them an option to go into settings. What do we want to go forward with in the redesign release?

neb-b commented

2018-04-02 18:21:52 +02:00

(Migrated from github.com)

Lets hide the channel name and title, and show a message:

"This content is obscured because it is NSFW. You can change this in your settings"

There is probably a better way to word that.

Lets hide the channel name and title, and show a message: "This content is obscured because it is NSFW. You can change this in your settings" There is probably a better way to word that.

miikkatu commented

2018-04-03 12:22:30 +02:00

(Migrated from github.com)

@seanyesmunt Your wording sounds good to me. I updated the code, and it looks like this now:

screen shot 2018-04-03 at 13 18 27

@seanyesmunt Your wording sounds good to me. I updated the code, and it looks like this now: <img width="881" alt="screen shot 2018-04-03 at 13 18 27" src="https://user-images.githubusercontent.com/16205520/38244039-005b9f56-3742-11e8-96ad-bea829d36468.png">

tzarebczan commented

2018-04-03 15:29:22 +02:00

(Migrated from github.com)

@miikkatu can we make "settings" a link to the settings area? Make it a different color so it stands out a bit.
Previous version for reference:

@miikkatu can we make "settings" a link to the settings area? Make it a different color so it stands out a bit. Previous version for reference: ![nsfw](https://user-images.githubusercontent.com/8120721/38252170-7ad00fea-3721-11e8-91dc-18d04952b278.png)

miikkatu commented

2018-04-03 20:30:23 +02:00

(Migrated from github.com)

@tzarebczan Yes we can 🙂

Updated screenshot:

screen shot 2018-04-03 at 21 21 53

@tzarebczan Yes we can 🙂 Updated screenshot: <img width="686" alt="screen shot 2018-04-03 at 21 21 53" src="https://user-images.githubusercontent.com/16205520/38268119-fc27b426-3785-11e8-9bbf-6ab3a91d02be.png">

tzarebczan commented

2018-04-04 02:21:40 +02:00

(Migrated from github.com)

@miikkatu thanks, awesome! The only suggestion I'd make is regarding mentioning NSFW without spelling it out somewhere first. Not all users will know what NSFW means. The original wording might be better. @seanyesmunt do you agree or have a better one?

@miikkatu thanks, awesome! The only suggestion I'd make is regarding mentioning NSFW without spelling it out somewhere first. Not all users will know what NSFW means. The original wording might be better. @seanyesmunt do you agree or have a better one?

ghost commented

2018-04-08 15:50:52 +02:00

(Migrated from github.com)

How about having a separate NSFW tab?

When clicking the NSFW tab everything is blurred with a message saying that it can be enabled in the settings, maybe the settings can even have an option to hide the NSFW tab altogether with an option to put a password on re-enabling it.

Now the homepage is completely family friendly, in fact, the whole app is family friendly. The NSFW tab can have separate discover, trending, top bids etc.

I think this solution is beneficial for both those who are interested in NSFW and those who are not.

How about having a separate NSFW tab? When clicking the NSFW tab everything is blurred with a message saying that it can be enabled in the settings, maybe the settings can even have an option to hide the NSFW tab altogether with an option to put a password on re-enabling it. Now the homepage is completely family friendly, in fact, the whole app is family friendly. The NSFW tab can have separate discover, trending, top bids etc. I think this solution is beneficial for both those who are interested in NSFW and those who are not.

tzarebczan commented

2018-04-08 15:55:26 +02:00

(Migrated from github.com)

@m160 not the right place to discuss, but we'll enable something similar to that down the road where users will need to opt into certain types of content. For now, this behavior is staying as such.

@m160 not the right place to discuss, but we'll enable something similar to that down the road where users will need to opt into certain types of content. For now, this behavior is staying as such.

miikkatu commented

2018-04-10 13:29:59 +02:00

(Migrated from github.com)

@tzarebczan Should we go with the original wording then?

@tzarebczan Should we go with the original wording then?

neb-b commented

2018-04-10 22:13:13 +02:00

(Migrated from github.com)

@miikkatu I think the original wording is fine for now. There is a better description in the settings page.

@miikkatu I think the original wording is fine for now. There is a better description in the settings page.

neb-b (Migrated from github.com) approved these changes 2018-04-10 22:14:09 +02:00

Sign in to join this conversation.

No reviewers

No labels

area: discovery

area: installer

area: livestream

area: performance

area: subscriptions

feature request

first-timers-only

good first issue

merge when green

needs: exploration

needs: grooming

needs: priority

needs: tech design

priority: blocker

priority: medium

protocol dependent

type: discussion

type: improvement

type: new feature

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#1233

No description provided.