LBRYCommunity/lbry-desktop

Unset form field input height to make it scale #1234

Merged

miikkatu merged 1 commit from unfix-form-field-input-height into master

2018-04-02 20:56:01 +02:00

miikkatu commented

2018-04-01 12:50:14 +02:00

(Migrated from github.com)

This would close #1228.

The problem is that the input div height was fixed to 36px, which prevented it to wrap the containing text to additional lines. This simple change enables wrapping in practice.

It looks like this:

screen shot 2018-04-01 at 13 49 17

This would close #1228. The problem is that the input div height was fixed to 36px, which prevented it to wrap the containing text to additional lines. This simple change enables wrapping in practice. It looks like this: <img width="698" alt="screen shot 2018-04-01 at 13 49 17" src="https://user-images.githubusercontent.com/16205520/38172351-84024b88-35b3-11e8-986e-272da73402fc.png">

neb-b commented

2018-04-02 06:21:44 +02:00

(Migrated from github.com)

Looks like some of the inputs are misaligned with this. (It's still better than before) I think there is a padding on the radio/checkbox that maybe isn't needed after removing the height?

Looks like some of the inputs are misaligned with this. (It's still better than before) I think there is a padding on the radio/checkbox that maybe isn't needed after removing the height?

miikkatu commented

2018-04-02 11:53:43 +02:00

(Migrated from github.com)

That's right, the alignment of some labels and checkboxes or radio buttons was a bit off. A common margin setting didn't help, so I tweaked them separately.

That's right, the alignment of some labels and checkboxes or radio buttons was a bit off. A common margin setting didn't help, so I tweaked them separately.

tzarebczan commented

2018-04-03 15:06:04 +02:00

(Migrated from github.com)

Thanks for your contribution @miikkatu ! Got your email for the tip, will review and follow up.

Thanks for your contribution @miikkatu ! Got your email for the tip, will review and follow up.

Sign in to join this conversation.

No reviewers

No labels

area: discovery

area: installer

area: livestream

area: performance

area: subscriptions

feature request

first-timers-only

good first issue

merge when green

needs: exploration

needs: grooming

needs: priority

needs: tech design

priority: blocker

priority: medium

protocol dependent

type: discussion

type: improvement

type: new feature

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#1234

No description provided.