Convert all remaining old-style components to ES6 classes (WIP) #125

Merged
alexliebowitz merged 2 commits from es6-classes into redux 2017-05-19 15:18:14 +02:00
alexliebowitz commented 2017-05-17 10:12:36 +02:00 (Migrated from github.com)

Close to done. There are probably still a few callbacks that need to be wrapped in arrow functions.

Close to done. There are probably still a few callbacks that need to be wrapped in arrow functions.
kauffj (Migrated from github.com) reviewed 2017-05-17 10:12:36 +02:00
6ea86b96 commented 2017-05-17 17:36:15 +02:00 (Migrated from github.com)

@alexliebowitz there's a huge refactoring already in https://github.com/lbryio/lbry-app/tree/redux where, among other things, everything has been switched to ES6 classes.

@alexliebowitz there's a huge refactoring already in https://github.com/lbryio/lbry-app/tree/redux where, among other things, everything has been switched to ES6 classes.
alexliebowitz commented 2017-05-17 17:53:55 +02:00 (Migrated from github.com)

I'm in the loop about the Redux branch and I've been coordinating with Jeremy to make sure we don't duplicate effort. This PR is actually on top of the Redux branch, which does have a lot of components that still hadn't been converted yet (e.g. Publish page).

I'm in the loop about the Redux branch and I've been coordinating with Jeremy to make sure we don't duplicate effort. This PR is actually on top of the Redux branch, which does have a lot of components that still hadn't been converted yet (e.g. [Publish page](https://github.com/lbryio/lbry-app/blob/redux/ui/js/page/publish/view.jsx)).
6ea86b96 commented 2017-05-17 18:04:47 +02:00 (Migrated from github.com)

ah, ok, all good then :)

ah, ok, all good then :)
kauffj commented 2017-05-19 15:13:28 +02:00 (Migrated from github.com)

Even though this is marked WIP, I'm going to merge this now since it'll only diverge further.

Even though this is marked WIP, I'm going to merge this now since it'll only diverge further.
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#125
No description provided.