Channel page claim caching / other optimizations #1255

Closed
opened 2018-04-03 00:30:45 +02:00 by tzarebczan · 2 comments
tzarebczan commented 2018-04-03 00:30:45 +02:00 (Migrated from github.com)

The Issue

When you go into a channel page likelbry://@lumbridgecity, the page starts fetching content which takes a bit of time. If you enter a claim or go to another page, and then go back, it re-fetches content again making this a slow process. We should try to add some type of caching to reduce the subsequent load times. Have to take into account new/updated claims as well.

Update: The current process also runs claim_list_by_channel on the first page which returns all the claim data. It then proceeds to run a resolve on each of the claims (if they have not been visited in the current session). The resolve should not be needed as the prior call has all claim data returned. If we do need to run a resolve, we should batch it.

Expected Behaviour

Faster subsequent load times

Actual Behaviour

Reload every page as if it were the first time seeing it

Suggested Solutions

Employ caching strategy

System Configuration

  • LBRY Daemon version:
  • LBRY App version:
  • LBRY Installation ID:
  • Operating system:

Anything Else

Screenshots

<!-- Thanks for reporting an issue to LBRY and helping us improve! To make it possible for us to help you, please fill out below information carefully. Before reporting any issues, please make sure that you're using the latest version. - App releases: https://github.com/lbryio/lbry-app/releases - Standalone daemon: https://github.com/lbryio/lbry/releases We are also available on live chat at https://chat.lbry.io --> ## The Issue When you go into a channel page likelbry://@lumbridgecity, the page starts fetching content which takes a bit of time. If you enter a claim or go to another page, and then go back, it re-fetches content again making this a slow process. We should try to add some type of caching to reduce the subsequent load times. Have to take into account new/updated claims as well. Update: The current process also runs claim_list_by_channel on the first page which returns all the claim data. It then proceeds to run a resolve on each of the claims (if they have not been visited in the current session). The resolve should not be needed as the prior call has all claim data returned. If we do need to run a resolve, we should batch it. ### Expected Behaviour Faster subsequent load times ### Actual Behaviour Reload every page as if it were the first time seeing it ### Suggested Solutions Employ caching strategy ## System Configuration <!-- For the app, this info is in the About section at the bottom of the Help page. You can include a screenshot instead of typing it out --> <!-- For the daemon, run: curl 'http://localhost:5279' --data '{"method":"version"}' and include the full output --> - LBRY Daemon version: - LBRY App version: - LBRY Installation ID: - Operating system: ## Anything Else <!-- Include anything else that does not fit into the above sections --> ## Screenshots <!-- If a screenshot would help explain the bug, please include one or two here -->
tzarebczan commented 2018-07-17 16:26:12 +02:00 (Migrated from github.com)

Reopening to address the last issue (cc: @daovist )
The current process also runs claim_list_by_channel on the first page which returns all the claim data. It then proceeds to run a resolve on each of the claims (if they have not been visited in the current session). The resolve should not be needed as the prior call has all claim data returned. If we do need to run a resolve, we should batch it.

Reopening to address the last issue (cc: @daovist ) The current process also runs claim_list_by_channel on the first page which returns all the claim data. It then proceeds to run a resolve on each of the claims (if they have not been visited in the current session). The resolve should not be needed as the prior call has all claim data returned. If we do need to run a resolve, we should batch it.
tzarebczan commented 2018-07-23 21:02:03 +02:00 (Migrated from github.com)
Closed by https://github.com/lbryio/lbry-redux/pull/60
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
LBRYCommunity/lbry-desktop#1255
No description provided.