Paginated search results #1261

New issue

Closed

opened 2018-04-03 07:29:27 +02:00 by jsigwart · 7 comments

jsigwart commented

2018-04-03 07:29:27 +02:00

(Migrated from github.com)

The Issue

Any search returns exactly 10 results. I would like to have the ability to see more than 10 results, and for the results to be paginated with navigation to move forward and backwards through the pages of results.

System Configuration

LBRY Daemon version: 0.19.1
LBRY App version: 0.21.2
LBRY Installation ID: 5eFxsAfhBFTKA5byNFVkGL5Lu5owWzQFthzKjRkxN2iUzWh2XNKLJAiv82mxAcq3AU
Operating system: Mac OS X 15.6.0

{
"id": null,
"jsonrpc": "2.0",
"result": {
"build": "release",
"ip": "xx.xx.xx.xx",
"lbrynet_version": "0.19.1",
"lbryschema_version": "0.0.15",
"lbryum_version": "3.2.0",
"os_release": "15.6.0",
"os_system": "Darwin",
"platform": "Darwin-15.6.0-x86_64-i386-64bit",
"processor": "i386",
"python_version": "2.7.13"
}
}

## The Issue Any search returns exactly 10 results. I would like to have the ability to see more than 10 results, and for the results to be paginated with navigation to move forward and backwards through the pages of results. ## System Configuration   - LBRY Daemon version: 0.19.1 - LBRY App version: 0.21.2 - LBRY Installation ID: 5eFxsAfhBFTKA5byNFVkGL5Lu5owWzQFthzKjRkxN2iUzWh2XNKLJAiv82mxAcq3AU - Operating system: Mac OS X 15.6.0 { "id": null, "jsonrpc": "2.0", "result": { "build": "release", "ip": "xx.xx.xx.xx", "lbrynet_version": "0.19.1", "lbryschema_version": "0.0.15", "lbryum_version": "3.2.0", "os_release": "15.6.0", "os_system": "Darwin", "platform": "Darwin-15.6.0-x86_64-i386-64bit", "processor": "i386", "python_version": "2.7.13" } }

kauffj commented

2018-04-03 16:08:18 +02:00

(Migrated from github.com)

Did we lose this feature? It used to page

tzarebczan commented

2018-04-03 17:40:07 +02:00

(Migrated from github.com)

I don't think we ever showed more than 10 results on search. This is something @seanyesmunt is aware of .

👍 1

tiger5226 commented

2018-04-27 02:22:44 +02:00

(Migrated from github.com)

The search api does support pagination and custom sized results.

https://lighthouse.lbry.io/search?s=bitcoin&size=100&from=10

There was a comment issue that was preventing these values received from the api from being sent to elastic search and has now been corrected. It should be live soon. Not sure what the apps support for this feature of the api is. I see pagination in other areas of the app so maybe it was just hidden due to only 10 results being shown.

The search api does support pagination and custom sized results. `https://lighthouse.lbry.io/search?s=bitcoin&size=100&from=10` There was a comment issue that was preventing these values received from the api from being sent to elastic search and has now been corrected. It should be live soon. Not sure what the apps support for this feature of the api is. I see pagination in other areas of the app so maybe it was just hidden due to only 10 results being shown.

👍 3

tzarebczan commented

2018-04-27 02:24:57 +02:00

(Migrated from github.com)

Thanks @tiger5226, was just about to post here too haha. Bonus points for you, thanks for following up!

tiger5226 commented

2018-04-30 01:35:33 +02:00

(Migrated from github.com)

The changes for lighthouse are now live and pagination is working from the api.

However, in testing the app our original expectations are true. The app does not support pagination in search results. Excited to get this in the app! Search is soooo much better now, and users are missing out because they can only discover the tip of the iceberg(10 results). Go app team!!

The changes for lighthouse are now live and pagination is working from the api. However, in testing the app our original expectations are true. The app does not support pagination in search results. Excited to get this in the app! Search is soooo much better now, and users are missing out because they can only discover the tip of the iceberg(10 results). Go app team!!

tzarebczan commented

2018-06-28 21:07:52 +02:00

(Migrated from github.com)

With the setting for # of search results, we don't believe we need pagination. @tiger5226 what do you think?

tiger5226 commented

2018-06-30 01:12:42 +02:00

(Migrated from github.com)

I think it is much less important, but probably a nice to have. If you want to see 1000k results the loading of that will take a minute. Pagination allows for faster iteration of results. It is more of a formality now though. Happy to close this for now until we get through some of the more important issues. We can reopen if this becomes more important.