LBRYCommunity/lbry-desktop

Redux #127

Merged

kauffj merged 155 commits from redux into master

2017-05-21 23:13:42 +02:00

kauffj commented

2017-05-21 23:12:29 +02:00

(Migrated from github.com)

@lyoshenka said it's tricky to make a sharable release on a non-master branch, so I'm going to merge this despite known and likely unknown issues. Known issues:

Broken snack bar links
Broken help menu item
Title is not properly set on navigating back
URI handling not fully working (at least on Linux)
New user flow should be tested from start to finish, including all reward collection.

@lyoshenka said it's tricky to make a sharable release on a non-master branch, so I'm going to merge this despite known and likely unknown issues. Known issues: * Broken snack bar links * Broken help menu item * Title is not properly set on navigating back * URI handling not fully working (at least on Linux) * New user flow should be tested from start to finish, including all reward collection.

kauffj commented

2017-05-21 23:13:36 +02:00

(Migrated from github.com)

I'm merging this so I can make an RC, but please take a look at this @alexliebowitz @lyoshenka @14bd4beb. See comments above re: known issues.

I'm merging this so I can make an RC, but please take a look at this @alexliebowitz @lyoshenka @14bd4beb. See comments above re: known issues.

6ea86b96 commented

2017-05-22 17:27:46 +02:00

(Migrated from github.com)

Awesome!

@kauffj I'm not sure that storing files by outpoint works for all files? I've had a couple of cases in the past where files have had no outpoint because they are not yet uploaded I think. The only thing that seems to always exist is the sd_hash.

Awesome! @kauffj I'm not sure that storing files by outpoint works for all files? I've had a couple of cases in the past where files have had no outpoint because they are not yet uploaded I think. The only thing that seems to always exist is the `sd_hash`.

Sign in to join this conversation.

No reviewers

No labels

area: discovery

area: installer

area: livestream

area: performance

area: subscriptions

feature request

first-timers-only

good first issue

merge when green

needs: exploration

needs: grooming

needs: priority

needs: tech design

priority: blocker

priority: medium

protocol dependent

type: discussion

type: improvement

type: new feature

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#127

No description provided.