[redesign] even moar fixes #1270
No reviewers
Labels
No labels
accessibility
app-parity
area: creator
area: daemon
area: design
area: devops
area: discovery
area: docs
area: installer
area: internal
area: livestream
area: performance
area: proposal
area: reposts
area: rewards
area: search
area: security
area: subscriptions
area: sync
area: ux
area: viewer
area: wallet
BEAMER
channel
comments
community PR
consider soon
core team
css
dependencies
electron
Epic
feature request
first-timers-only
good first issue
hacktoberfest
help wanted
hub-dependent
icebox
Invalid
level: 0
level: 1
level: 2
level: 3
level: 4
merge when green
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
notifications
odysee
on hold
playlists
priority: blocker
priority: high
priority: low
priority: medium
protocol dependent
recsys
redesign
regression
resilience
sdk dependent
Tom's Wishlist
trending
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
windows
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: LBRYCommunity/lbry-desktop#1270
Loading…
Add table
Reference in a new issue
No description provided.
Delete branch "redesign-fixes"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Fixes:
#1218
#1219
#1226
#1227
#1263
https://github.com/lbryio/lbry-app/issues/1256
https://github.com/lbryio/lbry-app/issues/1223
https://github.com/lbryio/lbry-app/issues/1210
@ -150,4 +105,4 @@
if (!name) {
const parsedFileName = fileName.replace(regexInvalidURI, '');
const uri = this.getNewUri(parsedFileName, channel);
newFileParams.name = parsedFileName;
Just changed the order of these. Lint was complaining
feel free to merge this, everything looks great to me. I left some comments, but nothing substantive
@ -154,3 +109,4 @@
newFileParams.uri = uri;
}
updatePublishForm(newFileParams);
My comment here is same as the other comment below about a similar line
given your change elsewhere that added
!channel || ...
to it, does that need to be done here as well?not trying to make frivolous comments, but maybe this should be named
sources
and notsource
@ -154,3 +109,4 @@
newFileParams.uri = uri;
}
updatePublishForm(newFileParams);
actually, the comments is above in GitHub:
"given your change elsewhere that added !channel || ... to it, does that need to be done here as well?"
This is fine, because channel will definitely exist at this point. The other place there was a chance channel could be
undefined