Email verification should not be required to happen on the same device #1299

New issue

Closed

opened 2018-04-06 20:47:28 +02:00 by kauffj · 4 comments

kauffj commented

2018-04-06 20:47:28 +02:00

(Migrated from github.com)

Instead, when on the email verification screen, the app can poll the API server periodically to see if the user has a verified email. It can then advance past this screen regardless of what device verification happens on.

Some users will pull the verification email up on their phone rather than the computer they downloaded the desktop application on. The app should not require email verification to happen on the same device that it is installed on. Instead, when on the email verification screen, the app can poll the API server periodically to see if the user has a verified email. It can then advance past this screen regardless of what device verification happens on.

kauffj commented

2018-04-06 20:49:38 +02:00

(Migrated from github.com)

As I think about this more... why do we require the user to enter the token in the app at all? If the user clicks a link in the email, isn't this everything we need? @liamcardenas

neb-b commented

2018-10-15 21:33:33 +02:00

(Migrated from github.com)

@lyoshenka Does internal api's have everything needed when you click on the email link? Or can we implement that feature? I agree with @kauffj, the process of manually adding the verification code is very cumbersome.

lyoshenka commented

2018-10-17 16:54:29 +02:00

(Migrated from github.com)

No, we'd need to make some changes on internal-apis side to make this work. I'm guessing to make it work really well, we'd need some way to notify the app that signin has occurred (long-polling? websockets? idk)

neb-b commented

2018-10-18 06:59:53 +02:00

(Migrated from github.com)

Polling wouldn't be hard. Websockets would be nice. I'm not sure what future use case there may be to have a websocket with internal apis.