Just need to finish writing it. The biggest part is done (refactoring so the metadata fields are controlled). I got stuck because I've been receiving a blank set in the "myClaims" prop and had trouble debugging it; there's a lot of Redux-y indirection that was giving me a headache. It's helping me learn the new codebase, though. Over the weekend I'm going to plow through and finish this. IIRC that issue started happening suddenly for no apparent reason, which makes me think it's a daemon bug. If so, I'll make a simple mock for the correct behavior to get this working and file an issue in the lbry repo.

alexliebowitz commented

2017-06-03 09:39:08 +02:00

(Migrated from github.com)

#186 is related in that the updates won't actually work properly until we fix that. But this is purely form filling logic within the Publish page, doesn't touch Redux at all.

alexliebowitz commented

2017-06-05 09:44:12 +02:00

(Migrated from github.com)

Whew. Figured out the issue with the myClaims prop being empty.

The Publish page is populating the prop with a value from the Redux store: https://github.com/lbryio/lbry-app/blob/master/ui/js/page/publish/index.js#L15

... but it never actually dispatches an action to call claim_list_mine and get the value, so it defaults to an empty set:
https://github.com/lbryio/lbry-app/blob/master/ui/js/selectors/claims.js#L84

But the My Files page does request the info: https://github.com/lbryio/lbry-app/blob/master/ui/js/page/fileListDownloaded/index.js#L24

So the myClaims prop of the Publish page is only populated if you have already visited the My Files page. If you haven't visited My Files, the Publish page will act like you have no claims, and if you enter the name of something you already published, it doesn't indicate that you're updating an old claim. (This is happening on master too.)

Now that I finally figured that out, tomorrow I will fix this bug, finish the pre-fill stuff, and everything should be ready for review by late tomorrow.

@kauffj

Whew. Figured out the issue with the myClaims prop being empty. The Publish page is populating the prop with a value from the Redux store: https://github.com/lbryio/lbry-app/blob/master/ui/js/page/publish/index.js#L15 ... but it never actually dispatches an action to call `claim_list_mine` and get the value, so it defaults to an empty set: https://github.com/lbryio/lbry-app/blob/master/ui/js/selectors/claims.js#L84 But the My Files page does request the info: https://github.com/lbryio/lbry-app/blob/master/ui/js/page/fileListDownloaded/index.js#L24 So the myClaims prop of the Publish page is only populated if you have already visited the My Files page. If you haven't visited My Files, the Publish page will act like you have no claims, and if you enter the name of something you already published, it doesn't indicate that you're updating an old claim. (This is happening on master too.) Now that I finally figured that out, tomorrow I will fix this bug, finish the pre-fill stuff, and everything should be ready for review by late tomorrow. @kauffj

kauffj commented

2017-06-05 17:41:38 +02:00

(Migrated from github.com)

You might want to check out #192, seems related.