In-app upgrade runs installer twice on Windows #1423

New issue

Closed

opened 2018-05-02 15:55:27 +02:00 by tzarebczan · 0 comments

tzarebczan commented

2018-05-02 15:55:27 +02:00

(Migrated from github.com)

The Issue

Based on findings in https://github.com/lbryio/lbry-app/issues/1192#issuecomment-385983017, when using the "Use it now" option, Windows kicks off the installation twice. If a user clicks through it quickly enough, the installation goes according to plan (which means the daemon is closed and upgraded as well!). If you wait a few seconds on the 2nd prompt, the first installer is already running and LBRY starts up - then the 2nd installer is kicked off which closes LBRY, leaves lbrynet-daemon.exe running and then doesn't start back up. First installer is kicked off with --updated --force-run and the 2nd with --updated /S.

When using the "run on close" option, this does not happen. This kicks off the installer with --updated /S.

From first glance, it may be running both the upgrade now version + the shutdown version. Not sure if this is something on our end or if it's electron builder.

Steps to Reproduce

Download 0.21.2, run
Wait for upgrade prompt. Click use it now
Notice two UAC prompts

System Configuration

LBRY Daemon version:
LBRY App version:
LBRY Installation ID:
Operating system:

Anything Else

Screenshots

## The Issue Based on findings in https://github.com/lbryio/lbry-app/issues/1192#issuecomment-385983017, when using the "Use it now" option, Windows kicks off the installation twice. If a user clicks through it quickly enough, the installation goes according to plan (which means the daemon is closed and upgraded as well!). If you wait a few seconds on the 2nd prompt, the first installer is already running and LBRY starts up - then the 2nd installer is kicked off which closes LBRY, leaves lbrynet-daemon.exe running and then doesn't start back up. First installer is kicked off with --updated --force-run and the 2nd with --updated /S. When using the "run on close" option, this does not happen. This kicks off the installer with --updated /S. From first glance, it may be running both the upgrade now version + the shutdown version. Not sure if this is something on our end or if it's electron builder. ### Steps to Reproduce 1. Download 0.21.2, run 2. Wait for upgrade prompt. Click use it now 3. Notice two UAC prompts ## System Configuration   - LBRY Daemon version: - LBRY App version: - LBRY Installation ID: - Operating system: ## Anything Else  ## Screenshots