Use channel id instead of name when publishing #1433

Closed
opened 2018-05-03 15:26:26 +02:00 by tzarebczan · 6 comments
tzarebczan commented 2018-05-03 15:26:26 +02:00 (Migrated from github.com)

The Issue

In order to allow channel + claim creation in the same block, we should be using the channel id instead of the channel name when publishing with channel data. See syntax: https://lbryio.github.io/lbry/cli/#publish

See comments here: https://github.com/lbryio/lbry/issues/893#issuecomment-386050685

System Configuration

  • LBRY Daemon version:
  • LBRY App version:
  • LBRY Installation ID:
  • Operating system:

Anything Else

Screenshots

<!-- Thanks for reporting an issue to LBRY and helping us improve! To make it possible for us to help you, please fill out below information carefully. Before reporting any issues, please make sure that you're using the latest version. - App releases: https://github.com/lbryio/lbry-app/releases - Standalone daemon: https://github.com/lbryio/lbry/releases We are also available on live chat at https://chat.lbry.io --> ## The Issue In order to allow channel + claim creation in the same block, we should be using the channel id instead of the channel name when publishing with channel data. See syntax: https://lbryio.github.io/lbry/cli/#publish See comments here: https://github.com/lbryio/lbry/issues/893#issuecomment-386050685 ## System Configuration <!-- For the app, this info is in the About section at the bottom of the Help page. You can include a screenshot instead of typing it out --> <!-- For the daemon, run: curl 'http://localhost:5279' --data '{"method":"version"}' and include the full output --> - LBRY Daemon version: - LBRY App version: - LBRY Installation ID: - Operating system: ## Anything Else <!-- Include anything else that does not fit into the above sections --> ## Screenshots <!-- If a screenshot would help explain the bug, please include one or two here -->
kauffj commented 2018-05-03 15:41:55 +02:00 (Migrated from github.com)

If a single parameter change fixes the same block channel creation + publish bug, this should be a top priority fix and included in the next patch/minor release.

Marking for this sprint to at least try this. @seanyesmunt

If a single parameter change fixes the same block channel creation + publish bug, this should be a top priority fix and included in the next patch/minor release. Marking for this sprint to at least try this. @seanyesmunt
kauffj commented 2018-05-03 15:42:20 +02:00 (Migrated from github.com)

@tzarebczan you could also try this

@tzarebczan you could also try this
tzarebczan commented 2018-05-07 18:58:42 +02:00 (Migrated from github.com)

@seanyesmunt @kauffj I did take a brief look into it and it would require redux changes post redesign, which means re-work required pre-redesign. @seanyesmunt let me know and I can walk you through it, maybe there's an easier way, but I didn't see the channel id as an available field (I could be mistaken though).

@seanyesmunt @kauffj I did take a brief look into it and it would require redux changes post redesign, which means re-work required pre-redesign. @seanyesmunt let me know and I can walk you through it, maybe there's an easier way, but I didn't see the channel id as an available field (I could be mistaken though).
tzarebczan commented 2018-05-14 21:10:00 +02:00 (Migrated from github.com)

@daovist Maybe you want to take a look at this one? I can explain to you what's happen now vs how we want it to work.

@daovist Maybe you want to take a look at this one? I can explain to you what's happen now vs how we want it to work.
daovist commented 2018-05-15 17:14:57 +02:00 (Migrated from github.com)

I am working on this issue.

I am working on this issue.
tzarebczan commented 2018-05-25 21:20:37 +02:00 (Migrated from github.com)
Fixed in https://github.com/lbryio/lbry-app/pull/1481
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#1433
No description provided.