LBRYCommunity/lbry-desktop

Show modal when claiming a reward #1455

Merged

dan1d merged 2 commits from fix-claiming-reward-modal into master

2018-05-10 05:53:03 +02:00

dan1d commented

2018-05-08 03:32:37 +02:00

(Migrated from github.com)

This fixes PART of the issues reported in #1436
As @tzarebczan reported, this error Uncaught (in promise) Error: Actions may not have an undefined "type" property. Have you misspelled a constant?, the constant ACTIONS.OPEN_MODALS is not defined anymore and it throws that error as the type for an action when dispatching it is undefined:

dispatch({
          type: ACTIONS.OPEN_MODAL,
          data: { modal: MODALS.FIRST_REWARD },
        });

Seems like the code to open modals have been refactored and changed to notifications, as far as I understand.

This fixes PART of the issues reported in #1436 As @tzarebczan reported, this error `Uncaught (in promise) Error: Actions may not have an undefined "type" property. Have you misspelled a constant?`, the constant ACTIONS.OPEN_MODALS is not defined anymore and it throws that error as the type for an action when dispatching it is undefined: ``` dispatch({ type: ACTIONS.OPEN_MODAL, data: { modal: MODALS.FIRST_REWARD }, }); ``` Seems like the code to open modals have been refactored and changed to notifications, as far as I understand. ![screenshot from 2018-05-07 22-30-13](https://user-images.githubusercontent.com/3293616/39732892-46f27506-5246-11e8-88d2-4a309fd40484.png)

neb-b (Migrated from github.com) reviewed 2018-05-08 03:32:37 +02:00

neb-b commented

2018-05-08 07:02:53 +02:00

(Migrated from github.com)

Awesome! Can you update this to use lbry-redux? I just merged your other PR

Awesome! Can you update this to use `lbry-redux`? I just merged your other PR

dan1d commented

2018-05-08 15:16:13 +02:00

(Migrated from github.com)

@seanyesmunt Done!, I've also added another modal call to use notifications that was not working before!.

@seanyesmunt Done!, I've also added another modal call to use notifications that was not working before!.

tzarebczan commented

2018-05-08 15:20:36 +02:00

(Migrated from github.com)

Thanks @dan1d ! You fixed https://github.com/lbryio/lbry-app/issues/1407 in the process as well!

Thanks @dan1d ! You fixed https://github.com/lbryio/lbry-app/issues/1407 in the process as well!

dan1d commented

2018-05-09 00:31:34 +02:00

(Migrated from github.com)

Glad to know @tzarebczan!
As requested: changelog Updated.

Glad to know @tzarebczan! As requested: changelog Updated.

tzarebczan commented

2018-05-11 00:20:37 +02:00

(Migrated from github.com)

@dan1d please send us an email with this PR and your estimated time spent, thanks again for the contribution! https://lbry.io/faq/tips

@dan1d please send us an email with this PR and your estimated time spent, thanks again for the contribution! https://lbry.io/faq/tips

Sign in to join this conversation.

No reviewers

No labels

area: discovery

area: installer

area: livestream

area: performance

area: subscriptions

feature request

first-timers-only

good first issue

merge when green

needs: exploration

needs: grooming

needs: priority

needs: tech design

priority: blocker

priority: medium

protocol dependent

type: discussion

type: improvement

type: new feature

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#1455

No description provided.