Can type in unfocused fields while publishing without selecting file #1456

New issue

Closed

opened 2018-05-09 03:20:54 +02:00 by tzarebczan · 3 comments

tzarebczan commented

2018-05-09 03:20:54 +02:00

(Migrated from github.com)

The Issue

When going to the publish screen, the select file area is in focus and the rest of the screen is grayed out, but you can still go into most of the fields and type (blocked from Title/thumbnail, but rest work, even dropdowns). If we intend to force users to select a file first, we should not allow typing anywhere else on the publish form.

Steps to Reproduce

Click publish, don't select a file
Scroll down to description or claim name
You can type

System Configuration

LBRY Daemon version:
LBRY App version:
LBRY Installation ID:
Operating system:

Anything Else

Screenshots

## The Issue When going to the publish screen, the select file area is in focus and the rest of the screen is grayed out, but you can still go into most of the fields and type (blocked from Title/thumbnail, but rest work, even dropdowns). If we intend to force users to select a file first, we should not allow typing anywhere else on the publish form. ### Steps to Reproduce 1. Click publish, don't select a file 2. Scroll down to description or claim name 3. You can type ## System Configuration   - LBRY Daemon version: - LBRY App version: - LBRY Installation ID: - Operating system: ## Anything Else  ## Screenshots

kauffj commented

2018-05-09 14:43:26 +02:00

(Migrated from github.com)

Test tab selection too

On Tue, May 8, 2018, 9:20 PM Thomas Zarebczan notifications@github.com
wrote:

The Issue

When going to the publish screen, the select file area is in focus and the
rest of the screen is grayed out, but you can still go into most of the
fields and type (blocked from Title/thumbnail, but rest work, even
dropdowns). If we intend to force users to select a file first, we should
not allow typing anywhere else on the publish form.
Steps to Reproduce

Click publish, don't select a file

Scroll down to description or claim name

You can type

System Configuration

LBRY Daemon version:

LBRY App version:

LBRY Installation ID:

Operating system:

Anything Else Screenshots

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/lbryio/lbry-app/issues/1456, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAgZVkDR_g114NbklkyxGTK44W0oOLLGks5twkR2gaJpZM4T3kTQ
.

Test tab selection too On Tue, May 8, 2018, 9:20 PM Thomas Zarebczan <notifications@github.com> wrote: > The Issue > > When going to the publish screen, the select file area is in focus and the > rest of the screen is grayed out, but you can still go into most of the > fields and type (blocked from Title/thumbnail, but rest work, even > dropdowns). If we intend to force users to select a file first, we should > not allow typing anywhere else on the publish form. > Steps to Reproduce > > 1. Click publish, don't select a file > 2. Scroll down to description or claim name > 3. You can type > > System Configuration > > - LBRY Daemon version: > - LBRY App version: > - LBRY Installation ID: > - Operating system: > > Anything Else Screenshots > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > <https://github.com/lbryio/lbry-app/issues/1456>, or mute the thread > <https://github.com/notifications/unsubscribe-auth/AAgZVkDR_g114NbklkyxGTK44W0oOLLGks5twkR2gaJpZM4T3kTQ> > . >

tzarebczan commented

2018-05-10 22:16:35 +02:00

(Migrated from github.com)

@seanyesmunt another thing to consider is that we still rely on the Publish screen for the channel creation process, which is now even more hidden because you need to select a file first (what if I want to create a channel without publishing? )

tzarebczan commented

2018-06-21 07:57:13 +02:00

(Migrated from github.com)

Fixed in: https://github.com/lbryio/lbry-app/pull/1659