Release blockers #1469

Merged
neb-b merged 9 commits from release-blockers into master 2018-05-16 23:42:08 +02:00
neb-b commented 2018-05-11 01:07:44 +02:00 (Migrated from github.com)
https://github.com/lbryio/lbry-app/issues/1419 https://github.com/lbryio/lbry-app/issues/1257 https://github.com/lbryio/lbry-app/issues/1264 https://github.com/lbryio/lbry-app/issues/1406 https://github.com/lbryio/lbry-app/issues/1404 https://github.com/lbryio/lbry-app/issues/1478
tzarebczan commented 2018-05-14 15:51:17 +02:00 (Migrated from github.com)

@seanyesmunt were you still working through this or should we add Jeremy as a reviewer?

@seanyesmunt were you still working through this or should we add Jeremy as a reviewer?
neb-b commented 2018-05-14 16:09:40 +02:00 (Migrated from github.com)

Still working on this

On Mon, May 14, 2018, 9:51 AM Thomas Zarebczan notifications@github.com
wrote:

@seanyesmunt https://github.com/seanyesmunt were you still working
through this or should we add Jeremy as a reviewer?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/lbryio/lbry-app/pull/1469#issuecomment-388823711, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AQGcjkKp4V5KyyWudAhidE5ZKAVOGi9sks5tyYvYgaJpZM4T6riw
.

Still working on this On Mon, May 14, 2018, 9:51 AM Thomas Zarebczan <notifications@github.com> wrote: > @seanyesmunt <https://github.com/seanyesmunt> were you still working > through this or should we add Jeremy as a reviewer? > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/lbryio/lbry-app/pull/1469#issuecomment-388823711>, or mute > the thread > <https://github.com/notifications/unsubscribe-auth/AQGcjkKp4V5KyyWudAhidE5ZKAVOGi9sks5tyYvYgaJpZM4T6riw> > . >
neb-b (Migrated from github.com) reviewed 2018-05-16 21:32:40 +02:00
@ -38,2 +38,3 @@
"import/prefer-default-export": 0
"import/prefer-default-export": 0,
"no-return-assign": 0
}
neb-b (Migrated from github.com) commented 2018-05-16 21:32:40 +02:00

I think we can get rid of this since it is a common patter to return assignments for react refs

<input ref={(input) => this.input = input} />
I think we can get rid of this since it is a common patter to return assignments for react refs ``` <input ref={(input) => this.input = input} /> ```
kauffj (Migrated from github.com) approved these changes 2018-05-16 22:44:43 +02:00
kauffj (Migrated from github.com) left a comment

LGTM and you can merge at your convenience. One small comment for you to read.

LGTM and you can merge at your convenience. One small comment for you to read.
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#1469
No description provided.