Download search only works for full word matches, it should work for partial string matches too #1489

Closed
opened 2018-05-17 00:31:31 +02:00 by neb-b · 1 comment
neb-b commented 2018-05-17 00:31:31 +02:00 (Migrated from github.com)

The Issue

To see a downloaded file, I need to type one full word that matches a piece of metadata for that file.

Steps to Reproduce

  1. Download a file, ex: lbry://iconoclasts-review-the-wrench-of-freedom#2b4a3ee4d865c66e6f2545a74c0f21f0ac02d0f3
  2. Search for "icono" and notice it doesn't match
  3. "iconoclats" does work

Expected Behaviour

It should find files from partial string matches

Suggested Solutions

The change will need to be made to this function https://github.com/lbryio/lbry-redux/blob/master/src/redux/selectors/file_info.js#L109

Instead of checking individual words against the file metadata, we can just concat all the metadata into one long string. Then break up the search query by spaces and do a regex search against the long string on each query part.

## The Issue To see a downloaded file, I need to type one full word that matches a piece of metadata for that file. ### Steps to Reproduce 1. Download a file, ex: lbry://iconoclasts-review-the-wrench-of-freedom#2b4a3ee4d865c66e6f2545a74c0f21f0ac02d0f3 2. Search for "icono" and notice it doesn't match 3. "iconoclats" does work ### Expected Behaviour It should find files from partial string matches ### Suggested Solutions The change will need to be made to this function https://github.com/lbryio/lbry-redux/blob/master/src/redux/selectors/file_info.js#L109 Instead of checking individual words against the file metadata, we can just concat all the metadata into one long string. Then break up the search query by spaces and do a regex search against the long string on each query part.
jeffslofish commented 2020-04-14 08:46:27 +02:00 (Migrated from github.com)

I'm not sure when this got fixed, but as of the latest release, v0.44.0, partial string matches are working great for downloaded content. I recommend this issue be closed.

I'm not sure when this got fixed, but as of the latest release, v0.44.0, partial string matches are working great for downloaded content. I recommend this issue be closed.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#1489
No description provided.