Pass permanent URL to analytics event / output issue #1494

New issue

Closed

opened 2018-05-18 22:54:28 +02:00 by tzarebczan · 0 comments

tzarebczan commented

2018-05-18 22:54:28 +02:00

(Migrated from github.com)

The Issue

https://github.com/lbryio/lbry-app/blob/master/src/renderer/redux/actions/content.js#L228

Instead of passing the current uri the user is on, which could be the vanity uri or a variation with/without the channel, we should determine and pass the permanent uri as specified in the claim metadata.

I also noticed that the outpoint is being filled sporadically, not sure exactly why that is. Maybe it's supposed to pass streamInfo.outpoint and not streamInfo.output ? But that wouldn't explain why it's working sometimes.

System Configuration

LBRY Daemon version:
LBRY App version:
LBRY Installation ID:
Operating system:

Anything Else

Screenshots

## The Issue https://github.com/lbryio/lbry-app/blob/master/src/renderer/redux/actions/content.js#L228 Instead of passing the current uri the user is on, which could be the vanity uri or a variation with/without the channel, we should determine and pass the permanent uri as specified in the claim metadata. I also noticed that the outpoint is being filled sporadically, not sure exactly why that is. Maybe it's supposed to pass streamInfo.outpoint and not streamInfo.output ? But that wouldn't explain why it's working sometimes. ## System Configuration   - LBRY Daemon version: - LBRY App version: - LBRY Installation ID: - Operating system: ## Anything Else  ## Screenshots