Search, Autocomplete gaps #1496

New issue

Closed

opened 2018-05-21 01:15:30 +02:00 by tiger5226 · 9 comments

tiger5226 commented

2018-05-21 01:15:30 +02:00

(Migrated from github.com)

I reviewed the app redesign and how it is using auto complete. I think it might be being misused. The expectations from a user is probably the following:

When I type, I see suggested search terms that complete my thought.
- if I am starting with an @ then I expect it to complete the claim name, just as in any browser that I start with http:// or www and it suggests the site I am trying to visit, otherwise I am looking for search suggestions not exact pages.
When I click the enter button that is what I am searching. Currently, it tries to take me to a specific claim which obviously doesn't exist because I am searching not going to a specific claim.
- If it starts with an @ I am trying to go to a specific claim or channel.
- If not then I am trying perform a search not going to a claim.
- I should not have to type, then click a row in the list to perform a search.

I think these main points are the default expectations of a user.

I reviewed the app redesign and how it is using auto complete. I think it might be being misused. The expectations from a user is probably the following: - When I type, I see suggested search terms that complete my thought. - if I am starting with an `@` then I expect it to complete the claim name, just as in any browser that I start with `http://` or `www` and it suggests the site I am trying to visit, otherwise I am looking for search suggestions not exact pages. - When I click the enter button that is what I am searching. Currently, it tries to take me to a specific claim which obviously doesn't exist because I am searching not going to a specific claim. - If it starts with an `@` I am trying to go to a specific claim or channel. - If not then I am trying perform a search not going to a claim. - I should not have to type, then click a row in the list to perform a search. I think these main points are the default expectations of a user.

tzarebczan commented

2018-05-22 18:37:32 +02:00

(Migrated from github.com)

One I the reasons we want the default the enter behavior to go to the exact claim is to showcase lbry:// URLs. Maybe we should check to see if the term entered is an actual URL before defaulting to that behavior? Otherwise, why would anyone want to go to a claim that doesn't exist (this would the 2ndary behavior if a user clicked it).

tiger5226 commented

2018-05-23 03:34:03 +02:00

(Migrated from github.com)

Yeah we should be able to regex it before assuming we want to go to an exact url. Otherwise it is a search.

tiger5226 commented

2018-06-10 20:47:29 +02:00

(Migrated from github.com)

I did check the code and it appears to be going to a url if it is one word and search if there are two words or more.

tiger5226 commented

2018-06-17 16:16:39 +02:00

(Migrated from github.com)

I wonder if it would be performant to just try to resolve the url on enter, and if not, perform a search instead. This way there is no questioning whether it is a valid url or not. This would probably be the idea scenario.

tiger5226 commented

2018-06-21 00:25:16 +02:00

(Migrated from github.com)

With the resolve improvements https://github.com/lbryio/lbry/pull/1264 and https://github.com/lbryio/lbryschema/pull/47 this is much more of a good idea. I think we should use resolve as part of the search function when a user hits submit.

neb-b commented

2018-06-21 00:44:22 +02:00

(Migrated from github.com)

I'm not sure what we would gain from resolving on enter? Do you mean resolve, then if nothing is at that uri, fallback and do a search?

tiger5226 commented

2018-06-21 04:35:45 +02:00

(Migrated from github.com)

thats exactly what I mean. It is uber annoying that it defaults to a URI that doesn't exist

neb-b commented

2018-06-21 05:08:45 +02:00

(Migrated from github.com)

Gotcha. I like that idea

On Wed, Jun 20, 2018, 10:35 PM Mark notifications@github.com wrote:

thats exactly what I mean. It is uber annoying that it defaults to a URI
that doesn't exist

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/lbryio/lbry-app/issues/1496#issuecomment-398957441,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQGcjvuQ5W1Rl1heWlt7aC5B6RYaHydMks5t-waEgaJpZM4UGRK-
.

Gotcha. I like that idea On Wed, Jun 20, 2018, 10:35 PM Mark <notifications@github.com> wrote: > thats exactly what I mean. It is uber annoying that it defaults to a URI > that doesn't exist > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > <https://github.com/lbryio/lbry-app/issues/1496#issuecomment-398957441>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AQGcjvuQ5W1Rl1heWlt7aC5B6RYaHydMks5t-waEgaJpZM4UGRK-> > . >

tiger5226 commented

2018-07-07 15:21:38 +02:00

(Migrated from github.com)

closed in favor of the more specific issue that addresses the problem as described above.

closed in favor of the more specific [issue](https://github.com/lbryio/lbry-app/issues/1699) that addresses the problem as described above.