Add scam alert message when opening development tools. #1500

Merged
dan1d merged 3 commits from alert-scam into master 2018-06-01 04:10:14 +02:00
dan1d commented 2018-05-23 04:40:24 +02:00 (Migrated from github.com)

Hi, I've took the liberty to work on issue #1430 as the issue is 20 days old and OP didn't answered if he was going to work on this.
It closes issue: #1430, adds a warning message when development tools is opened on production, it can be disabled on development but is active by default.
Let me know if I should change the log message, or if while on development it should be disabled.
screenshot from 2018-05-22 23-23-47

Hi, I've took the liberty to work on issue #1430 as the issue is 20 days old and OP didn't answered if he was going to work on this. It closes issue: #1430, adds a warning message when development tools is opened on production, it can be disabled on development but is active by default. Let me know if I should change the log message, or if while on development it should be disabled. ![screenshot from 2018-05-22 23-23-47](https://user-images.githubusercontent.com/3293616/40400617-608bae54-5e19-11e8-9708-cf9c3e1181a3.png)
skhameneh (Migrated from github.com) approved these changes 2018-05-23 07:44:36 +02:00
kauffj commented 2018-05-23 15:33:20 +02:00 (Migrated from github.com)

Love the join us plug @dan1d :)

Love the join us plug @dan1d :)
neb-b commented 2018-05-25 17:08:04 +02:00 (Migrated from github.com)

I don't think this should be logged in dev mode

I don't think this should be logged in dev mode
neb-b (Migrated from github.com) requested changes 2018-05-30 05:09:06 +02:00
neb-b (Migrated from github.com) left a comment

Lets disable for dev mode then we can merge

Lets disable for dev mode then we can merge
tzarebczan commented 2018-05-30 15:57:45 +02:00 (Migrated from github.com)

@dan1d tagging you to make sure you saw the above comment.

@dan1d tagging you to make sure you saw the above comment.
dan1d commented 2018-05-30 21:22:10 +02:00 (Migrated from github.com)

Hi @seanyesmunt @tzarebczan
I've disabled the log on development!

Hi @seanyesmunt @tzarebczan I've disabled the log on development!
neb-b (Migrated from github.com) approved these changes 2018-06-01 04:09:16 +02:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#1500
No description provided.