Navigation button resulting incorrect page designation #1502

New issue

Closed

opened 2018-05-23 06:58:48 +02:00 by ceoger · 6 comments

ceoger commented

2018-05-23 06:58:48 +02:00

(Migrated from github.com)

The Issue

back navigation button resulting incorrect page designation

Steps to Reproduce

go to brightsunfilms channel
click page 11
click back button
It shows page 1 but highlights page 11.

Expected Behaviour

Back should take you to previous page and highlight page number

Actual Behaviour

It shows page 1 but highlights page 11.
same for other pages, be on page 11, click page 10, click back and it takes you back to page 11 with pag 10 still highlighted

System Configuration

LBRY Daemon version: 0.19.1
LBRY App version: 0.22.0-rc.8
LBRY Installation ID: 3cXLZiAWXwwJbv4fjhbXVgFtaBuUiFQM7afXmFYu5ss1chD1WCpxGUp8aW68gjeNRC
Operating system: Windows (Windows-10-10.0.16299)

Anything Else

https://cdn.discordapp.com/attachments/377895389992321064/447849109462843402/1.JPG
https://cdn.discordapp.com/attachments/377895389992321064/447849121521336320/2.JPG

Screenshots

## The Issue back navigation button resulting incorrect page designation ### Steps to Reproduce 1. go to brightsunfilms channel 2. click page 11 3. click back button 4. It shows page 1 but highlights page 11. ### Expected Behaviour Back should take you to previous page and highlight page number ### Actual Behaviour It shows page 1 but highlights page 11. same for other pages, be on page 11, click page 10, click back and it takes you back to page 11 with pag 10 still highlighted ### Suggested Solutions Back should take you to previous page and highlight page number ## System Configuration   - LBRY Daemon version: 0.19.1 - LBRY App version: 0.22.0-rc.8 - LBRY Installation ID: 3cXLZiAWXwwJbv4fjhbXVgFtaBuUiFQM7afXmFYu5ss1chD1WCpxGUp8aW68gjeNRC - Operating system: Windows (Windows-10-10.0.16299) ## Anything Else  https://cdn.discordapp.com/attachments/377895389992321064/447849109462843402/1.JPG https://cdn.discordapp.com/attachments/377895389992321064/447849121521336320/2.JPG ## Screenshots

tzarebczan commented

2018-05-23 15:01:20 +02:00

(Migrated from github.com)

Can confirm this is a bug pre-redesign as well.

@ceoger please upload those images directly into the ticket, otherwise the links may get taken down by Discord.

Thanks again for filing, sent you some LBC on Discord!

Can confirm this is a bug pre-redesign as well. @ceoger please upload those images directly into the ticket, otherwise the links may get taken down by Discord. Thanks again for filing, sent you some LBC on Discord!

ceoger commented

2018-05-23 15:13:19 +02:00

(Migrated from github.com)

@tzarebczan there is no channel pages in the predesign... i double checked

tiger5226 commented

2018-06-10 20:44:02 +02:00

(Migrated from github.com)

@tzarebczan this was fixed recently with another PR. I can't find it though. I tested and it appear to be working fine ( the back button ) in the redesign. Can you confirm?

tzarebczan commented

2018-06-10 21:30:41 +02:00

(Migrated from github.com)

@tiger5226 just tried it on 0.20rc10 and it still occurs.

tiger5226 commented

2018-06-11 01:04:28 +02:00

(Migrated from github.com)

Ohh sorry wrong issue. The search page back button wasn't working and is now. This issue is different, my apologies.

btzr-io commented

2018-06-27 00:33:38 +02:00

(Migrated from github.com)

Fixed and merged in master.