LBRYCommunity/lbry-desktop

special links/invalid URIs #1511

Merged

tzarebczan merged 1 commit from special-links into master

2018-05-30 20:47:38 +02:00

tzarebczan commented

2018-05-24 01:58:27 +02:00

(Migrated from github.com)

Implements https://github.com/lbryio/lbry-app/issues/1352 - tested on Windows/Mac/Linux
Fixes https://github.com/lbryio/lbry-app/issues/959

This will also enable us to use magic links on Windows, as before the ? was not being escaped properly.
Will need to update: b81191c7c5/view/template/acquisition/verify.php (L54)

Tested magic link on Windows by setting the user agent.

Thanks to @seanyesmunt for help with the doNotify logic :)

Implements https://github.com/lbryio/lbry-app/issues/1352 - tested on Windows/Mac/Linux Fixes https://github.com/lbryio/lbry-app/issues/959 This will also enable us to use magic links on Windows, as before the `?` was not being escaped properly. Will need to update: https://github.com/lbryio/lbry.io/blob/b81191c7c5312183c25d072f3068b09fcdd1719e/view/template/acquisition/verify.php#L54 Tested magic link on Windows by setting the user agent. Thanks to @seanyesmunt for help with the doNotify logic :)

neb-b (Migrated from github.com) reviewed 2018-05-24 05:46:12 +02:00

src/renderer/index.js

					
				@ -16,9 +16,9 @@ import 'scss/all.scss';

				import store from 'store';

				import app from './app';

neb-b (Migrated from github.com) commented

2018-05-24 05:46:12 +02:00

I think we should call this something else. Maybe appPageUrl or something. Just to give some indication of what it is

I think we should call this something else. Maybe `appPageUrl` or something. Just to give some indication of what it is

tzarebczan (Migrated from github.com) reviewed 2018-05-24 07:48:54 +02:00

src/renderer/index.js

					
				@ -16,9 +16,9 @@ import 'scss/all.scss';

				import store from 'store';

				import app from './app';

tzarebczan (Migrated from github.com) commented

2018-05-24 07:48:53 +02:00

good call.

good call.

neb-b (Migrated from github.com) requested changes 2018-05-30 05:03:35 +02:00

neb-b (Migrated from github.com) left a comment

A couple small changes. After updating and squashing the commits we can merge this.

A couple small changes. After updating and squashing the commits we can merge this.

src/renderer/component/router/view.jsx

neb-b (Migrated from github.com) commented

2018-05-30 05:02:36 +02:00

can you try running yarn format? These two lines above should be indented once more.

can you try running `yarn format`? These two lines above should be indented once more.

src/renderer/index.js

					
				@ -16,9 +16,9 @@ import 'scss/all.scss';

				import store from 'store';

				import app from './app';

neb-b (Migrated from github.com) commented

2018-05-30 05:03:01 +02:00

Generally constants like this are in all caps APP_PAGE_URL

Generally constants like this are in all caps `APP_PAGE_URL`

tzarebczan (Migrated from github.com) reviewed 2018-05-30 17:55:43 +02:00

src/renderer/index.js

					
				@ -16,9 +16,9 @@ import 'scss/all.scss';

				import store from 'store';

				import app from './app';

tzarebczan (Migrated from github.com) commented

2018-05-30 17:55:43 +02:00

fixed

fixed

tzarebczan (Migrated from github.com) reviewed 2018-05-30 17:56:24 +02:00

src/renderer/component/router/view.jsx

tzarebczan (Migrated from github.com) commented

2018-05-30 17:56:24 +02:00

fixed this one, there may be some others from previous commits. If you want, run prettier on this branch please.

fixed this one, there may be some others from previous commits. If you want, run prettier on this branch please.

neb-b (Migrated from github.com) approved these changes 2018-05-30 20:30:10 +02:00

neb-b commented

2018-05-30 20:30:49 +02:00

(Migrated from github.com)

@tzarebczan I rebased and squashed your commits. I'll merge once it's green 🙂

@tzarebczan I rebased and squashed your commits. I'll merge once it's green :slightly_smiling_face:

neb-b commented

2018-05-30 20:47:33 +02:00

(Migrated from github.com)

Not sure why the push travis build is looking at the old .travis.yml. The PR build passed so good to go.

Not sure why the `push` travis build is looking at the old `.travis.yml`. The PR build passed so good to go.

tzarebczan commented

2018-05-30 20:49:05 +02:00

(Migrated from github.com)

I didn't update the Travis config on this build, that's why.

I didn't update the Travis config on this build, that's why.

Sign in to join this conversation.

No reviewers

No labels

area: discovery

area: installer

area: livestream

area: performance

area: subscriptions

feature request

first-timers-only

good first issue

merge when green

needs: exploration

needs: grooming

needs: priority

needs: tech design

priority: blocker

priority: medium

protocol dependent

type: discussion

type: improvement

type: new feature

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#1511

No description provided.