Updated Search Page CSS and added description #1522

2018-05-26T04:42:02+02:00

tiger5226 commented

2018-05-26 04:42:02 +02:00

(Migrated from github.com)

Added description and changed css so the search screen is more presentable to the user.

neb-b (Migrated from github.com) reviewed 2018-05-30 04:32:47 +02:00

neb-b (Migrated from github.com) left a comment

A few small changes but I'm a fan of this.

src/renderer/component/fileTile/view.jsx

neb-b (Migrated from github.com) commented

2018-05-30 04:28:24 +02:00

I think the file price should stay on the bottom. The title should be the first thing they see.

neb-b (Migrated from github.com) commented

2018-05-30 04:29:56 +02:00

IMO it should be:

{title}
{channel}

{description}

{price}

IMO it should be: ``` {title} {channel} {description} {price} ```

src/renderer/scss/_vars.scss

neb-b (Migrated from github.com) commented

2018-05-30 04:28:02 +02:00

This should keep the same aspect ratio
calc(150px * (1 + 9/16))

This should keep the same aspect ratio `calc(150px * (1 + 9/16))`

src/renderer/scss/component/_card.scss

					
				@ -100,13 +100,6 @@

				  color: var(--text-color);

				}

neb-b (Migrated from github.com) commented

2018-05-30 04:31:54 +02:00

Since we are making the tiles bigger, I think we can increase the title size too

tiger5226 (Migrated from github.com) reviewed 2018-05-30 23:09:18 +02:00

src/renderer/component/fileTile/view.jsx

tiger5226 (Migrated from github.com) commented

2018-05-30 23:09:18 +02:00

I think that makes sense. This was a special request from Tom. I don't think he was especially attached to it. So no biggie.

neb-b commented

2018-06-04 16:59:18 +02:00

(Migrated from github.com)

@tiger5226 Were you planning on finishing this up? I can also make the changes. I do really like this change so it would be great to have for the initial release

tiger5226 commented

2018-06-04 23:51:05 +02:00

(Migrated from github.com)

ohh crap. I saw this but forgot about. I will make the change tonight. Sorry about that.

neb-b commented

2018-06-05 05:04:16 +02:00

(Migrated from github.com)

Just merged https://github.com/lbryio/lbry-app/pull/1514

Which just moves the search modal to an actual page with forward/back support. There are some style issues which should be fixed by this PR.

Just merged https://github.com/lbryio/lbry-app/pull/1514 Which just moves the search modal to an actual page with forward/back support. There are some style issues which should be fixed by this PR.

tiger5226 commented

2018-06-05 13:40:59 +02:00

(Migrated from github.com)

ok, I will take care of this.

tiger5226 commented

2018-06-06 04:20:09 +02:00

(Migrated from github.com)

Hi Sean,

I merged master in, but there are now more issues on the search page after doing so. When you type, then click the search row, it brings you to an empty page. I saw a commit for adjusting the search mechanics. I am not good with react or javascript so its not so simple. Also I tried a rebase and there are conflicts that need to be resolved and I am not sure I am the best person to be doing that.

Hi Sean, I merged master in, but there are now more issues on the search page after doing so. When you type, then click the search row, it brings you to an empty page. I saw a commit for adjusting the search mechanics. I am not good with react or javascript so its not so simple. Also I tried a rebase and there are conflicts that need to be resolved and I am not sure I am the best person to be doing that.

Sign in to join this conversation.

No reviewers