Fix claim ID being null when reporting a claim that was not previously download. #1530

Merged
DanielaNarvaez merged 3 commits from fix-claim-report into master 2018-06-01 06:23:09 +02:00
DanielaNarvaez commented 2018-05-31 04:14:22 +02:00 (Migrated from github.com)

Closes issue: #1512 properly pass claim ID to the https://lbry.io/dmca?claim_id url, as @tzarebczan told me I will continue to work on https://github.com/lbryio/lbry-app/pull/1425 but for now the fix closes #1512

Closes issue: #1512 properly pass claim ID to the https://lbry.io/dmca?claim_id url, as @tzarebczan told me I will continue to work on https://github.com/lbryio/lbry-app/pull/1425 but for now the fix closes #1512
neb-b (Migrated from github.com) requested changes 2018-05-31 05:21:15 +02:00
neb-b (Migrated from github.com) left a comment

Just one small change but looks great. Thanks!

Just one small change but looks great. Thanks!
neb-b (Migrated from github.com) commented 2018-05-31 05:20:58 +02:00

Since this is already being passed in from another component, we don't need to specify it here. This is only for selecting props from state.

Since this is already being passed in from another component, we don't need to specify it here. This is only for selecting props from state.
tzarebczan commented 2018-05-31 05:51:50 +02:00 (Migrated from github.com)

Woohoo @DaniNz, thanks for the contribution - glad you made it through your first PR! Normally we have a bot that reminds devs about updating the changelog, but it's disabled at the moment. Can you please do so at your earliest convenience? See previous entries for format...it's pretty straightforward.

If you are interested in an LBC tip for your time, please see https://lbry.io/faq/tips

We'll also be adding you to our developer mailing list so we can keep in touch (you can unsubscribe anytime!).

Woohoo @DaniNz, thanks for the contribution - glad you made it through your first PR! Normally we have a bot that reminds devs about updating the changelog, but it's disabled at the moment. Can you please do so at your earliest convenience? See previous entries for format...it's pretty straightforward. If you are interested in an LBC tip for your time, please see https://lbry.io/faq/tips We'll also be adding you to our developer mailing list so we can keep in touch (you can unsubscribe anytime!).
DanielaNarvaez commented 2018-06-01 05:25:14 +02:00 (Migrated from github.com)

Thanks @seanyesmunt for the review, i have updated the code as you requested.
Also thanks @tzarebczan i'm very happy with my first PR. I will send an email soon for the tip.

Thanks @seanyesmunt for the review, i have updated the code as you requested. Also thanks @tzarebczan i'm very happy with my first PR. I will send an email soon for the tip.
neb-b (Migrated from github.com) approved these changes 2018-06-01 06:23:00 +02:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#1530
No description provided.