Fix claim ID being null when reporting a claim that was not previously download. #1530
No reviewers
Labels
No labels
accessibility
app-parity
area: creator
area: daemon
area: design
area: devops
area: discovery
area: docs
area: installer
area: internal
area: livestream
area: performance
area: proposal
area: reposts
area: rewards
area: search
area: security
area: subscriptions
area: sync
area: ux
area: viewer
area: wallet
BEAMER
channel
comments
community PR
consider soon
core team
css
dependencies
electron
Epic
feature request
first-timers-only
good first issue
hacktoberfest
help wanted
hub-dependent
icebox
Invalid
level: 0
level: 1
level: 2
level: 3
level: 4
merge when green
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
notifications
odysee
on hold
playlists
priority: blocker
priority: high
priority: low
priority: medium
protocol dependent
recsys
redesign
regression
resilience
sdk dependent
Tom's Wishlist
trending
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
windows
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: LBRYCommunity/lbry-desktop#1530
Loading…
Reference in a new issue
No description provided.
Delete branch "fix-claim-report"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Closes issue: #1512 properly pass claim ID to the https://lbry.io/dmca?claim_id url, as @tzarebczan told me I will continue to work on https://github.com/lbryio/lbry-app/pull/1425 but for now the fix closes #1512
Just one small change but looks great. Thanks!
Since this is already being passed in from another component, we don't need to specify it here. This is only for selecting props from state.
Woohoo @DaniNz, thanks for the contribution - glad you made it through your first PR! Normally we have a bot that reminds devs about updating the changelog, but it's disabled at the moment. Can you please do so at your earliest convenience? See previous entries for format...it's pretty straightforward.
If you are interested in an LBC tip for your time, please see https://lbry.io/faq/tips
We'll also be adding you to our developer mailing list so we can keep in touch (you can unsubscribe anytime!).
Thanks @seanyesmunt for the review, i have updated the code as you requested.
Also thanks @tzarebczan i'm very happy with my first PR. I will send an email soon for the tip.