Add copy text on contex menu. #1541

Merged

dan1d merged 1 commit from 1538 into master 2018-06-04 22:31:36 +02:00

Conversation 0 Commits 1 Files changed 4 +40 -34

dan1d commented 2018-06-04 02:24:02 +02:00 (Migrated from github.com)

Copy link

Closes #1538 , So when PR got merged It introduced a bug which I didn't test (#1538) , this PR add the context menu event to be listened on the app component inside react rather than doing document.addEventListener, the function onContextMenu can call event.preventDefault && event.stopPropagation on child elements and that will cancel the call to open the menu handled by app component(parent).

Right click on video to copy a link without text being selected(copy is disabled)

Right click on video to copy a link with text selected:

Closes #1538 , So when [PR](https://github.com/lbryio/lbry-app/pull/1486) got merged It introduced a bug which I didn't test (#1538) , this PR add the context menu event to be listened on the `app` component inside react rather than doing `document.addEventListener`, the function `onContextMenu` can call `event.preventDefault` && `event.stopPropagation` on child elements and that will cancel the call to open the menu handled by `app` component(parent).  Right click on video to copy a link without text being selected(copy is disabled)  Right click on video to copy a link with text selected: 

neb-b (Migrated from github.com) approved these changes 2018-06-04 16:51:31 +02:00

Sign in to join this conversation.

Reviewers

No reviewers

neb-b

Labels

Clear labels   

accessibility

  

app-parity

  

area: creator

  

area: daemon

  

area: design

  

area: devops

  

area: discovery

  

area: docs

  

area: installer

  

area: internal

  

area: livestream

  

area: performance

  

area: proposal

Work is part of a proposal

  

area: reposts

  

area: rewards

  

area: search

  

area: security

  

area: subscriptions

  

area: sync

  

area: ux

  

area: viewer

  

area: wallet

  

BEAMER

Beamer is waiting on you!

  

channel

  

comments

  

community PR

  

consider soon

Discuss this issue at the next planning meeting, then remove this label

  

core team

  

css

  

dependencies

  

electron

  

Epic

  

feature request

  

first-timers-only

  

good first issue

  

hacktoberfest

Welcome to Hacktoberfest

  

help wanted

  

hub-dependent

  

icebox

Long-term storage

  

Invalid

  

level: 0

  

level: 1

No knowledge of the existing code required

  

level: 2

Some knowledge of the existing code is recommended

  

level: 3

Significant knowledge of the existing code is recommended

  

level: 4

Intimate knowledge of the existing code is recommended

  

merge when green

  

needs: exploration

Solution unclear, needs research

  

needs: grooming

Issue needs to be groomed before work can start

  

needs: priority

Priority level needs to be defined

  

needs: repro

Issue needs step-by-step instructions on how to reproduce in latest code

  

needs: tech design

Needs technical design signoff before implementation can begin

  

notifications

  

odysee

  

on hold

Temporarily paused

  

playlists

  

priority: blocker

Issue is blocking release, do ASAP

  

priority: high

Work needs to be moved into sprint ASAP

  

priority: low

Work should be done but can stay in the backlog for now

  

priority: medium

Work needs to be done within 2-3 sprints

  

protocol dependent

  

recsys

  

redesign

general redesign not prioritize for anyone release

  

regression

  

resilience

  

sdk dependent

Requires work on lbry-sdk repo

  

Tom's Wishlist

  

trending

  

type: bug

Existing functionality is wrong or broken

  

type: discussion

A conversation. No specific changes requested

  

type: improvement

Existing (or partially existing) functionality needs to be changed

  

type: new feature

New functionality that does not exist yet

  

type: refactor

Minimal user-visible changes, but significant internal work

  

type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

  

type: testing

Solution needs additional user testing

  

unplanned

Work that was not planned into the spirnt, took priority over planned work

  

windows

No labels

accessibility

app-parity

area: creator

area: daemon

area: design

area: devops

area: discovery

area: docs

area: installer

area: internal

area: livestream

area: performance

area: proposal

area: reposts

area: rewards

area: search

area: security

area: subscriptions

area: sync

area: ux

area: viewer

area: wallet

BEAMER

channel

comments

community PR

consider soon

core team

css

dependencies

electron

Epic

feature request

first-timers-only

good first issue

hacktoberfest

help wanted

hub-dependent

icebox

Invalid

level: 0

level: 1

level: 2

level: 3

level: 4

merge when green

needs: exploration

needs: grooming

needs: priority

needs: repro

needs: tech design

notifications

odysee

on hold

playlists

priority: blocker

priority: high

priority: low

priority: medium

protocol dependent

recsys

redesign

regression

resilience

sdk dependent

Tom's Wishlist

trending

type: bug

type: discussion

type: improvement

type: new feature

type: refactor

type: task

type: testing

unplanned

windows

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#1541

No description provided.