Reward cannot be claimed messages when visiting rewards screen #1555

Closed
opened 2018-06-06 00:19:27 +02:00 by tzarebczan · 2 comments
tzarebczan commented 2018-06-06 00:19:27 +02:00 (Migrated from github.com)

The Issue

If you visit the rewards page after your first stream (not featured content) , it tries to claim the Watch Many Things reward and you get a "you haven't watched enough stuff yet" message. It also tries to claim the feature content reward and you get a 2nd message "you haven't watched a featured video from this time period yet". Users will. By confused as to why they are getting this message.

We should fail silently on this check if we perform it automatically.

Steps to Reproduce

  1. Stream soemthing on a new account that's not featured contnet
  2. Visit the rewards page

System Configuration

  • LBRY Daemon version:
  • LBRY App version:
  • LBRY Installation ID:
  • Operating system:

Anything Else

Screenshots

<!-- Thanks for reporting an issue to LBRY and helping us improve! To make it possible for us to help you, please fill out below information carefully. Before reporting any issues, please make sure that you're using the latest version. - App releases: https://github.com/lbryio/lbry-app/releases - Standalone daemon: https://github.com/lbryio/lbry/releases We are also available on live chat at https://chat.lbry.io --> ## The Issue If you visit the rewards page after your first stream (not featured content) , it tries to claim the Watch Many Things reward and you get a "you haven't watched enough stuff yet" message. It also tries to claim the feature content reward and you get a 2nd message "you haven't watched a featured video from this time period yet". Users will. By confused as to why they are getting this message. We should fail silently on this check if we perform it automatically. ### Steps to Reproduce 1. Stream soemthing on a new account that's not featured contnet 2. Visit the rewards page ## System Configuration <!-- For the app, this info is in the About section at the bottom of the Help page. You can include a screenshot instead of typing it out --> <!-- For the daemon, run: curl 'http://localhost:5279' --data '{"method":"version"}' and include the full output --> - LBRY Daemon version: - LBRY App version: - LBRY Installation ID: - Operating system: ## Anything Else <!-- Include anything else that does not fit into the above sections --> ## Screenshots <!-- If a screenshot would help explain the bug, please include one or two here -->
kauffj commented 2018-06-06 16:49:02 +02:00 (Migrated from github.com)

I'm fairly certain this is a regression. Some places in code attempt to auto-check for those rewards but are supposed to swallow failures. @daovist is it is possible your latest reward improvements accidentally changed this?

I'm fairly certain this is a regression. Some places in code attempt to auto-check for those rewards but are supposed to swallow failures. @daovist is it is possible your latest reward improvements accidentally changed this?
tzarebczan commented 2018-06-06 16:50:25 +02:00 (Migrated from github.com)

I don't think it's related to his latest changes... I remember seeing this a while ago but never reproduced it consistently until now.

I don't think it's related to his latest changes... I remember seeing this a while ago but never reproduced it consistently until now.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#1555
No description provided.