LBRYCommunity/lbry-desktop

Fork 0

Make it Easy For People to Find Their Log #1556

New issue

Closed

opened 2018-06-06 05:17:29 +02:00 by QuirkyRobots · 13 comments

QuirkyRobots commented

2018-06-06 05:17:29 +02:00

(Migrated from github.com)

Add a button to auto open log or log folder or both, so that users can send debugging information easier.

Add a button to auto open log or log folder or both, so that users can send debugging information easier. ![image](https://user-images.githubusercontent.com/29914179/41013960-c1ff3f52-698b-11e8-9725-00566111aa92.png)

👍 1

neb-b commented

2018-06-06 06:11:46 +02:00

(Migrated from github.com)

I really like this idea.

❤️ 1

QuirkyRobots commented

2018-06-06 06:19:07 +02:00

(Migrated from github.com)

Required Code

<div className="card__actions">
            <Button
              button="primary"
              label={__('Open Log File')}
              icon={icons.MESSAGE}
              href="{log-location}"
            />
          </div>

Code Location

Adjustments:

New/better icon.
Dynamic log location variable which always points to the correct location regardless of OS.

## Required Code ```js <div className="card__actions"> <Button button="primary" label={__('Open Log File')} icon={icons.MESSAGE} href="{log-location}" /> </div> ``` [Code Location](https://github.com/lbryio/lbry-app/blob/d27308688b05759cea551ce8250d567a5254af6f/src/renderer/page/help/view.jsx) ## Adjustments: - New/better icon. - Dynamic log location variable which always points to the correct location regardless of OS.

kauffj commented

2018-06-06 16:40:11 +02:00

(Migrated from github.com)

Agreed, this is a great idea @Invariant-Change!

The button should probably be somewhere else though. Either a standalone card, or in About?

Agreed, this is a great idea @Invariant-Change! The button should probably be somewhere else though. Either a standalone card, or in About?

❤️ 1

QuirkyRobots commented

2018-06-06 16:45:42 +02:00

(Migrated from github.com)

As a separate section makes it easier to find. So I guess that is the best solution.

Or better still...

As a separate section makes it easier to find. So I guess that is the best solution. ![image](https://user-images.githubusercontent.com/29914179/41045626-1337771c-69ec-11e8-91f7-098212bb1ce8.png) Or better still... ![image](https://user-images.githubusercontent.com/29914179/41045922-bdc8cfd2-69ec-11e8-8896-ce84cad46698.png)

amitnndn commented

2018-06-09 00:39:27 +02:00

(Migrated from github.com)

I will take this up!

I had a couple of questions/clarifications - @kauffj @seanyesmunt

The log files location are mentioned in this post and I am assuming that this is the right file.
I know that the electron shell plugin allows you to open external files that are on the file system, but it cannot open files with relative paths. Does anyone know how I can access properties like the user's home directory etc.?

I will take this up! I had a couple of questions/clarifications - @kauffj @seanyesmunt * The log files location are mentioned in [this post](https://lbry.io/faq/how-to-find-lbry-log-file) and I am assuming that this is the right file. * I know that the electron shell plugin allows you to open external files that are on the file system, but it cannot open files with relative paths. Does anyone know how I can access properties like the user's home directory etc.?

tzarebczan commented

2018-06-09 01:27:17 +02:00

(Migrated from github.com)

@amitnndn take a look at how we do this on the backup page: afaad1910e/src/renderer/page/backup/view.jsx

In this case, the setting is: data_dir

@amitnndn take a look at how we do this on the backup page: https://github.com/lbryio/lbry-app/blob/afaad1910e84d27140abaa696af53a985349c53d/src/renderer/page/backup/view.jsx In this case, the setting is: `data_dir`

amitnndn commented

2018-06-09 01:40:41 +02:00

(Migrated from github.com)

@tzarebczan Thank you! I will take a look at it.

amitnndn commented

2018-06-16 05:58:11 +02:00

(Migrated from github.com)

#1600 I see that there is an issue opened, that is related to the changes in this issue. Can anybody with a Windows 10 system, click on the open log folder and let me know what folder it ends up opening? Thank you!

tzarebczan commented

2018-06-16 05:59:24 +02:00

(Migrated from github.com)

On windows 10 and Mac, it opens to the parent folder of lbrynet, with it highlighted. Think you want to pass the logfile and have it open that folder.

amitnndn commented

2018-06-16 06:02:27 +02:00

(Migrated from github.com)

@tzarebczan Is that happening when you click on 'Open Log Folder' or 'Open Log'?

tzarebczan commented

2018-06-16 06:03:09 +02:00

(Migrated from github.com)

It's described in the issue. It happens when you click open log folder. Open log opens the logfile in notepad correctly.

amitnndn commented

2018-06-16 06:04:24 +02:00

(Migrated from github.com)

Got it! 👍 A bit of a lag in my brain registering an Issue on a Friday night!!